Support coverage analysis #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdboom
force-pushed
the
coverage-analysis
branch
from
bc6f85f to
205d64a
Compare
badboy
approved these changes
Feb 18, 2021
Member
badboy
left a comment
badboy
left a comment
There was a problem hiding this comment.
As mentioned in channel:
- filename vs filepath?
- Please mark the "coverage" subcommand as "experimental" or something in the changelog.
Otherwise good to go.
mdboom
force-pushed
the
coverage-analysis
branch
from
205d64a to
dc7ef94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
make testruns without emitting any warningsmake lintruns without emitting any errorsHISTORY.rstor an explanation of why it does not need one