Skip to content

Update JS doc for string_list #1780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2021
Merged

Update JS doc for string_list #1780

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7332f0
Update JS doc for string_list
ChinYing-Li Sep 5, 2021
c5037ed
Restore Firefox API of string_list
ChinYing-Li Sep 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 25 additions & 3 deletions docs/user/reference/metrics/string_list.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,14 @@ search::engines.add("duck duck go".to_string());
```

</div>
<div data-lang="JavaScript" class="tab"></div>
<div data-lang="JavaScript" class="tab">

```js
Glean.search.engines.add("wikipedia");
Glean.search.engines.add("duck duck go");
```

</div>
<div data-lang="Firefox Desktop" class="tab">

**C++**
Expand Down Expand Up @@ -145,7 +152,13 @@ search::engines.set(vec!["wikipedia".to_string(), "duck duck go".to_string()])
```

</div>
<div data-lang="JavaScript" class="tab"></div>
<div data-lang="JavaScript" class="tab">

```js
Glean.search.engines.set(["wikipedia", "duck duck go"]);
```

</div>
<div data-lang="Firefox Desktop" class="tab">

**C++**
Expand Down Expand Up @@ -234,7 +247,16 @@ assert_eq!(
```

</div>
<div data-lang="JavaScript" class="tab"></div>
<div data-lang="JavaScript" class="tab">

```js
// testGetValue will throw NS_ERROR_LOSS_OF_SIGNIFICANT_DATA on error.
const engines = Glean.search.engines.testGetValue();
Assert.ok(engines.includes("wikipedia"));
Assert.ok(engines.includes("duck duck go"));
```

</div>
<div data-lang="Firefox Desktop" class="tab">

**C++**
Expand Down