Bug 1694715: Add testing against schema for the rate metric type #1529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdboom
commented
Mar 1, 2021
| ..Default::default() | ||
| }, | ||
| ], | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
@chutten pointed out in Matrix that maybe we should document how to make these in the developer docs. First, to confirm that this is correct, though...
chutten
reviewed
Mar 1, 2021
Contributor
chutten
left a comment
chutten
left a comment
There was a problem hiding this comment.
There seem to be a lot of changes not related to the rate type in this local schema copy. Where are they from?
|
|
||
| let rate_metric: RateMetric = RateMetric::new(CommonMetricData { | ||
| name: "rate".into(), | ||
| category: "test".into(), |
Contributor
There was a problem hiding this comment.
Can we put the category first so I can read it in the same order ( test.rate ) that it appears in the payload?
Contributor
Author
The vendored copy of the schema hasn't been updated in a while. Something to add to the developer docs... |
mdboom
force-pushed
the
add-rate-payload-schema
branch
from
93dae34 to
61598dd
Compare
chutten
approved these changes
Mar 2, 2021
| ..Default::default() | ||
| }, | ||
| ], | ||
| ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should block this on mozilla-services/mozilla-pipeline-schemas#661, since this pulls in the new schema from there.
This just adds rate metric type data to the existing RLB schema validation unit test to make sure the output matches the schema.
No
CHANGELOGentry since this is purely testing...