Merge pull request #1755 from rosahbruno/1849862-url-set-fix

Author: rosahbruno

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 [Full changelog](https://github.com/mozilla/glean.js/compare/v2.0.1...main)
 
+* [#1755](https://github.com/mozilla/glean.js/pull/1755): Add sync check to `set` function for the URL metric.
+
 # v2.0.1 (2023-08-11)
 
 [Full changelog](https://github.com/mozilla/glean.js/compare/v2.0.0...v2.0.1)

glean/src/core/metrics/types/url.ts

@@ -90,6 +90,14 @@ class InternalUrlMetricType extends MetricType {
   }
 
   /// SHARED ///
+  set(url: string): void {
+    if (Context.isPlatformSync()) {
+      this.setSync(url);
+    } else {
+      this.setAsync(url);
+    }
+  }
+
   setUrl(url: URL): void {
     if (Context.isPlatformSync()) {
       this.setSync(url.toString());
@@ -100,10 +108,6 @@ class InternalUrlMetricType extends MetricType {
 
   /// ASYNC ///
   setAsync(url: string) {
-    this.set(url);
-  }
-
-  set(url: string): void {
     Context.dispatcher.launch(async () => {
       if (!this.shouldRecord(Context.uploadEnabled)) {
         return;