Add test coverage

Author: Dexterp37

glean/tests/core/pings/index.spec.ts

@@ -107,4 +107,64 @@ describe("PingType", function() {
     const storedPings = await Context.pingsDatabase["store"]._getWholeStore();
     assert.strictEqual(Object.keys(storedPings).length, 0);
   });
+
+  it("runs a validator with no metrics tests", async function() {
+    const ping = new PingType({
+      name: "custom",
+      includeClientId: true,
+      sendIfEmpty: false,
+      reasonCodes: ["test"]
+    });
+
+    // We did not call the testing API yet, internals should be undefined.
+    assert.strictEqual(ping["testResolutionFunction"], undefined);
+    assert.strictEqual(ping["testValidator"], undefined);
+
+    let validatorRun = false;
+    const p = ping.testBeforeNextSubmit(r => {
+      assert.strictEqual(r, "test");
+      validatorRun = true;
+      return Promise.resolve();
+    });
+
+    // Internals should be defined after the API was called.
+    assert.notStrictEqual(ping["testResolutionFunction"], undefined);
+    assert.notStrictEqual(ping["testValidator"], undefined);
+
+    ping.submit("test");
+    await p;
+
+    assert.ok(validatorRun);
+  });
+
+  it("runs a validator with metrics tests", async function() {
+    const TEST_VALUE = 2908;
+
+    const ping = new PingType({
+      name: "custom",
+      includeClientId: true,
+      sendIfEmpty: false,
+      reasonCodes: ["test"]
+    });
+    const counter = new CounterMetricType({
+      category: "aCategory",
+      name: "aCounterMetric",
+      sendInPings: ["custom"],
+      lifetime: Lifetime.Ping,
+      disabled: false
+    });
+    counter.add(TEST_VALUE);
+
+    let validatorRun = false;
+    const p = ping.testBeforeNextSubmit(async r => {
+      assert.strictEqual(r, "test");
+      assert.strictEqual(await counter.testGetValue(), TEST_VALUE);
+      validatorRun = true;
+    });
+
+    ping.submit("test");
+    await p;
+
+    assert.ok(validatorRun);
+  });
 });