Expose the missing metrics on the QT platform (#273)

* Update the README to use virtual environments

* Fix a typo in a comment

* Export the missing labeled and timespan types

* Add a changelog entry

* Apply suggestions from code review

Co-authored-by: Jan-Erik Rediger <badboy@archlinux.us>

Co-authored-by: Jan-Erik Rediger <badboy@archlinux.us>

Author: Dexterp37

CHANGELOG.md

@@ -8,6 +8,7 @@
   * Implement the timespan metric type.
   * BUGFIX: Report event timestamps in milliseconds.
 * [#261](https://github.com/mozilla/glean.js/pull/261): Show a spinner while setting up python virtual environment
+* [#273](https://github.com/mozilla/glean.js/pull/273): BUGFIX: Expose the missing `LabeledMetricType` and `TimespanMetricType` in Qt.
 
 # v0.10.2 (2021-04-26)
 

glean/src/index/qt.ts

@@ -13,7 +13,9 @@ import BooleanMetricType from "../core/metrics/types/boolean.js";
 import CounterMetricType from "../core/metrics/types/counter.js";
 import DatetimeMetricType from "../core/metrics/types/datetime.js";
 import EventMetricType from "../core/metrics/types/event.js";
+import LabeledMetricType from "../core/metrics/types/labeled.js";
 import StringMetricType from "../core/metrics/types/string.js";
+import TimespanMetricType from "../core/metrics/types/timespan.js";
 import UUIDMetricType from "../core/metrics/types/uuid.js";
 
 export default {
@@ -129,7 +131,9 @@ export default {
     CounterMetricType,
     DatetimeMetricType,
     EventMetricType,
+    LabeledMetricType,
     StringMetricType,
+    TimespanMetricType,
     UUIDMetricType
   }
 };

glean/src/platform/qt/index.ts

@@ -3,5 +3,5 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 // Qt does not have its implementations yet,
-// we leavet his here so that the sample will still work.
+// we leave this here so that the sample will still work.
 export { default } from "../test";

samples/qt-qml-app/README.md

@@ -13,20 +13,28 @@ The app will display a button that when clicked should trigger Glean.js events.
 npm run build:qt
 ```
 
+2. Whithin this sample directory, run the command to create a Python 3 virtual environment.
+
+```bash
+python3 -m venv .venv
+```
+
 2. Install the dependencies.
 
 ```bash
-pip install -r requirements.txt
+.venv/bin/pip3 install -r requirements.txt
 ```
 
 3. Generate metrics and pings files.
 
 ```bash
-glean_parser translate metrics.yaml pings.yaml -f javascript -o generated --option platform=qt
+.venv/bin/python3 -m glean_parser translate metrics.yaml pings.yaml -f javascript -o generated --option platform=qt
 ```
 
 4. Run the application.
 
 ```bash
-python main.py
+.venv/bin/python3 main.py
 ```
+
+> *Important*: if running the application fails, turn on Qt debugging by setting the `QT_DEBUG_PLUGINS` environment variable to `1`, e.g. `export QT_DEBUG_PLUGINS=1`.