Merge pull request #191 from Dexterp37/ts_type_lint

Bug 1704505 - Enable @typescript-eslint/consistent-type-imports

Author: Dexterp37

glean/.eslintrc

@@ -18,6 +18,7 @@
     ],
     "semi": "off",
     "@typescript-eslint/semi": ["error", "always"],
+    "@typescript-eslint/consistent-type-imports": "error",
     "no-debugger":  ["error"],
     "no-multi-spaces": "error",
     "jsdoc/no-types": "off",

glean/src/core/config.ts

@@ -3,10 +3,10 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 import { DEFAULT_TELEMETRY_ENDPOINT, GLEAN_MAX_SOURCE_TAGS } from "./constants.js";
-import Plugin from "../plugins/index.js";
+import type Plugin from "../plugins/index.js";
 import { validateHeader, validateURL } from "./utils.js";
-import Uploader from "./upload/uploader.js";
-import { DebugOptions } from "./debug_options.js";
+import type Uploader from "./upload/uploader.js";
+import type { DebugOptions } from "./debug_options.js";
 
 /**
  * Describes how to configure Glean.

glean/src/core/events/index.ts

@@ -4,8 +4,8 @@
 
 import type Plugin from "../../plugins/index.js";
 
-import { PingPayload } from "../pings/ping_payload.js";
-import { JSONObject } from "../utils.js";
+import type { PingPayload } from "../pings/ping_payload.js";
+import type { JSONObject } from "../utils.js";
 
 export class CoreEvent<
    // An array of arguments that the event will provide as context to the plugin action.

glean/src/core/events/utils.ts

@@ -2,8 +2,9 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
-import CoreEvents, { CoreEvent } from "./index.js";
-import Plugin from "../../plugins/index.js";
+import type { CoreEvent } from "./index.js";
+import CoreEvents from "./index.js";
+import type Plugin from "../../plugins/index.js";
 
 /**
  * Registers a plugin to the desired Glean event.

glean/src/core/glean.ts

@@ -3,7 +3,8 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 import { CLIENT_INFO_STORAGE, KNOWN_CLIENT_ID } from "./constants.js";
-import { Configuration, ConfigurationInterface } from "./config.js";
+import type { ConfigurationInterface } from "./config.js";
+import { Configuration } from "./config.js";
 import MetricsDatabase from "./metrics/database.js";
 import PingsDatabase from "./pings/database.js";
 import PingUploader from "./upload/index.js";
@@ -17,9 +18,9 @@ import Dispatcher from "./dispatcher.js";
 import CorePings from "./internal_pings.js";
 import { registerPluginToEvent, testResetEvents } from "./events/utils.js";
 
-import Platform from "../platform/index.js";
+import type Platform from "../platform/index.js";
 import TestPlatform from "../platform/test/index.js";
-import { DebugOptions } from "./debug_options.js";
+import type { DebugOptions } from "./debug_options.js";
 import { Lifetime } from "./metrics/lifetime.js";
 
 class Glean {

glean/src/core/internal_metrics.ts

@@ -9,9 +9,9 @@ import StringMetricType from "./metrics/types/string.js";
 import { createMetric } from "./metrics/utils.js";
 import TimeUnit from "./metrics/time_unit.js";
 import { generateUUIDv4 } from "./utils.js";
-import { ConfigurationInterface } from "./config.js";
-import Platform from "../platform/index.js";
-import MetricsDatabase from "./metrics/database.js";
+import type { ConfigurationInterface } from "./config.js";
+import type Platform from "../platform/index.js";
+import type MetricsDatabase from "./metrics/database.js";
 import { Lifetime } from "./metrics/lifetime.js";
 
 /**

glean/src/core/metrics/database.ts

@@ -2,13 +2,14 @@
 //  * License, v. 2.0. If a copy of the MPL was not distributed with this
 //  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
-import Store from "../storage/index.js";
-import { MetricType } from "./index.js";
-import { Metric } from "./metric.js";
+import type Store from "../storage/index.js";
+import type { MetricType } from "./index.js";
+import type { Metric } from "./metric.js";
 import { createMetric, validateMetricInternalRepresentation } from "./utils.js";
-import { isObject, isUndefined, JSONObject, JSONValue } from "../utils.js";
-import { StorageBuilder } from "../../platform/index.js";
-import { Metrics } from "./metrics_interface";
+import type { JSONObject, JSONValue } from "../utils.js";
+import { isObject, isUndefined } from "../utils.js";
+import type { StorageBuilder } from "../../platform/index.js";
+import type { Metrics } from "./metrics_interface";
 import { Lifetime } from "./lifetime.js";
 
 /**

glean/src/core/metrics/events_database.ts

@@ -2,10 +2,11 @@
 //  * License, v. 2.0. If a copy of the MPL was not distributed with this
 //  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
-import Store from "../storage/index.js";
-import { isUndefined, JSONArray, JSONObject, JSONValue } from "../utils.js";
+import type Store from "../storage/index.js";
+import type { JSONArray, JSONObject, JSONValue } from "../utils.js";
+import { isUndefined } from "../utils.js";
 import type EventMetricType from "./types/event.js";
-import { StorageBuilder } from "../../platform/index.js";
+import type { StorageBuilder } from "../../platform/index.js";
 
 // An helper type for the 'extra' map.
 export type ExtraMap = Record<string, string>;

glean/src/core/metrics/index.ts

@@ -2,10 +2,11 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
-import { isUndefined, JSONValue } from "../utils.js";
+import type { JSONValue } from "../utils.js";
+import { isUndefined } from "../utils.js";
 import LabeledMetricType from "./types/labeled.js";
 import { Metric } from "./metric.js";
-import { Lifetime } from "./lifetime.js";
+import type { Lifetime } from "./lifetime.js";
 
 /**
  * The common set of data shared across all different metric types.

glean/src/core/metrics/metric.ts

@@ -2,7 +2,7 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
-import { JSONValue } from "../utils.js";
+import type { JSONValue } from "../utils.js";
 
 /**
  * The Metric class describes the shared behaviour amongst concrete metrics.