Skip to content

Commit 9ff1adf

Browse files
committed
Fix prepare release script
1 parent 13041d7 commit 9ff1adf

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

.circleci/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ jobs:
132132
source venv/bin/activate
133133
pip install -r requirements.txt
134134
glean_parser translate metrics.yaml pings.yaml -f javascript -o generated \
135-
--option platform=qt --option version="0.15";
135+
--option platform=qt --option version="0.16"
136136
137137
sudo apt-get install xvfb
138138
xvfb-run python main.py &> qml.log &

bin/prepare-release.sh

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,14 @@ GLEAN_VERSION_FOR_QML=$(node -p -e "'${NEW_VERSION}'.split('.').reverse().slice(
122122

123123
FILE=samples/qt-qml-app/main.qml
124124
run $SED -i.bak -E \
125-
-e "s/import org.mozilla.Glean [0-9a-z.-]+/import org.mozilla.Glean ${GLEAN_VERSION_FOR_QML};/" \
126-
-e "s/import generated [0-9a-z.-]+/import generated ${GLEAN_VERSION_FOR_QML};/" \
125+
-e "s/import org.mozilla.Glean [0-9a-z.-]+;/import org.mozilla.Glean ${GLEAN_VERSION_FOR_QML};/" \
126+
-e "s/import generated [0-9a-z.-]+;/import generated ${GLEAN_VERSION_FOR_QML};/" \
127+
"${WORKSPACE_ROOT}/${FILE}"
128+
run rm "${WORKSPACE_ROOT}/${FILE}.bak"
129+
130+
FILE=.circleci/config.yml
131+
run $SED -i.bak -E \
132+
-e "s/--option platform=qt --option version=\"[0-9a-z.-]+\"/--option platform=qt --option version=\"${GLEAN_VERSION_FOR_QML}\"/" \
127133
"${WORKSPACE_ROOT}/${FILE}"
128134
run rm "${WORKSPACE_ROOT}/${FILE}.bak"
129135

samples/qt-qml-app/main.qml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ import QtQuick 2.0
66
import QtQuick.Controls 2.0
77
import QtGraphicalEffects 1.15
88

9-
import org.mozilla.Glean 0.16;;
10-
import generated 0.16;;
9+
import org.mozilla.Glean 0.16;
10+
import generated 0.16;
1111

1212
Rectangle {
1313
id: screen

0 commit comments

Comments
 (0)