Skip to content

Commit 9bc1733

Browse files
committed
Add note about testGetNumRecordedErrors to adding metric types doc
1 parent e227f5a commit 9bc1733

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

docs/adding_a_new_metric_type.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,9 @@ async function testGetValue(ping: string = this.sendInPings[0]): Promise<string
169169

170170
> **Note**: All testing functions must start with the prefix `test`.
171171
172+
The `testGetNumRecordedErrors` function does not need to be implemeted individually per metric
173+
type as it is already implemented on the `MetricType` super class.
174+
172175
## Testing
173176

174177
Tests for metric type implementations live under the `glean/tests/unit/core/metrics/types` folder. Create a new

0 commit comments

Comments
 (0)