Merge pull request #431 from Dexterp37/events_tresh

[no bug] Record the events timestamp before dispatching

Author: Dexterp37

CHANGELOG.md

@@ -8,6 +8,7 @@
 * [#415](https://github.com/mozilla/glean.js/pull/415): Gzip ping paylod before upload
   * This changes the signature of `Uploader.post` to accept `string | Uint8Array` for the `body` parameter, instead of only `string`.
   * The gizpping functionality is disabled in Qt/QML environments. Follow [Bug 1716322](https://bugzilla.mozilla.org/show_bug.cgi?id=1716322) for updates on the status of this feature on that platform.
+* [#431](https://github.com/mozilla/glean.js/pull/431): BUGFIX: Record the timestamp for events before dispatching to the internal task queue.
 
 # v0.15.0 (2021-06-03)
 

glean/src/core/metrics/types/event.ts

@@ -33,13 +33,13 @@ class EventMetricType extends MetricType {
    *        The maximum length for values is 100 bytes.
    */
   record(extra?: ExtraMap): void {
+    const timestamp = getMonotonicNow();
+
     Context.dispatcher.launch(async () => {
       if (!this.shouldRecord(Context.uploadEnabled)) {
         return;
       }
 
-      const timestamp = getMonotonicNow();
-
       // Truncate the extra keys, if needed.
       let truncatedExtra: ExtraMap | undefined = undefined;
       if (extra && this.allowedExtraKeys) {

glean/src/metrics.yaml

@@ -222,12 +222,16 @@ glean.internal.metrics:
     expires: never
 
   seq:
-    type: string
+    type: counter
     lifetime: user
     send_in_pings:
       - glean_internal_info
     description: |
-      A running counter of the number of times pings of this type have been sent
+      A running counter of the number of times pings of this type have been
+      sent.
+      This metric definition is only used for documentation purposes:
+      internally, Glean instantiates the metric manually and calls it
+      `sequence`.
     bugs:
       - https://bugzilla.mozilla.org/show_bug.cgi?id=1556964
     data_reviews: