Skip to content

Commit 8a5dba8

Browse files
committed
Attend to review comments
1 parent 325f597 commit 8a5dba8

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

glean/src/core/upload/uploader.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,9 @@ export interface Uploader {
4343
* Makes a POST request to a given url, with the given headers and body.
4444
*
4545
* @param url The URL to make the POST request
46-
* @param body The stringified body of this post request
46+
* @param body The body of this post request. The body may be a stringified JSON or, most likely,
47+
* a Uint8Array containing the gzipped version of said stringified JSON. We need to accept
48+
* both in case the compression fails.
4749
* @param headers Optional header to include in the request
4850
* @returns The status code of the response.
4951
*/

glean/src/platform/qt/fflate.stub.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,8 @@
1010

1111
// eslint-disable-next-line jsdoc/require-jsdoc
1212
export function gzipSync() {
13+
// We throw here because when the gzipping action throws the ping upload manager will
14+
// catch and send the uncompressed ping, which is what we want on QML for the time being.
15+
// We are trying to figure out how to actually add the gzipping step to QML on Bug 1716322.
1316
throw new Error("Attempted to use `gzipSync` from QML, but that is not supported.");
1417
}

0 commit comments

Comments
 (0)