Record error and add testGetNumRecorded errors API to uuid metric

Author: brizental

glean/src/core/metrics/types/uuid.ts

@@ -7,6 +7,7 @@ import { MetricType } from "../index.js";
 import { generateUUIDv4, isString } from "../../utils.js";
 import { Context } from "../../context.js";
 import { Metric } from "../metric.js";
+import { ErrorType, recordError, testGetNumRecordedErrors } from "../../error_recording.js";
 
 // Loose UUID regex for checking if a string has a UUID _shape_. Does not contain version checks.
 //
@@ -67,8 +68,11 @@ class UUIDMetricType extends MetricType {
     try {
       metric = new UUIDMetric(value);
     } catch {
-      // TODO: record error once Bug 1682574 is resolved.
-      console.warn(`"${value}" is not a valid UUID. Ignoring`);
+      await recordError(
+        instance,
+        ErrorType.InvalidValue,
+        `"${value}" is not a valid UUID.`
+      );
       return;
     }
 
@@ -123,6 +127,19 @@ class UUIDMetricType extends MetricType {
     });
     return metric;
   }
+
+  /**
+   * Returns the number of errors recorded for the given metric.
+   *
+   * @param errorType The type of the error recorded.
+   * @param pingName represents the name of the ping to retrieve the metric for.
+   *        Defaults to the first value in `sendInPings`.
+   *
+   * @return the number of errors recorded for the metric.
+   */
+   async testGetNumRecordedErrors(errorType: string, ping: string = this.sendInPings[0]): Promise<number> {
+    return testGetNumRecordedErrors(this, errorType as ErrorType, ping);
+  }
 }
 
 export default UUIDMetricType;

glean/tests/core/metrics/uuid.spec.ts

@@ -9,6 +9,7 @@ import Glean from "../../../src/core/glean";
 import UUIDMetricType from "../../../src/core/metrics/types/uuid";
 import { Lifetime } from "../../../src/core/metrics/lifetime";
 import { Context } from "../../../src/core/context";
+import { ErrorType } from "../../../src/core/error_recording";
 
 describe("UUIDMetric", function() {
   const testAppId = `gleanjs.test.${this.title}`;
@@ -45,8 +46,6 @@ describe("UUIDMetric", function() {
   });
 
   it("attempting to set an invalid uuid is a no-op", async function() {
-    Glean.setUploadEnabled(false);
-
     const metric = new UUIDMetricType({
       category: "aCategory",
       name: "aUUIDMetric",
@@ -57,6 +56,7 @@ describe("UUIDMetric", function() {
 
     metric.set("not valid");
     assert.strictEqual(await metric.testGetValue("aPing"), undefined);
+    assert.strictEqual(await metric.testGetNumRecordedErrors(ErrorType.InvalidValue), 1);
   });
 
   it("ping payload is correct", async function() {