Skip to content

Commit 4406afb

Browse files
author
Beatriz Rizental
authored
Merge pull request #1046 from brizental/1742613-remove-headers
Bug 1742613 - Remove deprecated headers from Glean pings
2 parents 068404e + 2aae42a commit 4406afb

File tree

3 files changed

+2
-4
lines changed

3 files changed

+2
-4
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
new behaviour only deletes the actually invalid data and leave the rest of the ping intact.
88
* [#1065](https://github.com/mozilla/glean.js/pull/1065): Only import metric types into the library when they are used either by the user or Glean itself.
99
* Previously the code required to deserialize metric data from the database was always imported by the library even if the metric type was never used by the client. This effort will decrease the size of the Glean.js bundles that don't import all the metric types.
10+
* [#1046](https://github.com/mozilla/glean.js/pull/1046): Remove legacy X-Client-Type X-Client-Version from Glean pings.
11+
1012
# v0.30.0 (2022-01-10)
1113

1214
[Full changelog](https://github.com/mozilla/glean.js/compare/v0.29.0...v0.30.0)

glean/src/core/upload/worker.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,6 @@ class PingUploadWorker {
7070
...ping.headers,
7171
"Content-Type": "application/json; charset=utf-8",
7272
"Date": (new Date()).toISOString(),
73-
"X-Client-Type": "Glean.js",
74-
"X-Client-Version": GLEAN_VERSION,
7573
"X-Telemetry-Agent": `Glean/${GLEAN_VERSION} (JS on ${await Context.platform.info.os()})`
7674
};
7775

glean/tests/unit/core/upload/worker.spec.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -216,8 +216,6 @@ describe("PingUploadWorker", function() {
216216
assert.ok("Date" in headers);
217217
assert.ok("Content-Length" in headers);
218218
assert.ok("Content-Type" in headers);
219-
assert.ok("X-Client-Type" in headers);
220-
assert.ok("X-Client-Version" in headers);
221219
assert.ok("X-Telemetry-Agent" in headers);
222220
assert.strictEqual(headers["Content-Encoding"], "gzip");
223221
});

0 commit comments

Comments
 (0)