Skip to content

Commit 37ea5f4

Browse files
author
Beatriz Rizental
authored
Merge pull request #206 from mozilla/app-id-typo
Fix typo on Context.ts
2 parents eb58d5d + c0b22d7 commit 37ea5f4

File tree

3 files changed

+6
-1
lines changed

3 files changed

+6
-1
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
[Full changelog](https://github.com/mozilla/glean.js/compare/v0.8.0...main)
44

5+
* [#206](https://github.com/mozilla/glean.js/pull/206): BUGFIX: Fix ping URL path.
6+
* Application ID was being reporting as `undefined`.
7+
58
# v0.8.0 (2021-04-13)
69

710
[Full changelog](https://github.com/mozilla/glean.js/compare/v0.7.0...v0.8.0)

glean/src/core/context.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ export class Context {
7979
Context.instance._pingsDatabase = db;
8080
}
8181

82-
static get applicatinId(): string {
82+
static get applicationId(): string {
8383
return Context.instance._applicationId;
8484
}
8585

glean/tests/core/upload/index.spec.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -207,10 +207,12 @@ describe("PingUploader", function() {
207207
await waitForGleanUploader();
208208

209209
const url = postSpy.firstCall.args[0].split("/");
210+
const appId = url[url.length - 4];
210211
const documentId = url[url.length - 1];
211212
const headers = postSpy.firstCall.args[2] || {};
212213

213214
assert.strictEqual(documentId, expectedDocumentId);
215+
assert.strictEqual(appId, Context.applicationId);
214216

215217
assert.ok("Date" in headers);
216218
assert.ok("User-Agent" in headers);

0 commit comments

Comments
 (0)