Skip to content

Commit 2ead1b3

Browse files
committed
Fix lint errors and removed console.log
1 parent e13f374 commit 2ead1b3

File tree

3 files changed

+12
-10
lines changed

3 files changed

+12
-10
lines changed

glean/src/core/glean.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,7 @@ namespace Glean {
327327

328328
// Record click events if the client has auto click events enabled.
329329
if (config?.enableAutoClickEvents) {
330-
document.addEventListener('click', (event) => {
330+
document.addEventListener("click", (event) => {
331331
GleanMetrics.handleClickEvent(event);
332332
});
333333
}

glean/src/core/glean_metrics.ts

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -97,16 +97,18 @@ namespace GleanMetrics {
9797
});
9898
}
9999

100+
/**
101+
* Handle "click" event on an element.
102+
*
103+
* It records click events on anchor element. Rest of the events are ignored.
104+
*
105+
* @param event Event object.
106+
*/
100107
export function handleClickEvent(event: Event) {
101-
let element = event.target as Element;
102-
console.log("element: ", element.tagName);
108+
// handle click event on anchor html element
103109
if ((event.target as Element)?.tagName.toUpperCase() === "A") {
104-
let anchorElement = event.target as HTMLAnchorElement;
105-
const elementUrl = anchorElement.href;
106-
const elementId = anchorElement.id;
107-
const elementClass = anchorElement.className;
108-
console.log("href, id, classes, innerHTML: ", elementUrl, elementId, elementClass, anchorElement.innerHTML);
109-
recordAnchorClick({ url: elementUrl, id : elementId, class : elementClass });
110+
const anchorElement = event.target as HTMLAnchorElement;
111+
recordAnchorClick({ url: anchorElement.href, id : anchorElement.id, class : anchorElement.className });
110112
}
111113
}
112114

glean/src/metrics.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -454,7 +454,7 @@ glean:
454454
bugs:
455455
- https://bugzilla.mozilla.org/show_bug.cgi?id=1867294
456456
data_reviews:
457-
- #ToDo
457+
- https://bugzilla.mozilla.org/show_bug.cgi?id=1867294 #ToDo
458458
data_sensitivity:
459459
- interaction
460460
notification_emails:

0 commit comments

Comments
 (0)