HOUSEKEEPING: Minor fixes all over

Author: brizental

glean/src/core/dispatcher.ts

@@ -47,7 +47,7 @@ const enum Commands {
   // The dispatcher will clear the queue and go into the Shutdown state.
   Shutdown,
   // Exactly like a normal Task, but spawned for tests.
-  TestTask = "TestTask",
+  TestTask,
 }
 
 // A task the dispatcher knows how to execute.

glean/src/core/glean.ts

@@ -218,11 +218,7 @@ class Glean {
     Context.pingsDatabase = new PingsDatabase(Glean.platform.Storage);
     Context.errorManager = new ErrorManager();
 
-    Glean.instance._pingUploader = new PingUploader(
-      correctConfig,
-      Glean.platform,
-      Context.pingsDatabase
-    );
+    Glean.instance._pingUploader = new PingUploader(correctConfig, Glean.platform);
 
     Context.pingsDatabase.attachObserver(Glean.pingUploader);
 
@@ -286,6 +282,10 @@ class Glean {
         }
       }
 
+      // We only scan the pendings pings **after** dealing with the upload state.
+      // If upload is disabled, we delete all pending pings files
+      // and we need to do that **before** scanning the pending pings
+      // to ensure we don't enqueue pings before their files are deleted.
       await Context.pingsDatabase.scanPendingPings();
     });
   }

glean/src/core/upload/index.ts

@@ -90,16 +90,15 @@ class PingUploader implements PingsDatabaseObserver {
   constructor(
     config: Configuration,
     platform: Platform,
-    private readonly pingsDatabase: PingsDatabase,
-    private readonly policy = new Policy
+    private readonly pingsDatabase = Context.pingsDatabase,
+    private readonly policy = new Policy()
   ) {
     this.processing = [];
     // Initialize the ping uploader with either the platform defaults or a custom
     // provided uploader from the configuration object.
     this.uploader = config.httpClient ? config.httpClient : platform.uploader;
     this.platformInfo = platform.info;
     this.serverEndpoint = config.serverEndpoint;
-    this.pingsDatabase = pingsDatabase;
 
     // Initialize the dispatcher immediatelly.
     this.dispatcher = createAndInitializeDispatcher();
@@ -124,6 +123,7 @@ class PingUploader implements PingsDatabaseObserver {
 
     // If the ping is a deletion-request ping, we want to enqueue it as a persistent task,
     // so that clearing the queue does not clear it.
+    //
     // eslint-disable-next-line @typescript-eslint/unbound-method
     const launchFn = isDeletionRequest(ping) ? this.dispatcher.launchPersistent : this.dispatcher.launch;
 
@@ -298,7 +298,6 @@ class PingUploader implements PingsDatabaseObserver {
     if (status && status >= 200 && status < 300) {
       log(LOG_TAG, `Ping ${identifier} succesfully sent ${status}.`, LoggingLevel.Info);
       await this.pingsDatabase.deletePing(identifier);
-      this.processing;
       return false;
     }