Skip to content

Commit 14af0bf

Browse files
committed
Merge branch 'release-v0.17.0' into release
2 parents 1cfdb5a + fede13f commit 14af0bf

File tree

28 files changed

+1514
-741
lines changed

28 files changed

+1514
-741
lines changed

.circleci/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ jobs:
132132
source venv/bin/activate
133133
pip install -r requirements.txt
134134
glean_parser translate metrics.yaml pings.yaml -f javascript -o generated \
135-
--option platform=qt --option version="0.16"
135+
--option platform=qt --option version="0.17"
136136
137137
sudo apt-get install xvfb
138138
xvfb-run python main.py &> qml.log &

CHANGELOG.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
# Unreleased changes
22

3-
[Full changelog](https://github.com/mozilla/glean.js/compare/v0.16.0...main)
3+
[Full changelog](https://github.com/mozilla/glean.js/compare/v0.17.0...main)
4+
5+
# v0.17.0 (2021-07-16)
6+
7+
[Full changelog](https://github.com/mozilla/glean.js/compare/v0.16.0...v0.17.0)
8+
9+
* [#529](https://github.com/mozilla/glean.js/pull/529): Implement the URL metric type.
410

511
# v0.16.0 (2021-07-06)
612

benchmarks/size/webext/max.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import QuantityMetricType from "@mozilla/glean/webext/private/metrics/quantity";
1313
import StringMetricType from "@mozilla/glean/webext/private/metrics/string";
1414
import TimespanMetricType from "@mozilla/glean/webext/private/metrics/timespan";
1515
import UUIDMetricType from "@mozilla/glean/webext/private/metrics/uuid";
16+
import URLMetricType from "@mozilla/glean/webext/private/metrics/url";
1617
// Plugins
1718
import PingEncryptionPlugin from "@mozilla/glean/webext/plugins/encryption";
1819

@@ -29,5 +30,6 @@ console.log(
2930
JSON.stringify(StringMetricType),
3031
JSON.stringify(TimespanMetricType),
3132
JSON.stringify(UUIDMetricType),
33+
JSON.stringify(URLMetricType),
3234
JSON.stringify(PingEncryptionPlugin),
3335
);

docs/adding_a_new_metric_type.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,9 @@ async function testGetValue(ping: string = this.sendInPings[0]): Promise<string
169169

170170
> **Note**: All testing functions must start with the prefix `test`.
171171
172+
The `testGetNumRecordedErrors` function does not need to be implemeted individually per metric
173+
type as it is already implemented on the `MetricType` super class.
174+
172175
## Testing
173176

174177
Tests for metric type implementations live under the `glean/tests/unit/core/metrics/types` folder. Create a new

0 commit comments

Comments
 (0)