[No Bug] Fix gzipped ping upload for Node.

This additionally adds the related test coverage.

Author: Dexterp37

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 * [#1271](https://github.com/mozilla/glean.js/pull/1271): BUGFIX: Fix pings validation function when scanning pings database on initialize.
   * This bug was preventing pings that contained custom headers from being successfully validated and enqueued on initialize.
+* [#](): BUGFIX: Fix uploading gzip-compressed pings in Node.
 
 # v1.0.0 (2022-03-17)
 

glean/src/platform/node/uploader.ts

@@ -5,6 +5,7 @@
 import https from "https";
 import http from "http";
 
+import { isString } from "../../core/utils.js";
 import log, { LoggingLevel } from "../../core/log.js";
 import Uploader, {
   UploadResult,
@@ -55,7 +56,7 @@ class NodeUploader extends Uploader {
       });
 
       // Finish sending the request.
-      request.end(body);
+      request.end(isString(body) ? body : Buffer.from(body.buffer));
     });
   }
 }

glean/tests/unit/platform/node/uploader.spec.ts

@@ -17,14 +17,18 @@ describe("Uploader/Node", function () {
 
   it("returns the correct status for successful requests", async function () {
     for (const status of [200, 400, 500]) {
-      nock(MOCK_ENDPOINT).post(/./i).reply(status);
-
-      const response = NodeUploader.post(MOCK_ENDPOINT, "");
-      const expectedResponse = new UploadResult(UploadResultStatus.Success, status);
-      assert.deepStrictEqual(
-        await response,
-        expectedResponse
-      );
+      // We support both plain text and binary payloads (for gzipped content)
+      // so test them both.
+      for (const body of ["", new Uint8Array()]) {
+        nock(MOCK_ENDPOINT).post(/./i).reply(status);
+
+        const response = NodeUploader.post(MOCK_ENDPOINT, body);
+        const expectedResponse = new UploadResult(UploadResultStatus.Success, status);
+        assert.deepStrictEqual(
+          await response,
+          expectedResponse
+        );
+      }
     }
   });