Skip to content

Commit 00132b7

Browse files
brizentalbadboy
andauthored
Apply suggestions from code review
Co-authored-by: Jan-Erik Rediger <badboy@archlinux.us>
1 parent 78f996a commit 00132b7

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

glean/src/core/config.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ import { Context } from "./context.js";
1111

1212
const LOG_TAG = "core.Config";
1313

14-
// The default maximum amount of events Glean will store before submitting the events ping.
15-
// If the maximum is hit, the events ping is sent immediatelly.
14+
// The default maximum number of events Glean will store before submitting the events ping.
15+
// If the maximum is hit, the events ping is sent immediately.
1616
const DEFAULT_MAX_EVENTS = 500;
1717

1818
/**
@@ -39,7 +39,7 @@ export interface ConfigurationInterface {
3939
readonly appDisplayVersion?: string,
4040
// The server pings are sent to.
4141
readonly serverEndpoint?: string,
42-
// The build date, provided by glean_parser
42+
// The maximum number of events to store before submitting the events ping.
4343
readonly maxEvents?: number,
4444
// Optional list of plugins to include in current Glean instance.
4545
plugins?: Plugin[],

glean/src/core/metrics/events_database/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ function createDateObject(str?: ExtraValues): Date {
4949
*
5050
* @param sendInPings The list of pings this metric is sent in.
5151
* Note: The 'events' ping should not contain glean.restarted events,
52-
* so this ping will be filtered out from the the 'sendInPings' array.
52+
* so this ping will be filtered out from the 'sendInPings' array.
5353
* @returns A metric type instance.
5454
*/
5555
function getExecutionCounterMetric(sendInPings: string[]): CounterMetricType {
@@ -66,7 +66,7 @@ function getExecutionCounterMetric(sendInPings: string[]): CounterMetricType {
6666
*
6767
* @param sendInPings The list of pings this metric is sent in.
6868
* Note: The 'events' ping should not contain glean.restarted events,
69-
* so this ping will be filtered out from the the 'sendInPings' array.
69+
* so this ping will be filtered out from the 'sendInPings' array.
7070
* @returns A metric type instance.
7171
*/
7272
export function getGleanRestartedEventMetric(sendInPings: string[]): EventMetricType {

glean/src/core/upload/manager.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ export interface QueuedPing extends PingInternalRepresentation {
3535
class PingUploadManager implements PingsDatabaseObserver {
3636
// A FIFO queue storing a `QueuedPing` for each pending ping.
3737
private queue: QueuedPing[];
38-
// A set of the idenfitifers of pings being processed
38+
// A set of the identifiers of pings being processed
3939
// i.e. pings that were removed from the queue by calling `getUploadTask`,
4040
// but have not yet been deleted from the database / re-enqueued by calling `processPingUploadResponse`.
4141
private processing: Set<string>;

0 commit comments

Comments
 (0)