Fixes issue #2334 Pass an encoded hex email to DEL /emails #2336
Conversation
ghost
assigned 
|
r? @vbudhram |
There was a problem hiding this comment.
@deeptibaghel This LGTM, you just have to run npm shrink to get the latest version of mozilla/fxa-auth-db-mysql@cc6e08b. This will get all the tests passing.
lib/db.js
Outdated
| @@ -431,7 +431,7 @@ module.exports = ( | |||
|
|
|||
| DB.prototype.setPrimaryEmail = function (uid, email) { | |||
| log.trace({op: 'DB.accountFromEmail', email: email}) | |||
| return this.pool.post('/email/' + Buffer(email, 'utf8').toString('hex') + '/account/' + uid) | |||
| return this.pool.post('/email/' + Buffer.from(email, 'utf8').toString('hex') + '/account/' + uid) | |||
There was a problem hiding this comment.
You should be able to use hexEncode helper here.
|
@deeptibaghel , hey, make sure to change this SHA in here https://github.com/mozilla/fxa-auth-server/blob/master/npm-shrinkwrap.json#L343 to then tests should pass |
|
@vladikoff , i changed it but then the tests keep waiting forever :( , also the npm-shrinkwrap.json files shows as conflict , which is not clear to me. |
Might have to |
Fixes issue #2334 Pass an encoded hex email to DEL /emails