fix(pool): Reject with an Error instance for HTTP errors.

mozilla · Dec 16, 2016 · 60c15c8 · 60c15c8
1 parent 1d1fa41
commit 60c15c8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/lib/pool.js b/lib/pool.js
@@ -54,7 +54,12 @@ Pool.prototype.request = function (method, path, data) {
     }
 
     if (res.statusCode < 200 || res.statusCode >= 300) {
-      var error = parsedBody || new Error(body)
+      var error = new Error()
+      if (! parsedBody) {
+        error.message = body
+      } else {
+        Object.assign(error, parsedBody)
+      }
       error.statusCode = res.statusCode
       return d.reject(error)
     }

diff --git a/test/local/pool_tests.js b/test/local/pool_tests.js
@@ -120,8 +120,7 @@ describe('Pool', () => {
         .then(function () {
           assert(false, 'request should have failed')
         }, function (error) {
-          assert.equal(error instanceof Error, false, 'error is not Error instance')
-          assert.equal(typeof error, 'object', 'error is object')
+          assert.equal(error instanceof Error, true, 'error is an Error instance')
           assert.equal(Object.keys(error).length, 2, 'error has two properties')
           assert.equal(error.statusCode, 418, 'error.statusCode is 418')
           assert.equal(error.foo, 'bar', 'other error data is correct')