Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

Commit

Permalink
chore(push): Add a link to nodejs ECDH issue in code comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
rfk committed May 29, 2017
1 parent 5825341 commit 0503479
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion lib/push.js
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,9 @@ module.exports = function (log, db, config) {
* Checks whether the given string is a valid public key for push.
* This is a little tricky because we need to work around a bug in nodejs
* where using an invalid ECDH key can cause a later (unrelated) attempt
* to generate an RSA signature to fail :-(
* to generate an RSA signature to fail:
*
* https://github.com/nodejs/node/pull/13275
*
* @param key
* The public key as a b64url string.
Expand Down

0 comments on commit 0503479

Please sign in to comment.