Skip to content

Commit 8d3828c

Browse files
author
Narciso Jaramillo
committed
JSLint cleanups, comment clarification
1 parent 3370117 commit 8d3828c

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

src/editor/CodeHintList.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -359,8 +359,7 @@ define(function (require, exports, module) {
359359

360360
// Let the event bubble.
361361
return false;
362-
}
363-
else if (keyCode === KeyEvent.DOM_VK_UP) {
362+
} else if (keyCode === KeyEvent.DOM_VK_UP) {
364363
_rotateSelection.call(this, -1);
365364
} else if (keyCode === KeyEvent.DOM_VK_DOWN) {
366365
_rotateSelection.call(this, 1);

test/spec/CodeHint-test.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -297,10 +297,15 @@ define(function (require, exports, module) {
297297
keyCode: KeyEvent.DOM_VK_ENTER,
298298
stopImmediatePropagation: function () { },
299299
stopPropagation: function () { },
300-
preventDefault: function () { }
300+
preventDefault: function () { }
301301
});
302302

303-
// verify list is now closed and text of document hasn't changed
303+
// Verify that after the keydown, the session is closed
304+
// (not just the hint popup). Because of #1381, we don't
305+
// actually have a way to close the session as soon as the
306+
// popup is dismissed by Bootstrap, so we do so on the next
307+
// keydown. Eventually, once that's fixed, we should be able
308+
// to move this expectNoHints() up after the click.
304309
expectNoHints();
305310
expect(editor.document.getText()).toEqual(text);
306311
});

0 commit comments

Comments
 (0)