Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark up Pocket pages with Fluent syntax #11519

Closed
21 tasks done
Tracked by #11403
stevejalim opened this issue Apr 20, 2022 · 4 comments
Closed
21 tasks done
Tracked by #11403

Mark up Pocket pages with Fluent syntax #11519

stevejalim opened this issue Apr 20, 2022 · 4 comments

Comments

@stevejalim
Copy link
Collaborator

stevejalim commented Apr 20, 2022

Description

The Pocket pages ported into bedrock only contain English text, inline in the HTML templates.

We need to change this to be marked up ready for translation with Fluent.


Success Criteria

@stevejalim stevejalim changed the title [Placeholder] Mark up Pocket pages with Fluent syntax Mark up Pocket pages with Fluent syntax Apr 20, 2022
@nathan-barrett
Copy link
Contributor

@stevejalim once that initial PR is merged I can start cranking on these other pages

@stevejalim stevejalim added Blocked and removed Blocked labels May 3, 2022
@stevejalim
Copy link
Collaborator Author

@nathan-barrett Unblocked, sir! 😄 Thanks!

@nathan-barrett
Copy link
Contributor

nathan-barrett commented May 17, 2022

Talked with Dan - looks like tos.html and privacy.html will not be using fluent (due to the legal nature of the text) nevermind, we'll be translating both of those pages

@stevejalim
Copy link
Collaborator Author

Nice one, everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants