Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isort support to Bedrock #10570

Closed
3 tasks
stevejalim opened this issue Oct 8, 2021 · 0 comments · Fixed by #10573 or #10578
Closed
3 tasks

Add isort support to Bedrock #10570

stevejalim opened this issue Oct 8, 2021 · 0 comments · Fixed by #10573 or #10578
Assignees
Labels
P3 Third level priority - Nice to have

Comments

@stevejalim
Copy link
Collaborator

Description

As part of improving our auto-formatting and linting checks, it makes sense to add isort support to complement black and prettier

This work will involve:

  • adding isort as a dev dependency
  • adding appropriate/sensible config
  • applying it to the entire codebase

Success Criteria

  • isort is available to run independently, ideally via a makefile command
  • isort is automatically run as part of pre-commit checks
  • The codebase passes CI once any auto-formatting by isort is complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Third level priority - Nice to have
Projects
None yet
2 participants