Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Store all decisions for a job #15151

Open
1 task
eviljeff opened this issue Nov 7, 2024 · 0 comments
Open
1 task

[Task]: Store all decisions for a job #15151

eviljeff opened this issue Nov 7, 2024 · 0 comments
Labels
repository:addons-server Issue relating to addons-server

Comments

@eviljeff
Copy link
Member

eviljeff commented Nov 7, 2024

Description

Currently we expect there to be at most one decision linked a job, so if another decision occurs from an override we overwrite the existing ContentDecision instance. Aside from losing information about the previous decision (which is retained in the activity log at least), we then can't tell from the model states if a decision was overridden - a problem because we need to know if we should send different email content.

The main thing that makes this a hard change to make is the one-to-one fk is on CinderJob, and for a many-to-one from ContentDecision to CinderJob it needs to be on ContentDecision - and that means a lot of tests need updating 😐

Acceptance Criteria

Milestones/checkpoints

Checks

  • If I have identified that the work is specific to a repository, I have removed "repository:addons-server" or "repository:addons-frontend"

┆Issue is synchronized with this Jira Task

@eviljeff eviljeff added needs:info repository:addons-server Issue relating to addons-server labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repository:addons-server Issue relating to addons-server
Projects
None yet
Development

No branches or pull requests

2 participants