Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

implprefix DeprecationWarning with pluggy 0.7.1 #90

Closed
edmorley opened this issue Jul 29, 2018 · 4 comments
Closed

implprefix DeprecationWarning with pluggy 0.7.1 #90

edmorley opened this issue Jul 29, 2018 · 4 comments

Comments

@edmorley
Copy link

Hi!

pluggy v0.7.1 has deprecated the implprefix argument:

Treeherder marks warnings as errors, which causes the following failures from PyPOM:

DeprecationWarning: Support for the `implprefix` arg is now deprecated and
will be removed in an upcoming release. Please use HookimplMarker.

(Full log: https://travis-ci.org/mozilla/treeherder/jobs/409417404#L901)

The usage within PyPOM is here:

self.pm = PluginManager('pypom', implprefix='pypom_')

We can temporarily ignore this DeprecationWarning via pytest's filterwarnings, however it would be good to fix upstream at some point.

@davehunt
Copy link
Member

davehunt commented Aug 1, 2018

@edmorley this should be fixed by #92 but I'm on PTO for a week from tomorrow so I'd rather not do a release when I'm not around to deal with any potential issues. Are you okay with waiting on this?

@edmorley
Copy link
Author

edmorley commented Aug 1, 2018

Yeah no rush at all (we've added a temporary filterwarnings entry for it); thanks for opening the PR :-)

@davehunt
Copy link
Member

Fixed in PyPOM v2.1.0 by #92

@edmorley
Copy link
Author

Many thanks :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants