Bug 1356569 - Remove addObserver's last parameter when it is false, r…

…=jaws.
mozilla-spidermonkey · Apr 14, 2017 · d88a5cf · d88a5cf
1 parent 5c95f7a
commit d88a5cf
Show file tree

Hide file tree

Showing 834 changed files with 1,459 additions and 1,478 deletions.
diff --git a/accessible/jsat/AccessFu.jsm b/accessible/jsat/AccessFu.jsm
@@ -135,8 +135,8 @@ this.AccessFu = { // jshint ignore:line
       ]);
     }
 
-    Services.obs.addObserver(this, 'remote-browser-shown', false);
-    Services.obs.addObserver(this, 'inprocess-browser-shown', false);
+    Services.obs.addObserver(this, 'remote-browser-shown');
+    Services.obs.addObserver(this, 'inprocess-browser-shown');
     Utils.win.addEventListener('TabOpen', this);
     Utils.win.addEventListener('TabClose', this);
     Utils.win.addEventListener('TabSelect', this);

diff --git a/accessible/jsat/EventManager.jsm b/accessible/jsat/EventManager.jsm
@@ -599,7 +599,7 @@ const AccessibilityEventObserver = {
     if (this.started || this.listenerCount === 0) {
       return;
     }
-    Services.obs.addObserver(this, 'accessible-event', false);
+    Services.obs.addObserver(this, 'accessible-event');
     this.started = true;
   },
 

diff --git a/accessible/tests/browser/e10s/events.js b/accessible/tests/browser/e10s/events.js
@@ -100,7 +100,7 @@ function waitForEvent(eventType, expectedIdOrAcc) {
         }
       }
     };
-    Services.obs.addObserver(eventObserver, 'accessible-event', false);
+    Services.obs.addObserver(eventObserver, 'accessible-event');
   });
 }
 

diff --git a/accessible/tests/browser/head.js b/accessible/tests/browser/head.js
@@ -47,7 +47,7 @@ function a11yInitOrShutdownPromise() {
       Services.obs.removeObserver(observe, 'a11y-init-or-shutdown');
       resolve(data);
     };
-    Services.obs.addObserver(observe, 'a11y-init-or-shutdown', false);
+    Services.obs.addObserver(observe, 'a11y-init-or-shutdown');
   });
 }
 
@@ -123,7 +123,7 @@ function waitForEvent(eventType, expectedId) {
         }
       }
     };
-    Services.obs.addObserver(eventObserver, 'accessible-event', false);
+    Services.obs.addObserver(eventObserver, 'accessible-event');
   });
 }
 

diff --git a/accessible/tests/mochitest/browser.js b/accessible/tests/mochitest/browser.js
@@ -149,5 +149,5 @@ function whenDelayedStartupFinished(aWindow, aCallback) {
       Services.obs.removeObserver(observer, aTopic);
       setTimeout(aCallback, 0);
     }
-  }, "browser-delayed-startup-finished", false);
+  }, "browser-delayed-startup-finished");
 }
diff --git a/accessible/tests/mochitest/events.js b/accessible/tests/mochitest/events.js
@@ -2120,7 +2120,7 @@ function listenA11yEvents(aStartToListen)
   if (aStartToListen) {
     // Add observer when adding the first applicant only.
     if (!(gA11yEventApplicantsCount++))
-      Services.obs.addObserver(gA11yEventObserver, "accessible-event", false);
+      Services.obs.addObserver(gA11yEventObserver, "accessible-event");
   } else {
     // Remove observer when there are no more applicants only.
     // '< 0' case should not happen, but just in case: removeObserver() will throw.

diff --git a/accessible/tests/mochitest/jsat/jsatcommon.js b/accessible/tests/mochitest/jsat/jsatcommon.js
@@ -70,7 +70,7 @@ var AccessFuTest = {
       isDeeply(data.details, aWaitForData, "Data is correct");
       aListener.apply(listener);
     };
-    Services.obs.addObserver(listener, 'accessibility-output', false);
+    Services.obs.addObserver(listener, 'accessibility-output');
     return listener;
   },
 

diff --git a/addon-sdk/source/lib/dev/frame-script.js b/addon-sdk/source/lib/dev/frame-script.js
@@ -111,10 +111,10 @@ const observer = {
   }
 };
 
-observerService.addObserver(observer, "content-document-interactive", false);
-observerService.addObserver(observer, "content-document-loaded", false);
-observerService.addObserver(observer, "chrome-document-interactive", false);
-observerService.addObserver(observer, "chrome-document-loaded", false);
+observerService.addObserver(observer, "content-document-interactive");
+observerService.addObserver(observer, "content-document-loaded");
+observerService.addObserver(observer, "chrome-document-interactive");
+observerService.addObserver(observer, "chrome-document-loaded");
 addEventListener("unload", observer, false);
 
 })(this);
diff --git a/addon-sdk/source/lib/sdk/context-menu/core.js b/addon-sdk/source/lib/sdk/context-menu/core.js
@@ -66,7 +66,7 @@ const ContextMenuExtension = Class({
     globalMessageManager.addMessageListener("sdk/context-menu/read", messageListener);
     globalMessageManager.addMessageListener("sdk/context-menu/readers?", messageListener);
 
-    preferencesService.addObserver(OVERFLOW_THRESH, this, false);
+    preferencesService.addObserver(OVERFLOW_THRESH, this);
   },
   observe(_, __, name) {
     if (name === OVERFLOW_THRESH) {

diff --git a/addon-sdk/source/lib/sdk/places/events.js b/addon-sdk/source/lib/sdk/places/events.js
@@ -129,10 +129,10 @@ historyObserver.onVisit = function(url, visitId, time, sessionId,
   }
   this.realOnVisit(url, visitId, time, sessionId, referringId, transitionType);
 };
-historyService.addObserver(historyObserver, false);
+historyService.addObserver(historyObserver);
 
 var bookmarkObserver = createObserverInstance(BOOKMARK_EVENTS, BOOKMARK_ARGS);
-bookmarkService.addObserver(bookmarkObserver, false);
+bookmarkService.addObserver(bookmarkObserver);
 
 when(() => {
   historyService.removeObserver(historyObserver);

diff --git a/addon-sdk/source/lib/sdk/preferences/event-target.js b/addon-sdk/source/lib/sdk/preferences/event-target.js
@@ -34,7 +34,7 @@ const PrefsTarget = Class({
 
     // start listening to preference changes
     let observer = prefTargetNS(this).observer = onChange.bind(this);
-    branch.addObserver('', observer, false);
+    branch.addObserver('', observer);
 
     // Make sure to destroy this on unload
     unload(destroy.bind(this));

diff --git a/addon-sdk/source/modules/system/Startup.js b/addon-sdk/source/modules/system/Startup.js
@@ -52,5 +52,5 @@ else {
     Services.tm.dispatchToMainThread(() => gOnceInitializedDeferred.resolve());
   }
 
-  Services.obs.addObserver(listener, appStartup, false);
+  Services.obs.addObserver(listener, appStartup);
 }
diff --git a/addon-sdk/source/python-lib/cuddlefish/mobile-utils/bootstrap.js b/addon-sdk/source/python-lib/cuddlefish/mobile-utils/bootstrap.js
@@ -37,7 +37,7 @@ function startup(data, reason) {
         dump("MU: APPLICATION-QUIT\n");
       }
     };
-    Services.obs.addObserver(QuitObserver, "quit-application", false);
+    Services.obs.addObserver(QuitObserver, "quit-application");
     log("MU: ready to watch firefox exit.");
   } catch(e) {
     log("MU: unable to register quit-application observer: " + e);

diff --git a/addon-sdk/source/test/leak/leak-utils.js b/addon-sdk/source/test/leak/leak-utils.js
@@ -53,7 +53,7 @@ exports.asyncWindowLeakTest = function*(assert, asyncTestFunc) {
       weakWindows.push(Cu.getWeakReference(supportsWeak));
     }
   }
-  Services.obs.addObserver(windowObserver, "domwindowopened", false);
+  Services.obs.addObserver(windowObserver, "domwindowopened");
 
   // Execute the body of the test.
   let testLoader = yield asyncTestFunc(assert);

diff --git a/addon-sdk/source/test/test-system-events.js b/addon-sdk/source/test/test-system-events.js
@@ -233,7 +233,7 @@ exports["test emit to nsIObserverService observers"] = function(assert) {
     }
   };
 
-  nsIObserverService.addObserver(nsIObserver, topic, false);
+  nsIObserverService.addObserver(nsIObserver, topic);
 
   events.emit(topic, { subject: uri, data: "some data" });
 
@@ -258,7 +258,7 @@ exports["test emit to nsIObserverService observers"] = function(assert) {
 
   assert.equal(timesCalled, 2, "removed observers no longer invoked");
 
-  nsIObserverService.addObserver(nsIObserver, "*", false);
+  nsIObserverService.addObserver(nsIObserver, "*");
 
   events.emit(topic, { data: "data again" });
 

diff --git a/b2g/chrome/content/screen.js b/b2g/chrome/content/screen.js
@@ -224,7 +224,7 @@ function onStart() {
     defaultOrientation = screenOrientation;
 
     queueResize();
-  }, 'simulator-adjust-window-size', false);
+  }, 'simulator-adjust-window-size');
 
   // Queue resize request in order to prevent race and slowdowns
   // by requesting resize multiple times per loop

diff --git a/b2g/chrome/content/shell.js b/b2g/chrome/content/shell.js
@@ -222,7 +222,7 @@ var shell = {
 
         Services.obs.removeObserver(observer, topic);
       }
-    }, "network-connection-state-changed", false);
+    }, "network-connection-state-changed");
   },
 
   get homeURL() {
@@ -758,22 +758,22 @@ var shell = {
 Services.obs.addObserver(function onFullscreenOriginChange(subject, topic, data) {
   shell.sendChromeEvent({ type: "fullscreenoriginchange",
                           fullscreenorigin: data });
-}, "fullscreen-origin-change", false);
+}, "fullscreen-origin-change");
 
 Services.obs.addObserver(function onBluetoothVolumeChange(subject, topic, data) {
   shell.sendChromeEvent({
     type: "bluetooth-volumeset",
     value: data
   });
-}, 'bluetooth-volume-change', false);
+}, 'bluetooth-volume-change');
 
 Services.obs.addObserver(function(subject, topic, data) {
   shell.sendCustomEvent('mozmemorypressure');
-}, 'memory-pressure', false);
+}, 'memory-pressure');
 
 Services.obs.addObserver(function(subject, topic, data) {
   shell.notifyEventListenerReady();
-}, 'system-message-listener-ready', false);
+}, 'system-message-listener-ready');
 
 var permissionMap = new Map([
   ['unknown', Services.perms.UNKNOWN_ACTION],
@@ -903,14 +903,14 @@ window.addEventListener('ContentStart', function ss_onContentStart() {
         shell.reportCrash(false, props.getProperty("dumpID"));
       }
     },
-    "ipc:content-shutdown", false);
+    "ipc:content-shutdown");
 })();
 
 var CaptivePortalLoginHelper = {
   init: function init() {
-    Services.obs.addObserver(this, 'captive-portal-login', false);
-    Services.obs.addObserver(this, 'captive-portal-login-abort', false);
-    Services.obs.addObserver(this, 'captive-portal-login-success', false);
+    Services.obs.addObserver(this, 'captive-portal-login');
+    Services.obs.addObserver(this, 'captive-portal-login-abort');
+    Services.obs.addObserver(this, 'captive-portal-login-success');
   },
   handleEvent: function handleEvent(detail) {
     Services.captivePortalDetector.cancelLogin(detail.id);
@@ -997,7 +997,7 @@ window.addEventListener('ContentStart', function update_onContentStart() {
         prompt: promptWarning
       });
     }
-}, "geolocation-device-events", false);
+}, "geolocation-device-events");
 })();
 
 (function headphonesStatusTracker() {
@@ -1006,7 +1006,7 @@ window.addEventListener('ContentStart', function update_onContentStart() {
       type: 'headphones-status-changed',
       state: aData
     });
-}, "headphones-status-changed", false);
+}, "headphones-status-changed");
 })();
 
 (function audioChannelChangedTracker() {
@@ -1015,7 +1015,7 @@ window.addEventListener('ContentStart', function update_onContentStart() {
       type: 'audio-channel-changed',
       channel: aData
     });
-}, "audio-channel-changed", false);
+}, "audio-channel-changed");
 })();
 
 (function defaultVolumeChannelChangedTracker() {
@@ -1024,7 +1024,7 @@ window.addEventListener('ContentStart', function update_onContentStart() {
       type: 'default-volume-channel-changed',
       channel: aData
     });
-}, "default-volume-channel-changed", false);
+}, "default-volume-channel-changed");
 })();
 
 (function visibleAudioChannelChangedTracker() {
@@ -1034,7 +1034,7 @@ window.addEventListener('ContentStart', function update_onContentStart() {
       channel: aData
     });
     shell.visibleNormalAudioActive = (aData == 'normal');
-}, "visible-audio-channel-changed", false);
+}, "visible-audio-channel-changed");
 })();
 
 (function recordingStatusTracker() {
@@ -1133,16 +1133,16 @@ window.addEventListener('ContentStart', function update_onContentStart() {
       delete gRecordingActiveProcesses[processId];
     }
   };
-  Services.obs.addObserver(recordingHandler, 'recording-device-events', false);
-  Services.obs.addObserver(recordingHandler, 'recording-device-ipc-events', false);
+  Services.obs.addObserver(recordingHandler, 'recording-device-events');
+  Services.obs.addObserver(recordingHandler, 'recording-device-ipc-events');
 
   Services.obs.addObserver(function(aSubject, aTopic, aData) {
     // send additional recording events if content process is being killed
     let processId = aSubject.QueryInterface(Ci.nsIPropertyBag2).get('childID');
     if (gRecordingActiveProcesses.hasOwnProperty(processId)) {
       Services.obs.notifyObservers(aSubject, 'recording-device-ipc-events', 'content-shutdown');
     }
-  }, 'ipc:content-shutdown', false);
+  }, 'ipc:content-shutdown');
 })();
 
 (function volumeStateTracker() {
@@ -1151,7 +1151,7 @@ window.addEventListener('ContentStart', function update_onContentStart() {
       type: 'volume-state-changed',
       active: (aData == 'Shared')
     });
-}, 'volume-state-changed', false);
+}, 'volume-state-changed');
 })();
 
 if (isGonk) {
@@ -1229,12 +1229,12 @@ Services.obs.addObserver(function resetProfile(subject, topic, data) {
       }
     }
   },
-  'profile-before-change-telemetry', false);
+  'profile-before-change-telemetry');
 
   let appStartup = Cc['@mozilla.org/toolkit/app-startup;1']
                      .getService(Ci.nsIAppStartup);
   appStartup.quit(Ci.nsIAppStartup.eForceQuit);
-}, 'b2g-reset-profile', false);
+}, 'b2g-reset-profile');
 
 var showInstallScreen;
 

diff --git a/b2g/chrome/content/test/mochitest/RecordingStatusChromeScript.js b/b2g/chrome/content/test/mochitest/RecordingStatusChromeScript.js
@@ -26,8 +26,8 @@ addMessageListener('init-chrome-event', function(message) {
     }
   }, true);
 
-  Services.obs.addObserver(peekChildId, 'recording-device-events', false);
-  Services.obs.addObserver(peekChildId, 'recording-device-ipc-events', false);
+  Services.obs.addObserver(peekChildId, 'recording-device-events');
+  Services.obs.addObserver(peekChildId, 'recording-device-ipc-events');
 });
 
 addMessageListener('fake-content-shutdown', function(message) {

diff --git a/b2g/components/AlertsHelper.jsm b/b2g/components/AlertsHelper.jsm
@@ -62,7 +62,7 @@ var AlertsHelper = {
   _listeners: {},
 
   init: function() {
-    Services.obs.addObserver(this, "xpcom-shutdown", false);
+    Services.obs.addObserver(this, "xpcom-shutdown");
     for (let message of kMessages) {
       ppmm.addMessageListener(message, this);
     }

diff --git a/b2g/components/AlertsService.js b/b2g/components/AlertsService.js
@@ -44,7 +44,7 @@ const kTopicAlertFinished      = "alertfinished";
 const kTopicAlertClickCallback = "alertclickcallback";
 
 function AlertsService() {
-  Services.obs.addObserver(this, "xpcom-shutdown", false);
+  Services.obs.addObserver(this, "xpcom-shutdown");
 }
 
 AlertsService.prototype = {

diff --git a/b2g/components/ErrorPage.jsm b/b2g/components/ErrorPage.jsm
@@ -170,8 +170,8 @@ var ErrorPage = {
   },
 
   init: function errorPageInit() {
-    Services.obs.addObserver(this, 'inprocess-browser-shown', false);
-    Services.obs.addObserver(this, 'remote-browser-shown', false);
+    Services.obs.addObserver(this, 'inprocess-browser-shown');
+    Services.obs.addObserver(this, 'remote-browser-shown');
   },
 
   observe: function errorPageObserve(aSubject, aTopic, aData) {

diff --git a/b2g/components/Frames.jsm b/b2g/components/Frames.jsm
@@ -20,9 +20,9 @@ const Observer = {
   _frames: new Map(),
 
   start: function () {
-    Services.obs.addObserver(this, 'remote-browser-shown', false);
-    Services.obs.addObserver(this, 'inprocess-browser-shown', false);
-    Services.obs.addObserver(this, 'message-manager-close', false);
+    Services.obs.addObserver(this, 'remote-browser-shown');
+    Services.obs.addObserver(this, 'inprocess-browser-shown');
+    Services.obs.addObserver(this, 'message-manager-close');
 
     SystemAppProxy.getFrames().forEach(frame => {
       let mm = frame.QueryInterface(Ci.nsIFrameLoaderOwner).frameLoader.messageManager;

diff --git a/b2g/components/FxAccountsMgmtService.jsm b/b2g/components/FxAccountsMgmtService.jsm
@@ -48,9 +48,9 @@ this.FxAccountsMgmtService = {
   },
 
   init: function() {
-    Services.obs.addObserver(this, ONLOGIN_NOTIFICATION, false);
-    Services.obs.addObserver(this, ONVERIFIED_NOTIFICATION, false);
-    Services.obs.addObserver(this, ONLOGOUT_NOTIFICATION, false);
+    Services.obs.addObserver(this, ONLOGIN_NOTIFICATION);
+    Services.obs.addObserver(this, ONVERIFIED_NOTIFICATION);
+    Services.obs.addObserver(this, ONLOGOUT_NOTIFICATION);
     SystemAppProxy.addEventListener("mozFxAccountsContentEvent",
                                     FxAccountsMgmtService);
   },

diff --git a/b2g/components/LogShake.jsm b/b2g/components/LogShake.jsm
@@ -155,7 +155,7 @@ var LogShake = {
     SystemAppProxy.addEventListener(CAPTURE_LOGS_CONTENT_EVENT, this);
     SystemAppProxy.addEventListener(SCREEN_CHANGE_EVENT, this);
 
-    Services.obs.addObserver(this, "xpcom-shutdown", false);
+    Services.obs.addObserver(this, "xpcom-shutdown");
   },
 
   /**

diff --git a/b2g/components/ProcessGlobal.js b/b2g/components/ProcessGlobal.js
@@ -160,7 +160,7 @@ ProcessGlobal.prototype = {
   observe: function pg_observe(subject, topic, data) {
     switch (topic) {
     case 'app-startup': {
-      Services.obs.addObserver(this, 'console-api-log-event', false);
+      Services.obs.addObserver(this, 'console-api-log-event');
       let inParent = Cc["@mozilla.org/xre/app-info;1"]
                        .getService(Ci.nsIXULRuntime)
                        .processType == Ci.nsIXULRuntime.PROCESS_TYPE_DEFAULT;
-Original file line number
+Diff line change
@@ Expand Up / @@ -100,7 +100,7 @@ function waitForEvent(eventType, expectedIdOrAcc) { @@
             }
           }
         };
-        Services.obs.addObserver(eventObserver, 'accessible-event', false);
+        Services.obs.addObserver(eventObserver, 'accessible-event');
       });
     }
@@ Expand Down @@