Skip to content
This repository has been archived by the owner on Aug 4, 2022. It is now read-only.

Commit

Permalink
Bug 1587206 - [lint.flake8] Enable F633 across the tree, r=sylvestre
Browse files Browse the repository at this point in the history
This prevents '>>' with print statements. Since this syntax is still valid in
Python 2, I exluded dirs that contain this error rather than fix them.

Depends on D48609

Differential Revision: https://phabricator.services.mozilla.com/D48610
  • Loading branch information
ahal committed Oct 10, 2019
1 parent 6ebda87 commit a6f91df
Showing 1 changed file with 9 additions and 6 deletions.
15 changes: 9 additions & 6 deletions .flake8
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ exclude =
# - http://pep8.readthedocs.io/en/latest/intro.html#configuration
ignore =
# These should be triaged and either fixed or moved to the list below.
F633, F811, E117, W504, W605, W606,
F811, E117, W504, W605, W606,
# These are intentionally disabled (not necessarily for good reason).
# F723: syntax error in type comment
# text contains quotes which breaks our custom JSON formatter
Expand All @@ -109,9 +109,11 @@ per-file-ignores =

# These paths contain Python-2 only syntax which cause errors since flake8
# is run with Python 3.
build/**: F821
config/**: F821
js/**: F821
browser/app/macversion.py: F633
build/**: F633, F821
config/**: F633, F821
ipc/pull-chromium.py: F633
js/**: F633, F821
memory/**: F821
mozglue/**: F821
python/mozbuild/**: F821
Expand All @@ -123,7 +125,8 @@ per-file-ignores =
toolkit/components/telemetry/**: F821
tools/tryselect/**: F821
testing/firefox-ui/tests/functional/safebrowsing/test_initial_download.py: F821
testing/gtest/rungtests.py: F633
testing/marionette/**: F821
testing/mochitest/**: F821
testing/xpcshell/**: F821
xpcom/idl-parser/xpidl/**: F821
testing/xpcshell/**: F633, F821
xpcom/idl-parser/xpidl/**: F633, F821

0 comments on commit a6f91df

Please sign in to comment.