Backed out changeset 081d8311be59 (bug 1479503) for build bustage - j…

…ava not found. CLOSED TREE

.flake8

@@ -22,4 +22,3 @@ exclude =
     testing/mochitest/pywebsocket,
     tools/lint/test/files,
     build/build-infer/build-infer.py,
-    tools/infer/test/*.configure,

.hgignore

@@ -74,7 +74,6 @@ _OPT\.OBJ/
 
 # Gradle cache.
 ^.gradle/
-^tools/infer/test/.gradle/
 
 # Local Gradle configuration properties.
 ^local.properties$

moz.configure

@@ -567,16 +567,6 @@ set_config('MAKENSISU_FLAGS', nsis_flags)
 
 check_prog('7Z', ('7z', '7za'), allow_missing=True, when=target_is_windows)
 
-@depends(host)
-def include_infer_autotest(host):
-    # Do not include autotest configuration on Windows or macos
-    # because infer is not available there
-    if host.os in ['WINNT', 'OSX']:
-        return None
-    return 'tools/infer/test/moz.configure'
-
-include(include_infer_autotest)
-
 # Fallthrough to autoconf-based configure
 include('build/moz.configure/old.configure')
 

taskcluster/ci/docker-image/kind.yml

@@ -86,9 +86,9 @@ jobs:
   fetch:
     symbol: I(fetch)
     parent: debian9-base
-  static-analysis-build:
-    symbol: I(static-analysis-build)
-    parent: android-build
+  infer-build:
+    symbol: I(infer)
+    parent: debian9-base
   mingw32-build:
     symbol: I(mingw)
     parent: debian9-base

taskcluster/ci/static-analysis-autotest/kind.yml

@@ -36,10 +36,6 @@ jobs:
         description: "Linux64 Debug Static Analysis Autotest"
         index:
             job-name: linux64-st-autotest-debug
-        worker:
-            docker-image: {in-tree: static-analysis-build}
-            env:
-                PERFHERDER_EXTRA_OPTIONS: static-analysis-autotest
         treeherder:
             platform: linux64/debug
         worker-type: aws-provisioner-v1/gecko-t-linux-large

taskcluster/ci/toolchain/linux.yml

@@ -158,7 +158,7 @@ linux64-infer:
         tier: 1
     worker-type: aws-provisioner-v1/gecko-{level}-b-linux
     worker:
-        docker-image: {in-tree: static-analysis-build}
+        docker-image: {in-tree: infer-build}
         max-run-time: 3600
     run:
         using: toolchain-script

taskcluster/docker/infer-build/Dockerfile

@@ -0,0 +1,30 @@
+# %ARG DOCKER_IMAGE_PARENT
+FROM $DOCKER_IMAGE_PARENT
+MAINTAINER Robert Bartlensky <rbartlensky@mozilla.com>
+
+VOLUME /builds/worker/checkouts
+VOLUME /builds/worker/workspace
+VOLUME /builds/worker/tooltool-cache
+
+ENV XZ_OPT=-T0
+
+RUN apt-get update && \
+    apt-get install \
+      autoconf \
+      bison \
+      bzip2 \
+      flex \
+      curl \
+      git \
+      opam \
+      libsqlite3-dev \
+      autoconf \
+      automake \
+      cmake \
+      libc6-dev \
+      openjdk-8-jdk-headless \
+      pkg-config \
+      patch \
+      tar \
+      unzip \
+      zlib1g-dev

testing/mozharness/mozharness/base/script.py

@@ -1,3 +1,4 @@
+
 #!/usr/bin/env python
 # ***** BEGIN LICENSE BLOCK *****
 # This Source Code Form is subject to the terms of the Mozilla Public

testing/mozharness/mozharness/mozilla/building/buildbase.py

@@ -1226,15 +1226,13 @@ def build(self):
     def static_analysis_autotest(self):
         """Run mach static-analysis autotest, in order to make sure we dont regress"""
         self.preflight_build()
-        self._run_mach_command_in_build_env(['configure'])
-        self._run_mach_command_in_build_env(['static-analysis', 'autotest',
-                                             '--intree-tool'],
-                                            use_subprocess=True)
+        self._run_mach_command_in_build_env(['static-analysis', 'autotest', '--intree-tool'])
 
-    def _run_mach_command_in_build_env(self, args, use_subprocess=False):
+    def _run_mach_command_in_build_env(self, args):
         """Run a mach command in a build context."""
         env = self.query_build_env()
         env.update(self.query_mach_build_env())
+
         dirs = self.query_abs_dirs()
 
         if 'MOZILLABUILD' in os.environ:
@@ -1247,21 +1245,13 @@ def _run_mach_command_in_build_env(self, args, use_subprocess=False):
         else:
             mach = [sys.executable, 'mach']
 
-        # XXX See bug 1483883
-        # Work around an interaction between Gradle and mozharness
-        # Not using `subprocess` causes gradle to hang
-        if use_subprocess:
-            import subprocess
-            return_code = subprocess.call(mach + ['--log-no-times'] + args,
-                                          env=env, cwd=dirs['abs_src_dir'])
-        else:
-            return_code = self.run_command(
-                command=mach + ['--log-no-times'] + args,
-                cwd=dirs['abs_src_dir'],
-                env=env,
-                output_timeout=self.config.get('max_build_output_timeout',
-                                               60 * 40)
-            )
+        return_code = self.run_command(
+            command=mach + ['--log-no-times'] + args,
+            cwd=dirs['abs_src_dir'],
+            env=env,
+            output_timeout=self.config.get('max_build_output_timeout', 60 * 40)
+        )
+
         if return_code:
             self.return_code = self.worst_level(
                 EXIT_STATUS_DICT[TBPL_FAILURE], self.return_code,

tools/infer/config.yaml

@@ -5,27 +5,19 @@ target: obj-x86_64-pc-linux-gnu
 platforms:
   - linux64
 infer_checkers:
-  # no issues were ever trigger by this
   - name: check-nullable
-    publish: !!bool no
-  - name: biabduction
     publish: !!bool yes
-  # very very noisy
-  # it could be useful, but it won't be part of the default enabled checkers
   - name: eradicate
     publish: !!bool no
-  # hard to use, not useful
   - name: quandary
-    publish: !!bool no
+    publish: !!bool yes
   - name: starvation
     publish: !!bool yes
-  # experimental
   - name: litho
-    publish: !!bool no
+    publish: !!bool yes
   - name: racerd
     publish: !!bool yes
-  # I think this is only for c++, can't trigger these errors in Java
   - name: liveness
-    publish: !!bool no
+    publish: !!bool yes
 # Third party files from mozilla-central
 third_party: tools/rewriting/ThirdPartyPaths.txt