diff --git a/Makefile.in b/Makefile.in index fba5cd3b3881..affe9d959f46 100644 --- a/Makefile.in +++ b/Makefile.in @@ -44,23 +44,23 @@ endif endif CLOBBER: $(topsrcdir)/CLOBBER - @echo "STOP! The CLOBBER file has changed." - @echo "Please run the build through a sanctioned build wrapper, such as" - @echo "'mach build' or client.mk." + @echo 'STOP! The CLOBBER file has changed.' + @echo 'Please run the build through a sanctioned build wrapper, such as' + @echo '"mach build" or client.mk.' @exit 1 $(topsrcdir)/configure: $(topsrcdir)/configure.in - @echo "STOP! configure.in has changed, and your configure is out of date." - @echo "Please rerun autoconf and re-configure your build directory." - @echo "To ignore this message, touch 'configure' in the source directory," - @echo "but your build might not succeed." + @echo 'STOP! configure.in has changed, and your configure is out of date.' + @echo 'Please rerun autoconf and re-configure your build directory.' + @echo 'To ignore this message, touch "configure" in the source directory,' + @echo 'but your build might not succeed.' @exit 1 config.status: $(topsrcdir)/configure - @echo "STOP! configure has changed and needs to be run in this build directory." - @echo "Please rerun configure." - @echo "To ignore this message, touch 'config.status' in the build directory," - @echo "but your build might not succeed." + @echo 'STOP! configure has changed and needs to be run in this build directory.' + @echo 'Please rerun configure.' + @echo 'To ignore this message, touch "config.status" in the build directory,' + @echo 'but your build might not succeed.' @exit 1 # Regenerate the build backend if it is out of date. We only have this rule in @@ -71,7 +71,7 @@ config.status: $(topsrcdir)/configure # builds. This cleanly avoids most of the pain. backend.RecursiveMakeBackend: - @echo "Build configuration changed. Regenerating backend." + @echo 'Build configuration changed. Regenerating backend.' $(PYTHON) config.status Makefile: backend.RecursiveMakeBackend @@ -165,7 +165,7 @@ endif ifeq ($(OS_ARCH),Darwin) # need to pass arch flags for universal builds ifdef UNIVERSAL_BINARY -MAKE_SYM_STORE_ARGS := -c -a "i386 x86_64" --vcs-info +MAKE_SYM_STORE_ARGS := -c -a 'i386 x86_64' --vcs-info MAKE_SYM_STORE_PATH := $(DIST)/universal else MAKE_SYM_STORE_ARGS := -c -a $(OS_TEST) --vcs-info @@ -194,9 +194,9 @@ buildsymbols: ifdef MOZ_CRASHREPORTER echo building symbol store $(RM) -r $(DIST)/crashreporter-symbols - $(RM) "$(DIST)/$(SYMBOL_ARCHIVE_BASENAME).zip" + $(RM) '$(DIST)/$(SYMBOL_ARCHIVE_BASENAME).zip' $(NSINSTALL) -D $(DIST)/crashreporter-symbols - OBJCOPY="$(OBJCOPY)" \ + OBJCOPY='$(OBJCOPY)' \ $(PYTHON) $(topsrcdir)/toolkit/crashreporter/tools/symbolstore.py \ $(MAKE_SYM_STORE_ARGS) \ $(foreach dir,$(SYM_STORE_SOURCE_DIRS),-s $(dir)) \ @@ -207,17 +207,17 @@ ifdef MOZ_CRASHREPORTER echo packing symbols $(NSINSTALL) -D $(DIST)/$(PKG_PATH) cd $(DIST)/crashreporter-symbols && \ - zip -r9D "../$(PKG_PATH)$(SYMBOL_FULL_ARCHIVE_BASENAME).zip" . -x "*test*" -x "*Test*" + zip -r9D '../$(PKG_PATH)$(SYMBOL_FULL_ARCHIVE_BASENAME).zip' . -x '*test*' -x '*Test*' cd $(DIST)/crashreporter-symbols && \ - grep "sym" $(SYMBOL_INDEX_NAME) > $(SYMBOL_INDEX_NAME).tmp && \ + grep 'sym' $(SYMBOL_INDEX_NAME) > $(SYMBOL_INDEX_NAME).tmp && \ mv $(SYMBOL_INDEX_NAME).tmp $(SYMBOL_INDEX_NAME) cd $(DIST)/crashreporter-symbols && \ - zip -r9D "../$(PKG_PATH)$(SYMBOL_ARCHIVE_BASENAME).zip" . -i "*.sym" -i "*.txt" -x "*test*" -x "*Test*" + zip -r9D '../$(PKG_PATH)$(SYMBOL_ARCHIVE_BASENAME).zip' . -i '*.sym' -i '*.txt' -x '*test*' -x '*Test*' endif # MOZ_CRASHREPORTER uploadsymbols: ifdef MOZ_CRASHREPORTER - $(SHELL) $(topsrcdir)/toolkit/crashreporter/tools/upload_symbols.sh $(SYMBOL_INDEX_NAME) "$(DIST)/$(PKG_PATH)$(SYMBOL_FULL_ARCHIVE_BASENAME).zip" + $(SHELL) $(topsrcdir)/toolkit/crashreporter/tools/upload_symbols.sh $(SYMBOL_INDEX_NAME) '$(DIST)/$(PKG_PATH)$(SYMBOL_FULL_ARCHIVE_BASENAME).zip' endif # MOZ_SOURCE_STAMP is defined in package-name.mk with a deferred assignment. @@ -238,7 +238,7 @@ endif else maybe_clobber_profiledbuild: $(RM) $(DIST)/bin/*.pgc - find $(DIST)/$(MOZ_APP_NAME) -name "*.pgc" -exec mv {} $(DIST)/bin \; + find $(DIST)/$(MOZ_APP_NAME) -name '*.pgc' -exec mv {} $(DIST)/bin \; endif .PHONY: maybe_clobber_profiledbuild @@ -247,7 +247,7 @@ endif # break x86_64 builds and SELinux users. ifeq ($(OS_TARGET)_$(TARGET_XPCOM_ABI),Linux_x86-gcc3) scheck:: - @relcount=`find $(DIST)/bin -name "*.so" | xargs objdump -R | grep R_386_PC32 | wc -l` && if test $$relcount -gt 0; then echo "FAILED: R_386_PC32 relocations detected in a shared library. Did you use a system header without adding it to config/system-headers?"; exit 1; else echo "PASSED"; fi + @relcount=`find $(DIST)/bin -name '*.so' | xargs objdump -R | grep R_386_PC32 | wc -l` && if test $$relcount -gt 0; then echo 'FAILED: R_386_PC32 relocations detected in a shared library. Did you use a system header without adding it to config/system-headers?'; exit 1; else echo 'PASSED'; fi endif ifdef BUILD_JS diff --git a/b2g/app/Makefile.in b/b2g/app/Makefile.in index 40fdebae4c96..3433a394adb7 100644 --- a/b2g/app/Makefile.in +++ b/b2g/app/Makefile.in @@ -65,7 +65,7 @@ UA_UPDATE_FILE = ua-update.json $(UA_UPDATE_FILE): % : %.in # strip out comment lines, which are not valid in JSON - sed -e "/^ *\\/\\//d" -e "/^ *$$/d" $^ > $@ + sed -e '/^ *\/\//d' -e '/^ *$$/d' $^ > $@ UA_UPDATE_FILES = $(UA_UPDATE_FILE) UA_UPDATE_DEST = $(FINAL_TARGET) @@ -80,7 +80,7 @@ APP_ICON = b2g source_repo ?= $(call getSourceRepo,$(srcdir)/..) ifneq (,$(filter http%,$(source_repo))) - DEFINES += -DMOZ_SOURCE_REPO="$(source_repo)" + DEFINES += -DMOZ_SOURCE_REPO='$(source_repo)' endif ifeq ($(OS_ARCH),WINNT) @@ -118,10 +118,10 @@ libs-preqs = \ .PHONY: repackage tools repackage:: $(libs-preqs) - rsync -a --exclude "*.in" $(srcdir)/macbuild/Contents $(DIST)/$(APP_NAME).app --exclude English.lproj - rsync -a --exclude "*.in" $(srcdir)/macbuild/Contents/Resources/English.lproj/ $(DIST)/$(APP_NAME).app/Contents/Resources/$(AB).lproj - sed -e "s/%MOZ_APP_VERSION%/$(MOZ_APP_VERSION)/" -e "s/%MOZ_APP_NAME%/$(MOZ_APP_NAME)/" -e "s/%APP_VERSION%/$(APP_VERSION)/" -e "s/%APP_NAME%/$(APP_NAME)/" -e "s/%APP_BINARY%/$(APP_BINARY)/" $(srcdir)/macbuild/Contents/Info.plist.in > $(DIST)/$(APP_NAME).app/Contents/Info.plist - sed -e "s/%APP_VERSION%/$(APP_VERSION)/" -e "s/%APP_NAME%/$(APP_NAME)/" $(srcdir)/macbuild/Contents/Resources/English.lproj/InfoPlist.strings.in | iconv -f UTF-8 -t UTF-16 > $(DIST)/$(APP_NAME).app/Contents/Resources/$(AB).lproj/InfoPlist.strings + rsync -a --exclude '*.in' $(srcdir)/macbuild/Contents $(DIST)/$(APP_NAME).app --exclude English.lproj + rsync -a --exclude '*.in' $(srcdir)/macbuild/Contents/Resources/English.lproj/ $(DIST)/$(APP_NAME).app/Contents/Resources/$(AB).lproj + sed -e 's/%MOZ_APP_VERSION%/$(MOZ_APP_VERSION)/' -e 's/%MOZ_APP_NAME%/$(MOZ_APP_NAME)/' -e 's/%APP_VERSION%/$(APP_VERSION)/' -e 's/%APP_NAME%/$(APP_NAME)/' -e 's/%APP_BINARY%/$(APP_BINARY)/' $(srcdir)/macbuild/Contents/Info.plist.in > $(DIST)/$(APP_NAME).app/Contents/Info.plist + sed -e 's/%APP_VERSION%/$(APP_VERSION)/' -e 's/%APP_NAME%/$(APP_NAME)/' $(srcdir)/macbuild/Contents/Resources/English.lproj/InfoPlist.strings.in | iconv -f UTF-8 -t UTF-16 > $(DIST)/$(APP_NAME).app/Contents/Resources/$(AB).lproj/InfoPlist.strings rsync -a $(DIST)/bin/ $(DIST)/$(APP_NAME).app/Contents/$(APPFILES) $(RM) $(DIST)/$(APP_NAME).app/Contents/$(APPFILES)/mangle $(DIST)/$(APP_NAME).app/Contents/$(APPFILES)/shlibsign ifdef LIBXUL_SDK @@ -132,7 +132,7 @@ else rsync -aL $(PROGRAM) $(DIST)/$(APP_NAME).app/Contents/MacOS endif cp -RL $(srcdir)/b2g.icns $(DIST)/$(APP_NAME).app/Contents/Resources/$(MOZ_APP_NAME).icns - printf "APPLMOZB" > $(DIST)/$(APP_NAME).app/Contents/PkgInfo + printf APPLMOZB > $(DIST)/$(APP_NAME).app/Contents/PkgInfo else # MOZ_WIDGET_TOOLKIT != cocoa diff --git a/b2g/build.mk b/b2g/build.mk index 8697dec3acf7..136eefe3a4aa 100644 --- a/b2g/build.mk +++ b/b2g/build.mk @@ -9,7 +9,7 @@ package: @$(MAKE) -C b2g/installer install:: - @echo "B2G can't be installed directly." + @echo 'B2G can't be installed directly.' @exit 1 upload:: diff --git a/b2g/installer/Makefile.in b/b2g/installer/Makefile.in index a2ada4343f18..430316cabbbd 100644 --- a/b2g/installer/Makefile.in +++ b/b2g/installer/Makefile.in @@ -62,11 +62,11 @@ ifdef MOZ_PKG_MANIFEST_P $(MOZ_PKG_MANIFEST): $(MOZ_PKG_MANIFEST_P) FORCE $(call py_action,preprocessor,$(DEFINES) $(ACDEFINES) $< -o $@) ifdef MOZ_CHROME_MULTILOCALE - printf "\n[multilocale]\n" >> $@ + printf '\n[multilocale]\n' >> $@ for LOCALE in $(MOZ_CHROME_MULTILOCALE) ;\ do \ - printf "$(BINPATH)/chrome/$$LOCALE$(JAREXT)\n" >> $@; \ - printf "$(BINPATH)/chrome/$$LOCALE.manifest\n" >> $@; \ + printf '$(BINPATH)/chrome/$$LOCALE$(JAREXT)\n' >> $@; \ + printf '$(BINPATH)/chrome/$$LOCALE.manifest\n' >> $@; \ done endif diff --git a/b2g/locales/Makefile.in b/b2g/locales/Makefile.in index c10090a9c19c..14d68a9c32bc 100644 --- a/b2g/locales/Makefile.in +++ b/b2g/locales/Makefile.in @@ -31,7 +31,7 @@ ifneq (,$(filter cocoa,$(MOZ_WIDGET_TOOLKIT))) MOZ_PKG_MAC_DSSTORE=$(_ABS_DIST)/branding/dsstore MOZ_PKG_MAC_BACKGROUND=$(_ABS_DIST)/branding/background.png MOZ_PKG_MAC_ICON=$(_ABS_DIST)/branding/disk.icns -MOZ_PKG_MAC_EXTRA=--symlink "/Applications:/ " +MOZ_PKG_MAC_EXTRA=--symlink '/Applications:/ ' endif ifeq (WINNT,$(OS_ARCH)) @@ -53,7 +53,7 @@ $(DIST)/branding: $(NSINSTALL) -D $@ libs:: - @if test -f "$(LOCALE_SRCDIR)/existing-profile-defaults.js"; then \ + @if test -f '$(LOCALE_SRCDIR)/existing-profile-defaults.js'; then \ $(PYTHON) -m mozbuild.action.preprocessor $(PREF_PPFLAGS) $(DEFINES) $(ACDEFINES) $(XULPPFLAGS) \ $(LOCALE_SRCDIR)/existing-profile-defaults.js -o $(FINAL_TARGET)/defaults/existing-profile-defaults.js; \ fi @@ -74,20 +74,20 @@ chrome-%: repackage-win32-installer: WIN32_INSTALLER_OUT=$(_ABS_DIST)/$(PKG_INST_PATH)$(PKG_INST_BASENAME).exe repackage-win32-installer: $(call ESCAPE_SPACE,$(WIN32_INSTALLER_IN)) $(SUBMAKEFILES) libs-$(AB_CD) - @echo "Repackaging $(WIN32_INSTALLER_IN) into $(WIN32_INSTALLER_OUT)." + @echo 'Repackaging $(WIN32_INSTALLER_IN) into $(WIN32_INSTALLER_OUT).' $(MAKE) -C $(DEPTH)/$(MOZ_BRANDING_DIRECTORY) export $(MAKE) -C ../installer/windows CONFIG_DIR=l10ngen l10ngen/setup.exe l10ngen/7zSD.sfx $(MAKE) repackage-zip \ AB_CD=$(AB_CD) \ MOZ_PKG_FORMAT=SFX7Z \ - ZIP_IN="$(WIN32_INSTALLER_IN)" \ - ZIP_OUT="$(WIN32_INSTALLER_OUT)" \ - SFX_HEADER="$(PWD)/../installer/windows/l10ngen/7zSD.sfx \ - $(topsrcdir)/b2g/installer/windows/app.tag" + ZIP_IN='$(WIN32_INSTALLER_IN)' \ + ZIP_OUT='$(WIN32_INSTALLER_OUT)' \ + SFX_HEADER='$(PWD)/../installer/windows/l10ngen/7zSD.sfx \ + $(topsrcdir)/b2g/installer/windows/app.tag' ifeq (WINNT,$(OS_ARCH)) repackage-win32-installer-%: - @$(MAKE) repackage-win32-installer AB_CD=$* WIN32_INSTALLER_IN="$(WIN32_INSTALLER_IN)" + @$(MAKE) repackage-win32-installer AB_CD=$* WIN32_INSTALLER_IN='$(WIN32_INSTALLER_IN)' else repackage-win32-installer-%: ; endif @@ -109,33 +109,33 @@ langpack: langpack-$(AB_CD) # tinderbox scripts. Alter it with caution. installers-%: clobber-% langpack-% repackage-win32-installer-% repackage-zip-% - @echo "repackaging done" + @echo 'repackaging done' # When we unpack b2g on MacOS X the platform.ini and application.ini are in slightly # different locations that on all other platforms ifeq (Darwin, $(OS_ARCH)) ifdef LIBXUL_SDK -GECKO_PLATFORM_INI_PATH="$(STAGEDIST)/../Frameworks/XUL.framework/Versions/$(MOZILLA_VERSION)/platform.ini" +GECKO_PLATFORM_INI_PATH='$(STAGEDIST)/../Frameworks/XUL.framework/Versions/$(MOZILLA_VERSION)/platform.ini' else -GECKO_PLATFORM_INI_PATH="$(STAGEDIST)/platform.ini" +GECKO_PLATFORM_INI_PATH='$(STAGEDIST)/platform.ini' endif -B2G_APPLICATION_INI_PATH="$(STAGEDIST)/application.ini" +B2G_APPLICATION_INI_PATH='$(STAGEDIST)/application.ini' else ifdef LIBXUL_SDK -GECKO_PLATFORM_INI_PATH="$(STAGEDIST)/xulrunner/platform.ini" +GECKO_PLATFORM_INI_PATH='$(STAGEDIST)/xulrunner/platform.ini' else -GECKO_PLATFORM_INI_PATH="$(STAGEDIST)/platform.ini" +GECKO_PLATFORM_INI_PATH='$(STAGEDIST)/platform.ini' endif -B2G_APPLICATION_INI_PATH="$(STAGEDIST)/application.ini" +B2G_APPLICATION_INI_PATH='$(STAGEDIST)/application.ini' endif ident: - @printf "gecko_revision " + @printf 'gecko_revision ' @$(PYTHON) $(topsrcdir)/config/printconfigsetting.py $(GECKO_PLATFORM_INI_PATH) Build SourceStamp - @printf "b2g_revision " + @printf 'b2g_revision ' @$(PYTHON) $(topsrcdir)/config/printconfigsetting.py $(B2G_APPLICATION_INI_PATH) App SourceStamp - @printf "buildid " + @printf 'buildid ' @$(PYTHON) $(topsrcdir)/config/printconfigsetting.py $(B2G_APPLICATION_INI_PATH) App BuildID merge-%: @@ -150,5 +150,5 @@ endif l10n-check:: $(RM) -rf x-test $(NSINSTALL) -D x-test/toolkit - echo "#define MOZ_LANG_TITLE Just testing" > x-test/toolkit/defines.inc - $(MAKE) installers-x-test L10NBASEDIR="$(PWD)" LOCALE_MERGEDIR="$(PWD)/mergedir" + echo '#define MOZ_LANG_TITLE Just testing' > x-test/toolkit/defines.inc + $(MAKE) installers-x-test L10NBASEDIR='$(PWD)' LOCALE_MERGEDIR='$(PWD)/mergedir' diff --git a/browser/app/Makefile.in b/browser/app/Makefile.in index 03086d51a023..2e9f52113d33 100644 --- a/browser/app/Makefile.in +++ b/browser/app/Makefile.in @@ -13,11 +13,11 @@ AB_CD = en-US DEFINES += \ -DAB_CD=$(AB_CD) \ - -DFIREFOX_ICO=\"$(DIST)/branding/firefox.ico\" \ - -DDOCUMENT_ICO=\"$(DIST)/branding/document.ico\" \ - -DNEWWINDOW_ICO=\"$(DIST)/branding/newwindow.ico\" \ - -DNEWTAB_ICO=\"$(DIST)/branding/newtab.ico\" \ - -DPBMODE_ICO=\"$(DIST)/branding/pbmode.ico\" \ + -DFIREFOX_ICO='"$(DIST)/branding/firefox.ico"' \ + -DDOCUMENT_ICO='"$(DIST)/branding/document.ico"' \ + -DNEWWINDOW_ICO='"$(DIST)/branding/newwindow.ico"' \ + -DNEWTAB_ICO='"$(DIST)/branding/newtab.ico"' \ + -DPBMODE_ICO='"$(DIST)/branding/pbmode.ico"' \ $(NULL) ifdef LIBXUL_SDK #{ @@ -84,7 +84,7 @@ endif ifeq ($(OS_ARCH),OS2) RESFILE=splashos2.res RCFLAGS += -DMOZ_PHOENIX -RCFLAGS += -DFIREFOX_ICO=\"$(DIST)/branding/firefox-os2.ico\" -DDOCUMENT_ICO=\"$(DIST)/branding/document-os2.ico\" +RCFLAGS += -DFIREFOX_ICO='"$(DIST)/branding/firefox-os2.ico"' -DDOCUMENT_ICO='"$(DIST)/branding/document-os2.ico"' endif PROGRAMS_DEST = $(DIST)/bin @@ -166,10 +166,10 @@ MAC_BUNDLE_VERSION = $(shell $(PYTHON) $(srcdir)/macversion.py --version=$(MOZ_A tools repackage:: $(PROGRAM) $(MKDIR) -p $(dist_dest)/Contents/MacOS $(MKDIR) -p $(dist_dest)/Contents/Resources/$(AB).lproj - rsync -a --exclude "*.in" $(srcdir)/macbuild/Contents $(dist_dest) --exclude English.lproj - rsync -a --exclude "*.in" $(srcdir)/macbuild/Contents/Resources/English.lproj/ $(dist_dest)/Contents/Resources/$(AB).lproj - sed -e "s/%APP_VERSION%/$(MOZ_APP_VERSION)/" -e "s/%MAC_APP_NAME%/$(MAC_APP_NAME)/" -e "s/%MOZ_MACBUNDLE_ID%/$(MOZ_MACBUNDLE_ID)/" -e "s/%MAC_BUNDLE_VERSION%/$(MAC_BUNDLE_VERSION)/" $(srcdir)/macbuild/Contents/Info.plist.in > $(dist_dest)/Contents/Info.plist - sed -e "s/%MAC_APP_NAME%/$(MAC_APP_NAME)/" $(srcdir)/macbuild/Contents/Resources/English.lproj/InfoPlist.strings.in | iconv -f UTF-8 -t UTF-16 > $(dist_dest)/Contents/Resources/$(AB).lproj/InfoPlist.strings + rsync -a --exclude '*.in' $(srcdir)/macbuild/Contents $(dist_dest) --exclude English.lproj + rsync -a --exclude '*.in' $(srcdir)/macbuild/Contents/Resources/English.lproj/ $(dist_dest)/Contents/Resources/$(AB).lproj + sed -e 's/%APP_VERSION%/$(MOZ_APP_VERSION)/' -e 's/%MAC_APP_NAME%/$(MAC_APP_NAME)/' -e 's/%MOZ_MACBUNDLE_ID%/$(MOZ_MACBUNDLE_ID)/' -e 's/%MAC_BUNDLE_VERSION%/$(MAC_BUNDLE_VERSION)/' $(srcdir)/macbuild/Contents/Info.plist.in > $(dist_dest)/Contents/Info.plist + sed -e 's/%MAC_APP_NAME%/$(MAC_APP_NAME)/' $(srcdir)/macbuild/Contents/Resources/English.lproj/InfoPlist.strings.in | iconv -f UTF-8 -t UTF-16 > $(dist_dest)/Contents/Resources/$(AB).lproj/InfoPlist.strings rsync -a $(DIST)/bin/ $(dist_dest)/Contents/$(APPFILES) $(RM) $(dist_dest)/Contents/MacOS/$(PROGRAM) rsync -aL $(PROGRAM) $(dist_dest)/Contents/MacOS diff --git a/browser/extensions/Makefile.in b/browser/extensions/Makefile.in index f8ca4bb0470a..03097b2627b2 100644 --- a/browser/extensions/Makefile.in +++ b/browser/extensions/Makefile.in @@ -17,35 +17,35 @@ exclude_files = \ $(NULL) $(FINAL_TARGET)/chrome/pdfjs.manifest: $(GLOBAL_DEPS) - printf "manifest pdfjs/chrome.manifest" > $@ + printf 'manifest pdfjs/chrome.manifest' > $@ libs:: $(FINAL_TARGET)/chrome/pdfjs.manifest $(PYTHON) $(topsrcdir)/config/nsinstall.py \ $(srcdir)/pdfjs \ $(foreach exclude,$(exclude_files), -X $(srcdir)/pdfjs/$(exclude)) \ $(FINAL_TARGET)/chrome - $(call py_action,buildlist,$(FINAL_TARGET)/chrome.manifest "manifest chrome/pdfjs.manifest") + $(call py_action,buildlist,$(FINAL_TARGET)/chrome.manifest 'manifest chrome/pdfjs.manifest') ifdef NIGHTLY_BUILD $(FINAL_TARGET)/chrome/shumway.manifest: $(GLOBAL_DEPS) - printf "manifest shumway/chrome.manifest" > $@ + printf 'manifest shumway/chrome.manifest' > $@ libs:: $(FINAL_TARGET)/chrome/shumway.manifest $(PYTHON) $(topsrcdir)/config/nsinstall.py \ $(srcdir)/shumway \ $(foreach exclude,$(exclude_files), -X $(srcdir)/shumway/$(exclude)) \ $(FINAL_TARGET)/chrome - $(call py_action,buildlist,$(FINAL_TARGET)/chrome.manifest "manifest chrome/shumway.manifest") + $(call py_action,buildlist,$(FINAL_TARGET)/chrome.manifest 'manifest chrome/shumway.manifest') endif ifdef MOZ_METRO $(DIST)/bin/metro/chrome/pdfjs.manifest: $(GLOBAL_DEPS) - printf "manifest pdfjs/chrome.manifest" > $@ + printf 'manifest pdfjs/chrome.manifest' > $@ libs:: $(DIST)/bin/metro/chrome/pdfjs.manifest $(PYTHON) $(topsrcdir)/config/nsinstall.py \ $(srcdir)/pdfjs \ $(foreach exclude,$(exclude_files), -X $(srcdir)/pdfjs/$(exclude)) \ $(DIST)/bin/metro/chrome - $(call py_action,buildlist,$(DIST)/bin/metro/chrome.manifest "manifest chrome/pdfjs.manifest") + $(call py_action,buildlist,$(DIST)/bin/metro/chrome.manifest 'manifest chrome/pdfjs.manifest') endif diff --git a/browser/installer/Makefile.in b/browser/installer/Makefile.in index e08912109900..686f74cdc377 100644 --- a/browser/installer/Makefile.in +++ b/browser/installer/Makefile.in @@ -92,7 +92,7 @@ ifeq (cocoa,$(MOZ_WIDGET_TOOLKIT)) MOZ_PKG_MAC_DSSTORE=branding/dsstore MOZ_PKG_MAC_BACKGROUND=branding/background.png MOZ_PKG_MAC_ICON=branding/disk.icns -MOZ_PKG_MAC_EXTRA=--symlink "/Applications:/ " +MOZ_PKG_MAC_EXTRA=--symlink '/Applications:/ ' endif ifndef LIBXUL_SDK @@ -128,7 +128,7 @@ endif package-compare:: $(MOZ_PKG_MANIFEST) ifdef MOZ_PKG_MANIFEST_P cd $(DIST); find $(PKGCOMP_FIND_OPTS) $(FINDPATH) -type f | sort > bin-list.txt - grep "^$(BINPATH)" $(MOZ_PKG_MANIFEST) | sed -e 's/^\///' | sort > $(DIST)/pack-list.txt + grep '^$(BINPATH)' $(MOZ_PKG_MANIFEST) | sed -e 's/^\///' | sort > $(DIST)/pack-list.txt -diff -u $(DIST)/pack-list.txt $(DIST)/bin-list.txt rm -f $(DIST)/pack-list.txt $(DIST)/bin-list.txt endif diff --git a/browser/installer/windows/Makefile.in b/browser/installer/windows/Makefile.in index 463918ce6372..4813d629abf4 100644 --- a/browser/installer/windows/Makefile.in +++ b/browser/installer/windows/Makefile.in @@ -41,7 +41,7 @@ BRANDING_FILES = \ DEFINES += \ -DAB_CD=$(AB_CD) \ -DMOZ_APP_NAME=$(MOZ_APP_NAME) \ - -DMOZ_APP_DISPLAYNAME="${MOZ_APP_DISPLAYNAME}" \ + -DMOZ_APP_DISPLAYNAME='${MOZ_APP_DISPLAYNAME}' \ -DMOZILLA_VERSION=${MOZILLA_VERSION} \ $(NULL) diff --git a/browser/locales/Makefile.in b/browser/locales/Makefile.in index 12af0b7df1be..eb3c30b1aa74 100644 --- a/browser/locales/Makefile.in +++ b/browser/locales/Makefile.in @@ -50,7 +50,7 @@ ifneq (,$(filter cocoa,$(MOZ_WIDGET_TOOLKIT))) MOZ_PKG_MAC_DSSTORE=$(_ABS_DIST)/branding/dsstore MOZ_PKG_MAC_BACKGROUND=$(_ABS_DIST)/branding/background.png MOZ_PKG_MAC_ICON=$(_ABS_DIST)/branding/disk.icns -MOZ_PKG_MAC_EXTRA=--symlink "/Applications:/ " +MOZ_PKG_MAC_EXTRA=--symlink '/Applications:/ ' endif ifeq (WINNT,$(OS_ARCH)) @@ -61,10 +61,10 @@ UNINSTALLER_PACKAGE_HOOK = $(RM) -r $(STAGEDIST)/uninstall; \ cp ../installer/windows/l10ngen/setup.exe $(_ABS_DIST)/l10n-stage; \ $(NULL) -STUB_HOOK = $(NSINSTALL) -D "$(_ABS_DIST)/$(PKG_INST_PATH)"; \ - $(RM) "$(_ABS_DIST)/$(PKG_INST_PATH)$(PKG_STUB_BASENAME).exe"; \ - cp ../installer/windows/l10ngen/stub.exe "$(_ABS_DIST)/$(PKG_INST_PATH)$(PKG_STUB_BASENAME).exe"; \ - chmod 0755 "$(_ABS_DIST)/$(PKG_INST_PATH)$(PKG_STUB_BASENAME).exe"; \ +STUB_HOOK = $(NSINSTALL) -D '$(_ABS_DIST)/$(PKG_INST_PATH)'; \ + $(RM) '$(_ABS_DIST)/$(PKG_INST_PATH)$(PKG_STUB_BASENAME).exe'; \ + cp ../installer/windows/l10ngen/stub.exe '$(_ABS_DIST)/$(PKG_INST_PATH)$(PKG_STUB_BASENAME).exe'; \ + chmod 0755 '$(_ABS_DIST)/$(PKG_INST_PATH)$(PKG_STUB_BASENAME).exe'; \ $(NULL) endif @@ -140,20 +140,20 @@ endif repackage-win32-installer: WIN32_INSTALLER_OUT=$(_ABS_DIST)/$(PKG_INST_PATH)$(PKG_INST_BASENAME).exe repackage-win32-installer: $(call ESCAPE_WILDCARD,$(WIN32_INSTALLER_IN)) $(SUBMAKEFILES) libs-$(AB_CD) - @echo "Repackaging $(WIN32_INSTALLER_IN) into $(WIN32_INSTALLER_OUT)." + @echo 'Repackaging $(WIN32_INSTALLER_IN) into $(WIN32_INSTALLER_OUT).' $(MAKE) -C $(DEPTH)/$(MOZ_BRANDING_DIRECTORY) export $(MAKE) -C ../installer/windows CONFIG_DIR=l10ngen l10ngen/setup.exe l10ngen/7zSD.sfx $(MAKE) repackage-zip \ AB_CD=$(AB_CD) \ MOZ_PKG_FORMAT=SFX7Z \ - ZIP_IN="$(WIN32_INSTALLER_IN)" \ - ZIP_OUT="$(WIN32_INSTALLER_OUT)" \ - SFX_HEADER="$(PWD)/../installer/windows/l10ngen/7zSD.sfx \ - $(topsrcdir)/browser/installer/windows/app.tag" + ZIP_IN='$(WIN32_INSTALLER_IN)' \ + ZIP_OUT='$(WIN32_INSTALLER_OUT)' \ + SFX_HEADER='$(PWD)/../installer/windows/l10ngen/7zSD.sfx \ + $(topsrcdir)/browser/installer/windows/app.tag' ifeq (WINNT,$(OS_ARCH)) repackage-win32-installer-%: $(STAGEDIST) - @$(MAKE) repackage-win32-installer AB_CD=$* WIN32_INSTALLER_IN="$(WIN32_INSTALLER_IN)" + @$(MAKE) repackage-win32-installer AB_CD=$* WIN32_INSTALLER_IN='$(WIN32_INSTALLER_IN)' repackage-zip-%: repackage-win32-installer-% else @@ -182,7 +182,7 @@ langpack: langpack-$(AB_CD) # tinderbox scripts. Alter it with caution. installers-%: clobber-% langpack-% repackage-win32-installer-% repackage-zip-% - @echo "repackaging done" + @echo 'repackaging done' ifdef MOZ_UPDATER # Note that we want updater.ini to be in the top directory, not the browser/ @@ -190,13 +190,13 @@ ifdef MOZ_UPDATER libs:: $(call MERGE_FILE,updater/updater.ini) $(call mkdir_deps,$(DIST)/bin) ifeq ($(OS_ARCH),WINNT) cat $< $(srcdir)/../installer/windows/nsis/updater_append.ini | \ - sed -e "s/^InfoText=/Info=/" -e "s/^TitleText=/Title=/" | \ - sed -e "s/%MOZ_APP_DISPLAYNAME%/$(MOZ_APP_DISPLAYNAME)/" > \ + sed -e 's/^InfoText=/Info=/' -e 's/^TitleText=/Title=/' | \ + sed -e 's/%MOZ_APP_DISPLAYNAME%/$(MOZ_APP_DISPLAYNAME)/' > \ $(FINAL_TARGET)/../updater.ini else cat $< | \ - sed -e "s/^InfoText=/Info=/" -e "s/^TitleText=/Title=/" | \ - sed -e "s/%MOZ_APP_DISPLAYNAME%/$(MOZ_APP_DISPLAYNAME)/" > \ + sed -e 's/^InfoText=/Info=/' -e 's/^TitleText=/Title=/' | \ + sed -e 's/%MOZ_APP_DISPLAYNAME%/$(MOZ_APP_DISPLAYNAME)/' > \ $(FINAL_TARGET)/../updater.ini endif endif @@ -207,10 +207,10 @@ libs:: crashreporter-override.ini endif ident: - @printf "fx_revision " + @printf 'fx_revision ' @$(PYTHON) $(topsrcdir)/config/printconfigsetting.py \ $(STAGEDIST)/application.ini App SourceStamp - @printf "buildid " + @printf 'buildid ' @$(PYTHON) $(topsrcdir)/config/printconfigsetting.py \ $(STAGEDIST)/application.ini App BuildID @@ -227,7 +227,7 @@ l10n-check:: INNER_UNMAKE_PACKAGE=true l10n-check:: $(RM) -rf x-test $(NSINSTALL) -D x-test/toolkit - echo "#define MOZ_LANG_TITLE Just testing" > x-test/toolkit/defines.inc - $(MAKE) installers-x-test L10NBASEDIR="$(PWD)" LOCALE_MERGEDIR="$(PWD)/mergedir" + echo '#define MOZ_LANG_TITLE Just testing' > x-test/toolkit/defines.inc + $(MAKE) installers-x-test L10NBASEDIR='$(PWD)' LOCALE_MERGEDIR='$(PWD)/mergedir' $(PYTHON) $(topsrcdir)/toolkit/mozapps/installer/unpack.py $(DIST)/l10n-stage/$(STAGEPATH)$(MOZ_PKG_DIR)$(_BINPATH) cd $(DIST)/l10n-stage && test $$(cat $(STAGEPATH)$(MOZ_PKG_DIR)$(_BINPATH)/update.locale) = x-test diff --git a/browser/metro/Makefile.in b/browser/metro/Makefile.in index f5066f1d6bcf..33f60fea731d 100644 --- a/browser/metro/Makefile.in +++ b/browser/metro/Makefile.in @@ -12,7 +12,7 @@ DEFINES += -DGRE_BUILDID=$(GRE_BUILDID) -DMOZ_APP_BASENAME=$(MOZ_APP_BASENAME) # 'application.ini' breaks firefox build config. So we use something different. metroapp.ini: metroapp.ini.in $(DEPTH)/config/buildid $(topsrcdir)/config/milestone.txt - $(RM) "metroapp.ini" + $(RM) metroapp.ini $(call py_action,preprocessor,$(DEFINES) $< -o $@) libs:: metroapp.ini diff --git a/browser/metro/locales/Makefile.in b/browser/metro/locales/Makefile.in index c18eb3778f43..d5e42c05a9fe 100644 --- a/browser/metro/locales/Makefile.in +++ b/browser/metro/locales/Makefile.in @@ -19,6 +19,6 @@ BRANDFOLDER = $(notdir $(MOZ_BRANDING_DIRECTORY)) branding-$(BRANDFOLDER): $(MAKE) -C $(DEPTH)/browser/branding/$(BRANDFOLDER) \ - DIST_SUBDIR=$(DIST_SUBDIR) XPI_ROOT_APPID="$(XPI_ROOT_APPID)" + DIST_SUBDIR=$(DIST_SUBDIR) XPI_ROOT_APPID='$(XPI_ROOT_APPID)' libs:: branding-$(BRANDFOLDER) diff --git a/browser/metro/locales/import/Makefile.in b/browser/metro/locales/import/Makefile.in index 821be825bf57..7afe90eb4f86 100644 --- a/browser/metro/locales/import/Makefile.in +++ b/browser/metro/locales/import/Makefile.in @@ -24,7 +24,7 @@ include $(topsrcdir)/config/rules.mk # Metro reuses desktop search plugins libs:: $(MAKE) -C $(DEPTH)/browser/locales searchplugins \ - DIST_SUBDIR=$(DIST_SUBDIR) XPI_ROOT_APPID="$(XPI_ROOT_APPID)" + DIST_SUBDIR=$(DIST_SUBDIR) XPI_ROOT_APPID='$(XPI_ROOT_APPID)' ######################################### # Bookmarks @@ -43,7 +43,7 @@ bookmarks-src = $(srcdir)/../generic/profile/bookmarks.json.in # The resulting bookmarks.json will get picked up and packaged by the # processing of the jar file in the parent directory. bookmarks: bookmarks.inc - @echo "Generating: $@" + @echo 'Generating: $@' $(call py_action,preprocessor, \ -I $^ \ -DAB_CD=$(AB_CD) \ diff --git a/browser/themes/linux/Makefile.in b/browser/themes/linux/Makefile.in index 67f553d6ef9c..a2256e8f32d1 100644 --- a/browser/themes/linux/Makefile.in +++ b/browser/themes/linux/Makefile.in @@ -14,11 +14,11 @@ INSTALL_TARGETS += ICON # the processing of the jar file in this directory. tab-selected-svg: $(srcdir)/../shared/tab-selected.svg $(call py_action,preprocessor, \ - --marker "%" -D TAB_SIDE=start \ + --marker % -D TAB_SIDE=start \ $(ACDEFINES) \ $(srcdir)/../shared/tab-selected.svg -o tab-selected-start.svg) $(call py_action,preprocessor, \ - --marker "%" -D TAB_SIDE=end \ + --marker % -D TAB_SIDE=end \ $(ACDEFINES) \ $(srcdir)/../shared/tab-selected.svg -o tab-selected-end.svg) diff --git a/browser/themes/osx/Makefile.in b/browser/themes/osx/Makefile.in index 67f553d6ef9c..a2256e8f32d1 100644 --- a/browser/themes/osx/Makefile.in +++ b/browser/themes/osx/Makefile.in @@ -14,11 +14,11 @@ INSTALL_TARGETS += ICON # the processing of the jar file in this directory. tab-selected-svg: $(srcdir)/../shared/tab-selected.svg $(call py_action,preprocessor, \ - --marker "%" -D TAB_SIDE=start \ + --marker % -D TAB_SIDE=start \ $(ACDEFINES) \ $(srcdir)/../shared/tab-selected.svg -o tab-selected-start.svg) $(call py_action,preprocessor, \ - --marker "%" -D TAB_SIDE=end \ + --marker % -D TAB_SIDE=end \ $(ACDEFINES) \ $(srcdir)/../shared/tab-selected.svg -o tab-selected-end.svg) diff --git a/build/Makefile.in b/build/Makefile.in index 15b9773b8dc8..f75666fa275b 100644 --- a/build/Makefile.in +++ b/build/Makefile.in @@ -28,14 +28,14 @@ DEFINES += -DAPP_BUILDID=$(APP_BUILDID) APP_INI_DEPS += $(DEPTH)/config/autoconf.mk -MOZ_SOURCE_STAMP := $(firstword $(shell cd $(topsrcdir)/$(MOZ_BUILD_APP)/.. && hg parent --template="{node|short}\n" 2>/dev/null)) +MOZ_SOURCE_STAMP := $(firstword $(shell cd $(topsrcdir)/$(MOZ_BUILD_APP)/.. && hg parent --template='{node|short}\n' 2>/dev/null)) ifdef MOZ_SOURCE_STAMP -DEFINES += -DMOZ_SOURCE_STAMP="$(MOZ_SOURCE_STAMP)" +DEFINES += -DMOZ_SOURCE_STAMP='$(MOZ_SOURCE_STAMP)' endif source_repo ?= $(call getSourceRepo,$(topsrcdir)/$(MOZ_BUILD_APP)/..) ifneq (,$(source_repo)) - DEFINES += -DMOZ_SOURCE_REPO="$(source_repo)" + DEFINES += -DMOZ_SOURCE_REPO='$(source_repo)' endif endif diff --git a/build/automation-build.mk b/build/automation-build.mk index 1f998485e5f3..3bbc0a7cede2 100644 --- a/build/automation-build.mk +++ b/build/automation-build.mk @@ -4,7 +4,7 @@ include $(MOZILLA_DIR)/build/binary-location.mk -browser_path := \"$(browser_path)\" +browser_path := '"$(browser_path)"' _PROFILE_DIR = $(TARGET_DEPTH)/_profile/pgo @@ -13,11 +13,11 @@ _CERTS_SRC_DIR = $(ABSOLUTE_TOPSRCDIR)/build/pgo/certs AUTOMATION_PPARGS = \ -DBROWSER_PATH=$(browser_path) \ - -DXPC_BIN_PATH=\"$(LIBXUL_DIST)/bin\" \ - -DBIN_SUFFIX=\"$(BIN_SUFFIX)\" \ - -DPROFILE_DIR=\"$(_PROFILE_DIR)\" \ - -DCERTS_SRC_DIR=\"$(_CERTS_SRC_DIR)\" \ - -DPERL="\"$(PERL)\"" \ + -DXPC_BIN_PATH='"$(LIBXUL_DIST)/bin"' \ + -DBIN_SUFFIX='"$(BIN_SUFFIX)"' \ + -DPROFILE_DIR='"$(_PROFILE_DIR)"' \ + -DCERTS_SRC_DIR='"$(_CERTS_SRC_DIR)"' \ + -DPERL='"$(PERL)"' \ $(NULL) ifeq ($(OS_ARCH),Darwin) diff --git a/build/package/Makefile.in b/build/package/Makefile.in index c945b169a0e4..7d4f66b113fe 100644 --- a/build/package/Makefile.in +++ b/build/package/Makefile.in @@ -58,7 +58,7 @@ makedmg-%: ifndef PACKAGES stage-packages makexpi-packages: - @echo "Please set PACKAGES on the makefile command line or environment." + @echo 'Please set PACKAGES on the makefile command line or environment.' else #PACKAGES stage-packages: diff --git a/build/unix/elfhack/Makefile.in b/build/unix/elfhack/Makefile.in index 44bea9317f53..71db949b934f 100644 --- a/build/unix/elfhack/Makefile.in +++ b/build/unix/elfhack/Makefile.in @@ -27,7 +27,7 @@ test-array$(DLL_SUFFIX) test-ctors$(DLL_SUFFIX): %$(DLL_SUFFIX): %.$(OBJ_SUFFIX) @rm -f $@.bak $(CURDIR)/elfhack -b -f $@ # Fail if the backup file doesn't exist - [ -f "$@.bak" ] + [ -f '$@.bak' ] # Fail if the new library doesn't contain less relocations [ $$($(TOOLCHAIN_PREFIX)objdump -R $@.bak | wc -l) -gt $$(objdump -R $@ | wc -l) ] diff --git a/build/win32/Makefile.in b/build/win32/Makefile.in index e3132fb73267..00bdae24ef9c 100644 --- a/build/win32/Makefile.in +++ b/build/win32/Makefile.in @@ -44,7 +44,7 @@ libs-preqs = \ $(NULL) libs:: $(libs-preqs) - install --preserve-timestamps $(foreach f,$(REDIST_FILES),"$(WIN32_REDIST_DIR)"/$(f)) $(FINAL_TARGET) + install --preserve-timestamps $(foreach f,$(REDIST_FILES),'$(WIN32_REDIST_DIR)'/$(f)) $(FINAL_TARGET) endif endif # ! MOZ_DEBUG diff --git a/client.mk b/client.mk index f3c00b013c0f..561a294b1187 100644 --- a/client.mk +++ b/client.mk @@ -204,7 +204,7 @@ ifdef WANT_MOZCONFIG_MK # For now, only output "export" lines from mozconfig2client-mk output. MOZCONFIG_MK_LINES := $(filter export||%,$(MOZCONFIG_OUT_LINES)) $(OBJDIR)/.mozconfig.mk: $(FOUND_MOZCONFIG) $(call mkdir_deps,$(OBJDIR)) - $(if $(MOZCONFIG_MK_LINES),( $(foreach line,$(MOZCONFIG_MK_LINES), echo "$(subst ||, ,$(line))";) )) > $@ + $(if $(MOZCONFIG_MK_LINES),( $(foreach line,$(MOZCONFIG_MK_LINES), echo '$(subst ||, ,$(line))';) )) > $@ # Include that makefile so that it is created. This should not actually change # the environment since MOZCONFIG_CONTENT, which MOZCONFIG_OUT_LINES derives @@ -278,7 +278,7 @@ else # this point when building multiple projects. Only MOZ_OBJDIR is available. set -e; \ for mkfile in $(MOZ_PREFLIGHT_ALL); do \ - $(MAKE) -f $(TOPSRCDIR)/$$mkfile preflight_all TOPSRCDIR=$(TOPSRCDIR) MOZ_OBJDIR=$(MOZ_OBJDIR) MOZ_BUILD_PROJECTS="$(MOZ_BUILD_PROJECTS)"; \ + $(MAKE) -f $(TOPSRCDIR)/$$mkfile preflight_all TOPSRCDIR=$(TOPSRCDIR) MOZ_OBJDIR=$(MOZ_OBJDIR) MOZ_BUILD_PROJECTS='$(MOZ_BUILD_PROJECTS)'; \ done endif endif @@ -330,7 +330,7 @@ CONFIG_STATUS_DEPS := \ $(NULL) CONFIGURE_ENV_ARGS += \ - MAKE="$(MAKE)" \ + MAKE='$(MAKE)' \ $(NULL) # configure uses the program name to determine @srcdir@. Calling it without @@ -363,8 +363,8 @@ configure:: $(configure-preqs) @echo cd $(OBJDIR); @echo $(CONFIGURE) $(CONFIGURE_ARGS) @cd $(OBJDIR) && $(BUILD_PROJECT_ARG) $(CONFIGURE_ENV_ARGS) $(CONFIGURE) $(CONFIGURE_ARGS) \ - || ( echo "*** Fix above errors and then restart with\ - \"$(MAKE) -f client.mk build\"" && exit 1 ) + || ( echo '*** Fix above errors and then restart with\ + "$(MAKE) -f client.mk build"' && exit 1 ) @touch $(OBJDIR)/Makefile ifneq (,$(MAKEFILE)) @@ -437,7 +437,7 @@ else # this point when building multiple projects. Only MOZ_OBJDIR is available. set -e; \ for mkfile in $(MOZ_POSTFLIGHT_ALL); do \ - $(MAKE) -f $(TOPSRCDIR)/$$mkfile postflight_all TOPSRCDIR=$(TOPSRCDIR) MOZ_OBJDIR=$(MOZ_OBJDIR) MOZ_BUILD_PROJECTS="$(MOZ_BUILD_PROJECTS)"; \ + $(MAKE) -f $(TOPSRCDIR)/$$mkfile postflight_all TOPSRCDIR=$(TOPSRCDIR) MOZ_OBJDIR=$(MOZ_OBJDIR) MOZ_BUILD_PROJECTS='$(MOZ_BUILD_PROJECTS)'; \ done endif endif @@ -447,7 +447,7 @@ cleansrcdir: if [ -f Makefile ]; then \ $(MAKE) distclean ; \ else \ - echo "Removing object files from srcdir..."; \ + echo 'Removing object files from srcdir...'; \ rm -fr `find . -type d \( -name .deps -print -o -name CVS \ -o -exec test ! -d {}/CVS \; \) -prune \ -o \( -name '*.[ao]' -o -name '*.so' \) -type f -print`; \ diff --git a/config/Makefile.in b/config/Makefile.in index 709cd7e98d55..3fc50be2db5e 100644 --- a/config/Makefile.in +++ b/config/Makefile.in @@ -59,7 +59,7 @@ HOST_CFLAGS += -DUNICODE -D_UNICODE # supposed to be once per-build! export:: ifdef MOZ_BUILD_DATE - printf "%s" $(MOZ_BUILD_DATE) > buildid + printf '%s' $(MOZ_BUILD_DATE) > buildid else $(PYTHON) $(topsrcdir)/toolkit/xre/make-platformini.py --print-buildid > buildid endif diff --git a/config/config.mk b/config/config.mk index 6d64b5a4cb3a..7df9552b27d6 100644 --- a/config/config.mk +++ b/config/config.mk @@ -811,7 +811,7 @@ endif MERGE_FILES = $(foreach f,$(1),$(call MERGE_FILE,$(f))) ifeq (OS2,$(OS_ARCH)) -RUN_TEST_PROGRAM = $(topsrcdir)/build/os2/test_os2.cmd "$(LIBXUL_DIST)" +RUN_TEST_PROGRAM = $(topsrcdir)/build/os2/test_os2.cmd '$(LIBXUL_DIST)' else ifneq (WINNT,$(OS_ARCH)) RUN_TEST_PROGRAM = $(LIBXUL_DIST)/bin/run-mozilla.sh @@ -848,7 +848,7 @@ EXPAND_MKSHLIB = $(EXPAND_LIBS_EXEC) $(EXPAND_MKSHLIB_ARGS) -- $(MKSHLIB) ifneq (,$(MOZ_LIBSTDCXX_TARGET_VERSION)$(MOZ_LIBSTDCXX_HOST_VERSION)) ifneq ($(OS_ARCH),Darwin) -CHECK_STDCXX = objdump -p $(1) | grep -e 'GLIBCXX_3\.4\.\(9\|[1-9][0-9]\)' > /dev/null && echo "TEST-UNEXPECTED-FAIL | | We don't want these libstdc++ symbols to be used:" && objdump -T $(1) | grep -e 'GLIBCXX_3\.4\.\(9\|[1-9][0-9]\)' && exit 1 || exit 0 +CHECK_STDCXX = objdump -p $(1) | grep -e 'GLIBCXX_3\.4\.\(9\|[1-9][0-9]\)' > /dev/null && echo 'TEST-UNEXPECTED-FAIL | | We do not want these libstdc++ symbols to be used:' && objdump -T $(1) | grep -e 'GLIBCXX_3\.4\.\(9\|[1-9][0-9]\)' && exit 1 || exit 0 endif ifdef MOZ_LIBSTDCXX_TARGET_VERSION diff --git a/config/makefiles/autotargets.mk b/config/makefiles/autotargets.mk index f8f0238612c8..16e06fb2a410 100644 --- a/config/makefiles/autotargets.mk +++ b/config/makefiles/autotargets.mk @@ -56,18 +56,18 @@ mkdir_deps =$(foreach dir,$(getargv),$(call slash_strip,$(dir)/.mkdir.done)) ####################### %/.mkdir.done: # mkdir -p -p => mkdir -p - $(subst $(space)-p,$(null),$(MKDIR)) -p "$(dir $@)" + $(subst $(space)-p,$(null),$(MKDIR)) -p '$(dir $@)' # Make the timestamp old enough for not being a problem with symbolic links # targets depending on it. Use Jan 3, 1980 to accomodate any timezone where # 198001010000 would translate to something older than FAT epoch. - @$(TOUCH) -t 198001030000 "$@" + @$(TOUCH) -t 198001030000 '$@' # A handful of makefiles are attempting "mkdir dot". # tbpl/valgrind builds are using this target # https://bugzilla.mozilla.org/show_bug.cgi?id=837754 .mkdir.done: - @echo "WARNING: $(MKDIR) -dot- requested by $(MAKE) -C $(CURDIR) $(MAKECMDGOALS)" - @$(TOUCH) -t 198001030000 "$@" + @echo 'WARNING: $(MKDIR) -dot- requested by $(MAKE) -C $(CURDIR) $(MAKECMDGOALS)' + @$(TOUCH) -t 198001030000 '$@' INCLUDED_AUTOTARGETS_MK = 1 endif #} diff --git a/config/makefiles/target_binaries.mk b/config/makefiles/target_binaries.mk index 0e8e58a659a4..c2927e6b3478 100644 --- a/config/makefiles/target_binaries.mk +++ b/config/makefiles/target_binaries.mk @@ -25,8 +25,8 @@ ifdef IS_COMPONENT $(INSTALL) $(IFLAGS2) $(SHARED_LIBRARY) $(FINAL_TARGET)/components $(ELF_DYNSTR_GC) $(FINAL_TARGET)/components/$(SHARED_LIBRARY) ifndef NO_COMPONENTS_MANIFEST - $(call py_action,buildlist,$(FINAL_TARGET)/chrome.manifest "manifest components/components.manifest") - $(call py_action,buildlist,$(FINAL_TARGET)/components/components.manifest "binary-component $(SHARED_LIBRARY)") + $(call py_action,buildlist,$(FINAL_TARGET)/chrome.manifest 'manifest components/components.manifest') + $(call py_action,buildlist,$(FINAL_TARGET)/components/components.manifest 'binary-component $(SHARED_LIBRARY)') endif endif # IS_COMPONENT endif # SHARED_LIBRARY @@ -109,11 +109,11 @@ BINARIES_INSTALL_TARGETS := $(foreach category,$(INSTALL_TARGETS),$(if $(filter BINARIES_PP := $(MDDEPDIR)/binaries.pp $(BINARIES_PP): Makefile $(wildcard backend.mk) $(call mkdir_deps,$(MDDEPDIR)) - @echo "$(strip $(foreach category,$(BINARIES_INSTALL_TARGETS),\ + @echo '$(strip $(foreach category,$(BINARIES_INSTALL_TARGETS),\ $(foreach file,$($(category)_FILES) $($(category)_EXECUTABLES),\ $($(category)_DEST)/$(notdir $(file)): $(file)%\ )\ - ))binaries: Makefile $(wildcard backend.mk)" | tr % '\n' > $@ + ))binaries: Makefile $(wildcard backend.mk)' | tr % '\n' > $@ else binaries:: diff --git a/config/recurse.mk b/config/recurse.mk index 2969441bb8d2..07dfa9d51e28 100644 --- a/config/recurse.mk +++ b/config/recurse.mk @@ -129,7 +129,7 @@ recurse_$(CURRENT_TIER): # Creating binaries-deps.mk directly would make us build it twice: once when beginning # the build because of the include, and once at the end because of the stamps. binaries-deps: $(addsuffix /binaries,$(CURRENT_DIRS)) - @$(call py_action,link_deps,-o $@.mk --group-by-depfile --topsrcdir $(topsrcdir) --topobjdir $(DEPTH) --dist $(DIST) --guard $(addprefix ",$(addsuffix ",$^))) + @$(call py_action,link_deps,-o $@.mk --group-by-depfile --topsrcdir $(topsrcdir) --topobjdir $(DEPTH) --dist $(DIST) --guard $(addprefix ',$(addsuffix ',$^))) @$(TOUCH) $@ ifeq (recurse_binaries,$(MAKECMDGOALS)) diff --git a/config/rules.mk b/config/rules.mk index 39cc75b4ff4f..9f8d932c0888 100644 --- a/config/rules.mk +++ b/config/rules.mk @@ -129,7 +129,7 @@ check:: cppunittests-remote: DM_TRANS?=adb cppunittests-remote: - @if [ "${TEST_DEVICE}" != "" -o "$(DM_TRANS)" = "adb" ]; then \ + @if [ '${TEST_DEVICE}' != '' -o '$(DM_TRANS)' = 'adb' ]; then \ $(PYTHON) -u $(topsrcdir)/testing/remotecppunittests.py \ --xre-path=$(DEPTH)/dist/bin \ --localLib=$(DEPTH)/dist/$(MOZ_APP_NAME) \ @@ -137,7 +137,7 @@ cppunittests-remote: --deviceIP=${TEST_DEVICE} \ $(subst .cpp,$(BIN_SUFFIX),$(CPP_UNIT_TESTS)) $(EXTRA_TEST_ARGS); \ else \ - echo "please prepare your host with environment variables for TEST_DEVICE"; \ + echo 'please prepare your host with environment variables for TEST_DEVICE'; \ fi endif # COMPILE_ENVIRONMENT @@ -364,13 +364,13 @@ ifdef MOZ_UPDATE_XTERM # Its good not to have a newline at the end of the titlebar string because it # makes the make -s output easier to read. Echo -n does not work on all # platforms, but we can trick printf into doing it. -UPDATE_TITLE = printf "\033]0;%s in %s\007" $(1) $(relativesrcdir)/$(2) ; +UPDATE_TITLE = printf '\033]0;%s in %s\007' $(1) $(relativesrcdir)/$(2) ; endif ifdef MACH ifndef NO_BUILDSTATUS_MESSAGES define BUILDSTATUS -@echo "BUILDSTATUS $1" +@echo 'BUILDSTATUS $1' endef endif @@ -743,22 +743,22 @@ ifeq (_WINNT,$(GNU_CC)_$(OS_ARCH)) $(EXPAND_LD) -NOLOGO -OUT:$@ -PDB:$(LINK_PDBFILE) $(WIN32_EXE_LDFLAGS) $(LDFLAGS) $(MOZ_GLUE_PROGRAM_LDFLAGS) $(PROGOBJS) $(RESFILE) $(LIBS) $(EXTRA_LIBS) $(OS_LIBS) ifdef MSMANIFEST_TOOL @if test -f $@.manifest; then \ - if test -f "$(srcdir)/$@.manifest"; then \ - echo "Embedding manifest from $(srcdir)/$@.manifest and $@.manifest"; \ - mt.exe -NOLOGO -MANIFEST "$(win_srcdir)/$@.manifest" $@.manifest -OUTPUTRESOURCE:$@\;1; \ + if test -f '$(srcdir)/$@.manifest'; then \ + echo 'Embedding manifest from $(srcdir)/$@.manifest and $@.manifest'; \ + mt.exe -NOLOGO -MANIFEST '$(win_srcdir)/$@.manifest' $@.manifest -OUTPUTRESOURCE:$@\;1; \ else \ - echo "Embedding manifest from $@.manifest"; \ + echo 'Embedding manifest from $@.manifest'; \ mt.exe -NOLOGO -MANIFEST $@.manifest -OUTPUTRESOURCE:$@\;1; \ fi; \ - elif test -f "$(srcdir)/$@.manifest"; then \ - echo "Embedding manifest from $(srcdir)/$@.manifest"; \ - mt.exe -NOLOGO -MANIFEST "$(win_srcdir)/$@.manifest" -OUTPUTRESOURCE:$@\;1; \ + elif test -f '$(srcdir)/$@.manifest'; then \ + echo 'Embedding manifest from $(srcdir)/$@.manifest'; \ + mt.exe -NOLOGO -MANIFEST '$(win_srcdir)/$@.manifest' -OUTPUTRESOURCE:$@\;1; \ fi endif # MSVC with manifest tool ifdef MOZ_PROFILE_GENERATE # touch it a few seconds into the future to work around FAT's # 2-second granularity - touch -t `date +%Y%m%d%H%M.%S -d "now+5seconds"` pgo.relink + touch -t `date +%Y%m%d%H%M.%S -d 'now+5seconds'` pgo.relink endif else # !WINNT || GNU_CC $(EXPAND_CCC) -o $@ $(CXXFLAGS) $(PROGOBJS) $(RESFILE) $(WIN32_EXE_LDFLAGS) $(LDFLAGS) $(WRAP_LDFLAGS) $(LIBS_DIR) $(LIBS) $(MOZ_GLUE_PROGRAM_LDFLAGS) $(OS_LIBS) $(EXTRA_LIBS) $(BIN_FLAGS) $(EXE_DEF_FILE) $(STLPORT_LIBS) @@ -778,16 +778,16 @@ ifeq (_WINNT,$(GNU_CC)_$(HOST_OS_ARCH)) $(EXPAND_LIBS_EXEC) -- $(HOST_LD) -NOLOGO -OUT:$@ -PDB:$(HOST_PDBFILE) $(HOST_OBJS) $(WIN32_EXE_LDFLAGS) $(HOST_LDFLAGS) $(HOST_LIBS) $(HOST_EXTRA_LIBS) ifdef MSMANIFEST_TOOL @if test -f $@.manifest; then \ - if test -f "$(srcdir)/$@.manifest"; then \ - echo "Embedding manifest from $(srcdir)/$@.manifest and $@.manifest"; \ - mt.exe -NOLOGO -MANIFEST "$(win_srcdir)/$@.manifest" $@.manifest -OUTPUTRESOURCE:$@\;1; \ + if test -f '$(srcdir)/$@.manifest'; then \ + echo 'Embedding manifest from $(srcdir)/$@.manifest and $@.manifest'; \ + mt.exe -NOLOGO -MANIFEST '$(win_srcdir)/$@.manifest' $@.manifest -OUTPUTRESOURCE:$@\;1; \ else \ - echo "Embedding manifest from $@.manifest"; \ + echo 'Embedding manifest from $@.manifest'; \ mt.exe -NOLOGO -MANIFEST $@.manifest -OUTPUTRESOURCE:$@\;1; \ fi; \ - elif test -f "$(srcdir)/$@.manifest"; then \ - echo "Embedding manifest from $(srcdir)/$@.manifest"; \ - mt.exe -NOLOGO -MANIFEST "$(win_srcdir)/$@.manifest" -OUTPUTRESOURCE:$@\;1; \ + elif test -f '$(srcdir)/$@.manifest'; then \ + echo 'Embedding manifest from $(srcdir)/$@.manifest'; \ + mt.exe -NOLOGO -MANIFEST '$(win_srcdir)/$@.manifest' -OUTPUTRESOURCE:$@\;1; \ fi endif # MSVC with manifest tool else @@ -932,7 +932,7 @@ ifdef EMBED_MANIFEST_AT endif # EMBED_MANIFEST_AT endif # MSVC with manifest tool ifdef MOZ_PROFILE_GENERATE - touch -t `date +%Y%m%d%H%M.%S -d "now+5seconds"` pgo.relink + touch -t `date +%Y%m%d%H%M.%S -d 'now+5seconds'` pgo.relink endif endif # WINNT && !GCC @$(RM) foodummyfilefoo $(DELETE_AFTER_LINK) @@ -949,14 +949,14 @@ _MDDEPFILE = $(MDDEPDIR)/$(@F).pp define MAKE_DEPS_AUTO_CC if test -d $(@D); then \ - echo "Building deps for $< using Sun Studio cc"; \ + echo 'Building deps for $< using Sun Studio cc'; \ $(CC) $(COMPILE_CFLAGS) -xM $< >$(_MDDEPFILE) ; \ $(PYTHON) $(topsrcdir)/build/unix/add_phony_targets.py $(_MDDEPFILE) ; \ fi endef define MAKE_DEPS_AUTO_CXX if test -d $(@D); then \ - echo "Building deps for $< using Sun Studio CC"; \ + echo 'Building deps for $< using Sun Studio CC'; \ $(CXX) $(COMPILE_CXXFLAGS) -xM $< >$(_MDDEPFILE) ; \ $(PYTHON) $(topsrcdir)/build/unix/add_phony_targets.py $(_MDDEPFILE) ; \ fi @@ -1103,8 +1103,8 @@ ifeq ($(HOST_OS_ARCH),WINNT) # could be a file or a non-existent path, we cannot call 'pwd -W' directly # on the path. Instead, we extract the root path (i.e. "c:/"), call 'pwd -W' # on it, then merge with the rest of the path. -root-path = $(shell echo $(1) | sed -e "s|\(/[^/]*\)/\?\(.*\)|\1|") -non-root-path = $(shell echo $(1) | sed -e "s|\(/[^/]*\)/\?\(.*\)|\2|") +root-path = $(shell echo $(1) | sed -e 's|\(/[^/]*\)/\?\(.*\)|\1|') +non-root-path = $(shell echo $(1) | sed -e 's|\(/[^/]*\)/\?\(.*\)|\2|') normalizepath = $(foreach p,$(1),$(if $(filter /%,$(1)),$(patsubst %/,%,$(shell cd $(call root-path,$(1)) && pwd -W))/$(call non-root-path,$(1)),$(1))) else normalizepath = $(1) @@ -1178,8 +1178,8 @@ INSTALL_TARGETS += _XPT_NAME ifndef NO_INTERFACES_MANIFEST libs:: $(call mkdir_deps,$(FINAL_TARGET)/components) - $(call py_action,buildlist,$(FINAL_TARGET)/components/interfaces.manifest "interfaces $(XPT_NAME)") - $(call py_action,buildlist,$(FINAL_TARGET)/chrome.manifest "manifest components/interfaces.manifest") + $(call py_action,buildlist,$(FINAL_TARGET)/components/interfaces.manifest 'interfaces $(XPT_NAME)') + $(call py_action,buildlist,$(FINAL_TARGET)/chrome.manifest 'manifest components/interfaces.manifest') endif endif @@ -1215,7 +1215,7 @@ endif EXTRA_MANIFESTS = $(filter %.manifest,$(EXTRA_COMPONENTS) $(EXTRA_PP_COMPONENTS)) ifneq (,$(EXTRA_MANIFESTS)) libs:: $(call mkdir_deps,$(FINAL_TARGET)) - $(call py_action,buildlist,$(FINAL_TARGET)/chrome.manifest $(patsubst %,"manifest components/%",$(notdir $(EXTRA_MANIFESTS)))) + $(call py_action,buildlist,$(FINAL_TARGET)/chrome.manifest $(patsubst %,'manifest components/%',$(notdir $(EXTRA_MANIFESTS)))) endif ################################################################################ @@ -1302,7 +1302,7 @@ ifdef XPI_ROOT_APPID # For add-on packaging we may specify that an application # sub-dir should be added to the root chrome manifest with # a specific application id. -MAKE_JARS_FLAGS += --root-manifest-entry-appid="$(XPI_ROOT_APPID)" +MAKE_JARS_FLAGS += --root-manifest-entry-appid='$(XPI_ROOT_APPID)' endif # if DIST_SUBDIR is defined but XPI_ROOT_APPID is not there's @@ -1339,34 +1339,34 @@ ifneq ($(XPI_PKGNAME),) tools realchrome:: ifdef STRIP_XPI ifndef MOZ_DEBUG - @echo "Stripping $(XPI_PKGNAME) package directory..." + @echo 'Stripping $(XPI_PKGNAME) package directory...' @echo $(FINAL_TARGET) @cd $(FINAL_TARGET) && find . ! -type d \ - ! -name "*.js" \ - ! -name "*.xpt" \ - ! -name "*.gif" \ - ! -name "*.jpg" \ - ! -name "*.png" \ - ! -name "*.xpm" \ - ! -name "*.txt" \ - ! -name "*.rdf" \ - ! -name "*.sh" \ - ! -name "*.properties" \ - ! -name "*.dtd" \ - ! -name "*.html" \ - ! -name "*.xul" \ - ! -name "*.css" \ - ! -name "*.xml" \ - ! -name "*.jar" \ - ! -name "*.dat" \ - ! -name "*.tbl" \ - ! -name "*.src" \ - ! -name "*.reg" \ + ! -name '*.js' \ + ! -name '*.xpt' \ + ! -name '*.gif' \ + ! -name '*.jpg' \ + ! -name '*.png' \ + ! -name '*.xpm' \ + ! -name '*.txt' \ + ! -name '*.rdf' \ + ! -name '*.sh' \ + ! -name '*.properties' \ + ! -name '*.dtd' \ + ! -name '*.html' \ + ! -name '*.xul' \ + ! -name '*.css' \ + ! -name '*.xml' \ + ! -name '*.jar' \ + ! -name '*.dat' \ + ! -name '*.tbl' \ + ! -name '*.src' \ + ! -name '*.reg' \ $(PLATFORM_EXCLUDE_LIST) \ -exec $(STRIP) $(STRIP_FLAGS) {} >/dev/null 2>&1 \; endif endif - @echo "Packaging $(XPI_PKGNAME).xpi..." + @echo 'Packaging $(XPI_PKGNAME).xpi...' cd $(FINAL_TARGET) && $(ZIP) -qr ../$(XPI_PKGNAME).xpi * endif @@ -1376,8 +1376,8 @@ $(error XPI_NAME must be set for INSTALL_EXTENSION_ID) endif tools:: - $(RM) -r "$(DIST)/bin$(DIST_SUBDIR:%=/%)/extensions/$(INSTALL_EXTENSION_ID)" - $(NSINSTALL) -D "$(DIST)/bin$(DIST_SUBDIR:%=/%)/extensions/$(INSTALL_EXTENSION_ID)" + $(RM) -r '$(DIST)/bin$(DIST_SUBDIR:%=/%)/extensions/$(INSTALL_EXTENSION_ID)' + $(NSINSTALL) -D '$(DIST)/bin$(DIST_SUBDIR:%=/%)/extensions/$(INSTALL_EXTENSION_ID)' $(call copy_dir,$(FINAL_TARGET),$(DIST)/bin$(DIST_SUBDIR:%=/%)/extensions/$(INSTALL_EXTENSION_ID)) endif @@ -1499,11 +1499,11 @@ install_targets_sanity = $(if $(filter-out $(notdir $@),$(notdir $(<))),$(error $(sort $(foreach tier,$(INSTALL_TARGETS_TIERS),$(INSTALL_TARGETS_FILES_$(tier)))): $(install_targets_sanity) - $(call install_cmd,$(IFLAGS1) "$<" "$(@D)") + $(call install_cmd,$(IFLAGS1) '$<' '$(@D)') $(sort $(foreach tier,$(INSTALL_TARGETS_TIERS),$(INSTALL_TARGETS_EXECUTABLES_$(tier)))): $(install_targets_sanity) - $(call install_cmd,$(IFLAGS2) "$<" "$(@D)") + $(call install_cmd,$(IFLAGS2) '$<' '$(@D)') ################################################################################ # Preprocessing rules @@ -1564,8 +1564,8 @@ $(foreach tier,$(PP_TARGETS_TIERS), \ PP_TARGETS_ALL_RESULTS := $(sort $(foreach tier,$(PP_TARGETS_TIERS),$(PP_TARGETS_RESULTS_$(tier)))) $(PP_TARGETS_ALL_RESULTS): $(if $(filter-out $(notdir $@),$(notdir $(<:.in=))),$(error Looks like $@ has an unexpected dependency on $< which breaks PP_TARGETS)) - $(RM) "$@" - $(call py_action,preprocessor,--depend $(MDDEPDIR)/$(@F).pp $(PP_TARGET_FLAGS) $(DEFINES) $(ACDEFINES) $(XULPPFLAGS) "$<" -o "$@") + $(RM) '$@' + $(call py_action,preprocessor,--depend $(MDDEPDIR)/$(@F).pp $(PP_TARGET_FLAGS) $(DEFINES) $(ACDEFINES) $(XULPPFLAGS) '$<' -o '$@') # The depfile is based on the filename, and we don't want conflicts. So check # there's only one occurrence of any given filename in PP_TARGETS_ALL_RESULTS. diff --git a/config/tests/src-simple/Makefile.in b/config/tests/src-simple/Makefile.in index b59a0cd68809..3a4d7a6e7577 100644 --- a/config/tests/src-simple/Makefile.in +++ b/config/tests/src-simple/Makefile.in @@ -21,16 +21,16 @@ REF_MANIFEST = $(if $(USE_EXTENSION_MANIFEST),chrome.manifest,test.manifest) check-%:: if test -d $(FINAL_TARGET); then rm -rf $(FINAL_TARGET); fi; $(MAKE) realchrome MOZ_CHROME_FILE_FORMAT=$* - @echo "Comparing manifests..." + @echo 'Comparing manifests...' @if ! sort $(MY_MANIFEST) | diff --text -U 0 $(srcdir)/../$(REF_MANIFEST).$* - ; then \ - echo "TEST-UNEXPECTED-FAIL | config/tests/$(REF_MANIFEST).$* | differing content in manifest!" ; \ + echo 'TEST-UNEXPECTED-FAIL | config/tests/$(REF_MANIFEST).$* | differing content in manifest!' ; \ false; \ fi - @if [ $* = "jar" ]; then \ + @if [ $* = 'jar' ]; then \ $(UNZIP) -d $(FINAL_TARGET)/chrome/test $(FINAL_TARGET)/chrome/test.jar; \ fi - @echo "Comparing packages..." + @echo 'Comparing packages...' @if ! diff -ur $(srcdir)/../ref-simple $(FINAL_TARGET)/chrome/test ; then\ - echo "TEST-UNEXPECTED-FAIL | config/tests/ref-simple | different content in jar" ; \ + echo 'TEST-UNEXPECTED-FAIL | config/tests/ref-simple | different content in jar' ; \ false; \ fi diff --git a/configure.in b/configure.in index ff8d397d6928..221f9b16e490 100644 --- a/configure.in +++ b/configure.in @@ -1706,7 +1706,7 @@ case "$host" in *mingw*) if test -n "$_WIN32_MSVC"; then HOST_AR=lib - HOST_AR_FLAGS='-NOLOGO -OUT:"$@"' + HOST_AR_FLAGS='-NOLOGO -OUT:$@' HOST_CFLAGS="$HOST_CFLAGS -TC -nologo -Fd\$(HOST_PDBFILE)" HOST_RANLIB='echo ranlib' else @@ -2062,7 +2062,7 @@ ia64*-hpux*) AS="$(basename "$AS_BIN")" fi AR='lib' - AR_FLAGS='-NOLOGO -OUT:"$@"' + AR_FLAGS='-NOLOGO -OUT:$@' AR_EXTRACT= RANLIB='echo not_ranlib' STRIP='echo not_strip' diff --git a/gfx/angle/Makefile.in b/gfx/angle/Makefile.in index 3ad767d2125b..e7d95c902c65 100644 --- a/gfx/angle/Makefile.in +++ b/gfx/angle/Makefile.in @@ -22,7 +22,7 @@ ifdef MOZ_ANGLE_RENDERER libs:: ifdef MOZ_D3DCOMPILER_CAB - expand "$(MOZ_D3DCOMPILER_CAB)" -F:$(MOZ_D3DCOMPILER_DLL) "$(DIST)/bin" + expand '$(MOZ_D3DCOMPILER_CAB)' -F:$(MOZ_D3DCOMPILER_DLL) '$(DIST)/bin' endif endif diff --git a/gfx/angle/src/libEGL/Makefile.in b/gfx/angle/src/libEGL/Makefile.in index 2c91d5979e06..172db97d8bce 100644 --- a/gfx/angle/src/libEGL/Makefile.in +++ b/gfx/angle/src/libEGL/Makefile.in @@ -28,7 +28,7 @@ RCFILE = $(srcdir)/libEGL.rc include $(topsrcdir)/config/rules.mk -CXXFLAGS += -I"$(MOZ_DIRECTX_SDK_PATH)/include" +CXXFLAGS += -I'$(MOZ_DIRECTX_SDK_PATH)/include' #OS_LIBS += $(call EXPAND_LIBNAME,dwmapi) @@ -39,8 +39,8 @@ OS_LIBS += -ld3d9 -llibGLESv2 else -EXTRA_DSO_LDOPTS = "$(MOZ_DIRECTX_SDK_PATH)/lib/$(MOZ_DIRECTX_SDK_CPU_SUFFIX)/d3d9.lib" \ - "$(DIST)/lib/libGLESv2.lib" \ +EXTRA_DSO_LDOPTS = '$(MOZ_DIRECTX_SDK_PATH)/lib/$(MOZ_DIRECTX_SDK_CPU_SUFFIX)/d3d9.lib' \ + '$(DIST)/lib/libGLESv2.lib' \ delayimp.lib endif diff --git a/gfx/angle/src/libGLESv2/Makefile.in b/gfx/angle/src/libGLESv2/Makefile.in index feaf3d9d3e3a..fb889c8ab101 100644 --- a/gfx/angle/src/libGLESv2/Makefile.in +++ b/gfx/angle/src/libGLESv2/Makefile.in @@ -44,7 +44,7 @@ RCFILE = $(srcdir)/libGLESv2.rc include $(topsrcdir)/config/rules.mk -CXXFLAGS += -I"$(MOZ_DIRECTX_SDK_PATH)/include" +CXXFLAGS += -I'$(MOZ_DIRECTX_SDK_PATH)/include' ifdef GNU_CC @@ -55,8 +55,8 @@ OS_LIBS += -ld3d9 -ldxguid else -EXTRA_DSO_LDOPTS = "$(MOZ_DIRECTX_SDK_PATH)/lib/$(MOZ_DIRECTX_SDK_CPU_SUFFIX)/d3d9.lib" \ - "$(MOZ_DIRECTX_SDK_PATH)/lib/$(MOZ_DIRECTX_SDK_CPU_SUFFIX)/dxguid.lib" \ +EXTRA_DSO_LDOPTS = '$(MOZ_DIRECTX_SDK_PATH)/lib/$(MOZ_DIRECTX_SDK_CPU_SUFFIX)/d3d9.lib' \ + '$(MOZ_DIRECTX_SDK_PATH)/lib/$(MOZ_DIRECTX_SDK_CPU_SUFFIX)/dxguid.lib' \ delayimp.lib endif diff --git a/ipc/app/Makefile.in b/ipc/app/Makefile.in index 6399fd2b3fb0..2904e5adcfc6 100644 --- a/ipc/app/Makefile.in +++ b/ipc/app/Makefile.in @@ -82,9 +82,9 @@ ifeq (cocoa,$(MOZ_WIDGET_TOOLKIT)) #{ libs:: $(NSINSTALL) -D $(DIST)/bin/$(PROGRAM).app - rsync -a -C --exclude "*.in" $(srcdir)/macbuild/Contents $(DIST)/bin/$(PROGRAM).app - sed -e "s/%PROGRAM%/$(PROGRAM)/" $(srcdir)/macbuild/Contents/Info.plist.in > $(DIST)/bin/$(PROGRAM).app/Contents/Info.plist - sed -e "s/%APP_NAME%/$(MOZ_APP_DISPLAYNAME)/" $(srcdir)/macbuild/Contents/Resources/English.lproj/InfoPlist.strings.in | \ + rsync -a -C --exclude '*.in' $(srcdir)/macbuild/Contents $(DIST)/bin/$(PROGRAM).app + sed -e 's/%PROGRAM%/$(PROGRAM)/' $(srcdir)/macbuild/Contents/Info.plist.in > $(DIST)/bin/$(PROGRAM).app/Contents/Info.plist + sed -e 's/%APP_NAME%/$(MOZ_APP_DISPLAYNAME)/' $(srcdir)/macbuild/Contents/Resources/English.lproj/InfoPlist.strings.in | \ iconv -f UTF-8 -t UTF-16 > $(DIST)/bin/$(PROGRAM).app/Contents/Resources/English.lproj/InfoPlist.strings $(NSINSTALL) -D $(DIST)/bin/$(PROGRAM).app/Contents/MacOS $(NSINSTALL) $(PROGRAM) $(DIST)/bin/$(PROGRAM).app/Contents/MacOS diff --git a/ipc/chromium/Makefile.in b/ipc/chromium/Makefile.in index 21dd07e5e0b5..109e0d18cfa7 100644 --- a/ipc/chromium/Makefile.in +++ b/ipc/chromium/Makefile.in @@ -70,6 +70,6 @@ export-preqs = \ $(NULL) export:: $(export-preqs) - echo "#include " > $(DIST)/third_party/libevent/event.h + echo '#include ' > $(DIST)/third_party/libevent/event.h endif # } diff --git a/js/src/Makefile.in b/js/src/Makefile.in index 4b384cb10092..50b5fc3262cb 100644 --- a/js/src/Makefile.in +++ b/js/src/Makefile.in @@ -16,7 +16,7 @@ endif TOPLEVEL_BUILD := 1 -run_for_side_effects := $(shell echo "MAKE: $(MAKE)") +run_for_side_effects := $(shell echo 'MAKE: $(MAKE)') STATIC_LIBRARY_NAME = js_static LIBS = $(NSPR_LIBS) @@ -141,7 +141,7 @@ MOZILLA_DTRACE_SRC = $(srcdir)/devtools/javascript-trace.d endif backend.RecursiveMakeBackend: - @echo "Build configuration changed. Regenerating backend." + @echo 'Build configuration changed. Regenerating backend.' $(PYTHON) config.status Makefile: backend.RecursiveMakeBackend @@ -172,7 +172,7 @@ EXTRA_DSO_LDOPTS += -Wl,-version-script,symverscript symverscript: symverscript.in $(call py_action,preprocessor, \ - -DVERSION="$(subst -,_,$(LIBRARY_NAME))" $< -o $@) + -DVERSION='$(subst -,_,$(LIBRARY_NAME))' $< -o $@) EXTRA_DEPS += symverscript endif @@ -319,7 +319,7 @@ check:: check-style check-jit-test # --no-extensions is set to skip that test. Remove as soon as possible. check-jstests: RC=0; \ - for f in `echo "$(JITFLAGS)" | tr ',' '\n'`; \ + for f in `echo '$(JITFLAGS)' | tr ',' '\n'`; \ do \ $(wildcard $(RUN_TEST_PROGRAM)) $(PYTHON) -u $(srcdir)/tests/jstests.py \ --tinderbox --no-progress \ @@ -478,20 +478,20 @@ endif # Set the various definitions that will be substituted for js-config # and for the pck-config .pc file. JS_CONFIG_SUBSTITUTIONS=\ - -Dprefix="$(prefix)" \ - -Dexec_prefix="$(exec_prefix)" \ - -Dincludedir="$(includedir)" \ - -Dlibdir="$(libdir)" \ - -DMOZILLA_VERSION="$(MOZILLA_VERSION)" \ - -DLIBRARY_NAME="$(LIBRARY_NAME)" \ - -DJS_CONFIG_LIBS="$(JS_CONFIG_LIBS)" \ - -DJS_CONFIG_MOZ_JS_LIBS="$(JS_CONFIG_MOZ_JS_LIBS)" \ - -DMOZJS_MAJOR_VERSION="$(MOZJS_MAJOR_VERSION)" \ - -DMOZJS_MINOR_VERSION="$(MOZJS_MINOR_VERSION)" \ - -DMOZJS_PATCH_VERSION="$(MOZJS_PATCH_VERSION)" \ - -DMOZJS_ALPHA="$(MOZJS_ALPHA)" \ - -DNSPR_CFLAGS="$(NSPR_CFLAGS)" \ - -DNSPR_PKGCONF_CHECK="$(NSPR_PKGCONF_CHECK)" \ + -Dprefix='$(prefix)' \ + -Dexec_prefix='$(exec_prefix)' \ + -Dincludedir='$(includedir)' \ + -Dlibdir='$(libdir)' \ + -DMOZILLA_VERSION='$(MOZILLA_VERSION)' \ + -DLIBRARY_NAME='$(LIBRARY_NAME)' \ + -DJS_CONFIG_LIBS='$(JS_CONFIG_LIBS)' \ + -DJS_CONFIG_MOZ_JS_LIBS='$(JS_CONFIG_MOZ_JS_LIBS)' \ + -DMOZJS_MAJOR_VERSION='$(MOZJS_MAJOR_VERSION)' \ + -DMOZJS_MINOR_VERSION='$(MOZJS_MINOR_VERSION)' \ + -DMOZJS_PATCH_VERSION='$(MOZJS_PATCH_VERSION)' \ + -DMOZJS_ALPHA='$(MOZJS_ALPHA)' \ + -DNSPR_CFLAGS='$(NSPR_CFLAGS)' \ + -DNSPR_PKGCONF_CHECK='$(NSPR_PKGCONF_CHECK)' \ $(NULL) $(JS_CONFIG_NAME): js-config.in Makefile $(DEPTH)/config/autoconf.mk $(topsrcdir)/config/config.mk $(topsrcdir)/config/rules.mk @@ -573,7 +573,7 @@ ETWProvider.h ETWProvider.rc ETWProvider.mof: ETWProvider.man $(MC) -um -mof $^ ETWProvider.res: ETWProvider.rc - $(RC) -r -i "$(SDKDIR)Include" $^ + $(RC) -r -i '$(SDKDIR)Include' $^ export:: ETWProvider.res diff --git a/js/src/config/config.mk b/js/src/config/config.mk index 6d64b5a4cb3a..7df9552b27d6 100644 --- a/js/src/config/config.mk +++ b/js/src/config/config.mk @@ -811,7 +811,7 @@ endif MERGE_FILES = $(foreach f,$(1),$(call MERGE_FILE,$(f))) ifeq (OS2,$(OS_ARCH)) -RUN_TEST_PROGRAM = $(topsrcdir)/build/os2/test_os2.cmd "$(LIBXUL_DIST)" +RUN_TEST_PROGRAM = $(topsrcdir)/build/os2/test_os2.cmd '$(LIBXUL_DIST)' else ifneq (WINNT,$(OS_ARCH)) RUN_TEST_PROGRAM = $(LIBXUL_DIST)/bin/run-mozilla.sh @@ -848,7 +848,7 @@ EXPAND_MKSHLIB = $(EXPAND_LIBS_EXEC) $(EXPAND_MKSHLIB_ARGS) -- $(MKSHLIB) ifneq (,$(MOZ_LIBSTDCXX_TARGET_VERSION)$(MOZ_LIBSTDCXX_HOST_VERSION)) ifneq ($(OS_ARCH),Darwin) -CHECK_STDCXX = objdump -p $(1) | grep -e 'GLIBCXX_3\.4\.\(9\|[1-9][0-9]\)' > /dev/null && echo "TEST-UNEXPECTED-FAIL | | We don't want these libstdc++ symbols to be used:" && objdump -T $(1) | grep -e 'GLIBCXX_3\.4\.\(9\|[1-9][0-9]\)' && exit 1 || exit 0 +CHECK_STDCXX = objdump -p $(1) | grep -e 'GLIBCXX_3\.4\.\(9\|[1-9][0-9]\)' > /dev/null && echo 'TEST-UNEXPECTED-FAIL | | We do not want these libstdc++ symbols to be used:' && objdump -T $(1) | grep -e 'GLIBCXX_3\.4\.\(9\|[1-9][0-9]\)' && exit 1 || exit 0 endif ifdef MOZ_LIBSTDCXX_TARGET_VERSION diff --git a/js/src/config/makefiles/autotargets.mk b/js/src/config/makefiles/autotargets.mk index f8f0238612c8..16e06fb2a410 100644 --- a/js/src/config/makefiles/autotargets.mk +++ b/js/src/config/makefiles/autotargets.mk @@ -56,18 +56,18 @@ mkdir_deps =$(foreach dir,$(getargv),$(call slash_strip,$(dir)/.mkdir.done)) ####################### %/.mkdir.done: # mkdir -p -p => mkdir -p - $(subst $(space)-p,$(null),$(MKDIR)) -p "$(dir $@)" + $(subst $(space)-p,$(null),$(MKDIR)) -p '$(dir $@)' # Make the timestamp old enough for not being a problem with symbolic links # targets depending on it. Use Jan 3, 1980 to accomodate any timezone where # 198001010000 would translate to something older than FAT epoch. - @$(TOUCH) -t 198001030000 "$@" + @$(TOUCH) -t 198001030000 '$@' # A handful of makefiles are attempting "mkdir dot". # tbpl/valgrind builds are using this target # https://bugzilla.mozilla.org/show_bug.cgi?id=837754 .mkdir.done: - @echo "WARNING: $(MKDIR) -dot- requested by $(MAKE) -C $(CURDIR) $(MAKECMDGOALS)" - @$(TOUCH) -t 198001030000 "$@" + @echo 'WARNING: $(MKDIR) -dot- requested by $(MAKE) -C $(CURDIR) $(MAKECMDGOALS)' + @$(TOUCH) -t 198001030000 '$@' INCLUDED_AUTOTARGETS_MK = 1 endif #} diff --git a/js/src/config/makefiles/target_binaries.mk b/js/src/config/makefiles/target_binaries.mk index 0e8e58a659a4..c2927e6b3478 100644 --- a/js/src/config/makefiles/target_binaries.mk +++ b/js/src/config/makefiles/target_binaries.mk @@ -25,8 +25,8 @@ ifdef IS_COMPONENT $(INSTALL) $(IFLAGS2) $(SHARED_LIBRARY) $(FINAL_TARGET)/components $(ELF_DYNSTR_GC) $(FINAL_TARGET)/components/$(SHARED_LIBRARY) ifndef NO_COMPONENTS_MANIFEST - $(call py_action,buildlist,$(FINAL_TARGET)/chrome.manifest "manifest components/components.manifest") - $(call py_action,buildlist,$(FINAL_TARGET)/components/components.manifest "binary-component $(SHARED_LIBRARY)") + $(call py_action,buildlist,$(FINAL_TARGET)/chrome.manifest 'manifest components/components.manifest') + $(call py_action,buildlist,$(FINAL_TARGET)/components/components.manifest 'binary-component $(SHARED_LIBRARY)') endif endif # IS_COMPONENT endif # SHARED_LIBRARY @@ -109,11 +109,11 @@ BINARIES_INSTALL_TARGETS := $(foreach category,$(INSTALL_TARGETS),$(if $(filter BINARIES_PP := $(MDDEPDIR)/binaries.pp $(BINARIES_PP): Makefile $(wildcard backend.mk) $(call mkdir_deps,$(MDDEPDIR)) - @echo "$(strip $(foreach category,$(BINARIES_INSTALL_TARGETS),\ + @echo '$(strip $(foreach category,$(BINARIES_INSTALL_TARGETS),\ $(foreach file,$($(category)_FILES) $($(category)_EXECUTABLES),\ $($(category)_DEST)/$(notdir $(file)): $(file)%\ )\ - ))binaries: Makefile $(wildcard backend.mk)" | tr % '\n' > $@ + ))binaries: Makefile $(wildcard backend.mk)' | tr % '\n' > $@ else binaries:: diff --git a/js/src/config/recurse.mk b/js/src/config/recurse.mk index 2969441bb8d2..07dfa9d51e28 100644 --- a/js/src/config/recurse.mk +++ b/js/src/config/recurse.mk @@ -129,7 +129,7 @@ recurse_$(CURRENT_TIER): # Creating binaries-deps.mk directly would make us build it twice: once when beginning # the build because of the include, and once at the end because of the stamps. binaries-deps: $(addsuffix /binaries,$(CURRENT_DIRS)) - @$(call py_action,link_deps,-o $@.mk --group-by-depfile --topsrcdir $(topsrcdir) --topobjdir $(DEPTH) --dist $(DIST) --guard $(addprefix ",$(addsuffix ",$^))) + @$(call py_action,link_deps,-o $@.mk --group-by-depfile --topsrcdir $(topsrcdir) --topobjdir $(DEPTH) --dist $(DIST) --guard $(addprefix ',$(addsuffix ',$^))) @$(TOUCH) $@ ifeq (recurse_binaries,$(MAKECMDGOALS)) diff --git a/js/src/config/rules.mk b/js/src/config/rules.mk index 39cc75b4ff4f..9f8d932c0888 100644 --- a/js/src/config/rules.mk +++ b/js/src/config/rules.mk @@ -129,7 +129,7 @@ check:: cppunittests-remote: DM_TRANS?=adb cppunittests-remote: - @if [ "${TEST_DEVICE}" != "" -o "$(DM_TRANS)" = "adb" ]; then \ + @if [ '${TEST_DEVICE}' != '' -o '$(DM_TRANS)' = 'adb' ]; then \ $(PYTHON) -u $(topsrcdir)/testing/remotecppunittests.py \ --xre-path=$(DEPTH)/dist/bin \ --localLib=$(DEPTH)/dist/$(MOZ_APP_NAME) \ @@ -137,7 +137,7 @@ cppunittests-remote: --deviceIP=${TEST_DEVICE} \ $(subst .cpp,$(BIN_SUFFIX),$(CPP_UNIT_TESTS)) $(EXTRA_TEST_ARGS); \ else \ - echo "please prepare your host with environment variables for TEST_DEVICE"; \ + echo 'please prepare your host with environment variables for TEST_DEVICE'; \ fi endif # COMPILE_ENVIRONMENT @@ -364,13 +364,13 @@ ifdef MOZ_UPDATE_XTERM # Its good not to have a newline at the end of the titlebar string because it # makes the make -s output easier to read. Echo -n does not work on all # platforms, but we can trick printf into doing it. -UPDATE_TITLE = printf "\033]0;%s in %s\007" $(1) $(relativesrcdir)/$(2) ; +UPDATE_TITLE = printf '\033]0;%s in %s\007' $(1) $(relativesrcdir)/$(2) ; endif ifdef MACH ifndef NO_BUILDSTATUS_MESSAGES define BUILDSTATUS -@echo "BUILDSTATUS $1" +@echo 'BUILDSTATUS $1' endef endif @@ -743,22 +743,22 @@ ifeq (_WINNT,$(GNU_CC)_$(OS_ARCH)) $(EXPAND_LD) -NOLOGO -OUT:$@ -PDB:$(LINK_PDBFILE) $(WIN32_EXE_LDFLAGS) $(LDFLAGS) $(MOZ_GLUE_PROGRAM_LDFLAGS) $(PROGOBJS) $(RESFILE) $(LIBS) $(EXTRA_LIBS) $(OS_LIBS) ifdef MSMANIFEST_TOOL @if test -f $@.manifest; then \ - if test -f "$(srcdir)/$@.manifest"; then \ - echo "Embedding manifest from $(srcdir)/$@.manifest and $@.manifest"; \ - mt.exe -NOLOGO -MANIFEST "$(win_srcdir)/$@.manifest" $@.manifest -OUTPUTRESOURCE:$@\;1; \ + if test -f '$(srcdir)/$@.manifest'; then \ + echo 'Embedding manifest from $(srcdir)/$@.manifest and $@.manifest'; \ + mt.exe -NOLOGO -MANIFEST '$(win_srcdir)/$@.manifest' $@.manifest -OUTPUTRESOURCE:$@\;1; \ else \ - echo "Embedding manifest from $@.manifest"; \ + echo 'Embedding manifest from $@.manifest'; \ mt.exe -NOLOGO -MANIFEST $@.manifest -OUTPUTRESOURCE:$@\;1; \ fi; \ - elif test -f "$(srcdir)/$@.manifest"; then \ - echo "Embedding manifest from $(srcdir)/$@.manifest"; \ - mt.exe -NOLOGO -MANIFEST "$(win_srcdir)/$@.manifest" -OUTPUTRESOURCE:$@\;1; \ + elif test -f '$(srcdir)/$@.manifest'; then \ + echo 'Embedding manifest from $(srcdir)/$@.manifest'; \ + mt.exe -NOLOGO -MANIFEST '$(win_srcdir)/$@.manifest' -OUTPUTRESOURCE:$@\;1; \ fi endif # MSVC with manifest tool ifdef MOZ_PROFILE_GENERATE # touch it a few seconds into the future to work around FAT's # 2-second granularity - touch -t `date +%Y%m%d%H%M.%S -d "now+5seconds"` pgo.relink + touch -t `date +%Y%m%d%H%M.%S -d 'now+5seconds'` pgo.relink endif else # !WINNT || GNU_CC $(EXPAND_CCC) -o $@ $(CXXFLAGS) $(PROGOBJS) $(RESFILE) $(WIN32_EXE_LDFLAGS) $(LDFLAGS) $(WRAP_LDFLAGS) $(LIBS_DIR) $(LIBS) $(MOZ_GLUE_PROGRAM_LDFLAGS) $(OS_LIBS) $(EXTRA_LIBS) $(BIN_FLAGS) $(EXE_DEF_FILE) $(STLPORT_LIBS) @@ -778,16 +778,16 @@ ifeq (_WINNT,$(GNU_CC)_$(HOST_OS_ARCH)) $(EXPAND_LIBS_EXEC) -- $(HOST_LD) -NOLOGO -OUT:$@ -PDB:$(HOST_PDBFILE) $(HOST_OBJS) $(WIN32_EXE_LDFLAGS) $(HOST_LDFLAGS) $(HOST_LIBS) $(HOST_EXTRA_LIBS) ifdef MSMANIFEST_TOOL @if test -f $@.manifest; then \ - if test -f "$(srcdir)/$@.manifest"; then \ - echo "Embedding manifest from $(srcdir)/$@.manifest and $@.manifest"; \ - mt.exe -NOLOGO -MANIFEST "$(win_srcdir)/$@.manifest" $@.manifest -OUTPUTRESOURCE:$@\;1; \ + if test -f '$(srcdir)/$@.manifest'; then \ + echo 'Embedding manifest from $(srcdir)/$@.manifest and $@.manifest'; \ + mt.exe -NOLOGO -MANIFEST '$(win_srcdir)/$@.manifest' $@.manifest -OUTPUTRESOURCE:$@\;1; \ else \ - echo "Embedding manifest from $@.manifest"; \ + echo 'Embedding manifest from $@.manifest'; \ mt.exe -NOLOGO -MANIFEST $@.manifest -OUTPUTRESOURCE:$@\;1; \ fi; \ - elif test -f "$(srcdir)/$@.manifest"; then \ - echo "Embedding manifest from $(srcdir)/$@.manifest"; \ - mt.exe -NOLOGO -MANIFEST "$(win_srcdir)/$@.manifest" -OUTPUTRESOURCE:$@\;1; \ + elif test -f '$(srcdir)/$@.manifest'; then \ + echo 'Embedding manifest from $(srcdir)/$@.manifest'; \ + mt.exe -NOLOGO -MANIFEST '$(win_srcdir)/$@.manifest' -OUTPUTRESOURCE:$@\;1; \ fi endif # MSVC with manifest tool else @@ -932,7 +932,7 @@ ifdef EMBED_MANIFEST_AT endif # EMBED_MANIFEST_AT endif # MSVC with manifest tool ifdef MOZ_PROFILE_GENERATE - touch -t `date +%Y%m%d%H%M.%S -d "now+5seconds"` pgo.relink + touch -t `date +%Y%m%d%H%M.%S -d 'now+5seconds'` pgo.relink endif endif # WINNT && !GCC @$(RM) foodummyfilefoo $(DELETE_AFTER_LINK) @@ -949,14 +949,14 @@ _MDDEPFILE = $(MDDEPDIR)/$(@F).pp define MAKE_DEPS_AUTO_CC if test -d $(@D); then \ - echo "Building deps for $< using Sun Studio cc"; \ + echo 'Building deps for $< using Sun Studio cc'; \ $(CC) $(COMPILE_CFLAGS) -xM $< >$(_MDDEPFILE) ; \ $(PYTHON) $(topsrcdir)/build/unix/add_phony_targets.py $(_MDDEPFILE) ; \ fi endef define MAKE_DEPS_AUTO_CXX if test -d $(@D); then \ - echo "Building deps for $< using Sun Studio CC"; \ + echo 'Building deps for $< using Sun Studio CC'; \ $(CXX) $(COMPILE_CXXFLAGS) -xM $< >$(_MDDEPFILE) ; \ $(PYTHON) $(topsrcdir)/build/unix/add_phony_targets.py $(_MDDEPFILE) ; \ fi @@ -1103,8 +1103,8 @@ ifeq ($(HOST_OS_ARCH),WINNT) # could be a file or a non-existent path, we cannot call 'pwd -W' directly # on the path. Instead, we extract the root path (i.e. "c:/"), call 'pwd -W' # on it, then merge with the rest of the path. -root-path = $(shell echo $(1) | sed -e "s|\(/[^/]*\)/\?\(.*\)|\1|") -non-root-path = $(shell echo $(1) | sed -e "s|\(/[^/]*\)/\?\(.*\)|\2|") +root-path = $(shell echo $(1) | sed -e 's|\(/[^/]*\)/\?\(.*\)|\1|') +non-root-path = $(shell echo $(1) | sed -e 's|\(/[^/]*\)/\?\(.*\)|\2|') normalizepath = $(foreach p,$(1),$(if $(filter /%,$(1)),$(patsubst %/,%,$(shell cd $(call root-path,$(1)) && pwd -W))/$(call non-root-path,$(1)),$(1))) else normalizepath = $(1) @@ -1178,8 +1178,8 @@ INSTALL_TARGETS += _XPT_NAME ifndef NO_INTERFACES_MANIFEST libs:: $(call mkdir_deps,$(FINAL_TARGET)/components) - $(call py_action,buildlist,$(FINAL_TARGET)/components/interfaces.manifest "interfaces $(XPT_NAME)") - $(call py_action,buildlist,$(FINAL_TARGET)/chrome.manifest "manifest components/interfaces.manifest") + $(call py_action,buildlist,$(FINAL_TARGET)/components/interfaces.manifest 'interfaces $(XPT_NAME)') + $(call py_action,buildlist,$(FINAL_TARGET)/chrome.manifest 'manifest components/interfaces.manifest') endif endif @@ -1215,7 +1215,7 @@ endif EXTRA_MANIFESTS = $(filter %.manifest,$(EXTRA_COMPONENTS) $(EXTRA_PP_COMPONENTS)) ifneq (,$(EXTRA_MANIFESTS)) libs:: $(call mkdir_deps,$(FINAL_TARGET)) - $(call py_action,buildlist,$(FINAL_TARGET)/chrome.manifest $(patsubst %,"manifest components/%",$(notdir $(EXTRA_MANIFESTS)))) + $(call py_action,buildlist,$(FINAL_TARGET)/chrome.manifest $(patsubst %,'manifest components/%',$(notdir $(EXTRA_MANIFESTS)))) endif ################################################################################ @@ -1302,7 +1302,7 @@ ifdef XPI_ROOT_APPID # For add-on packaging we may specify that an application # sub-dir should be added to the root chrome manifest with # a specific application id. -MAKE_JARS_FLAGS += --root-manifest-entry-appid="$(XPI_ROOT_APPID)" +MAKE_JARS_FLAGS += --root-manifest-entry-appid='$(XPI_ROOT_APPID)' endif # if DIST_SUBDIR is defined but XPI_ROOT_APPID is not there's @@ -1339,34 +1339,34 @@ ifneq ($(XPI_PKGNAME),) tools realchrome:: ifdef STRIP_XPI ifndef MOZ_DEBUG - @echo "Stripping $(XPI_PKGNAME) package directory..." + @echo 'Stripping $(XPI_PKGNAME) package directory...' @echo $(FINAL_TARGET) @cd $(FINAL_TARGET) && find . ! -type d \ - ! -name "*.js" \ - ! -name "*.xpt" \ - ! -name "*.gif" \ - ! -name "*.jpg" \ - ! -name "*.png" \ - ! -name "*.xpm" \ - ! -name "*.txt" \ - ! -name "*.rdf" \ - ! -name "*.sh" \ - ! -name "*.properties" \ - ! -name "*.dtd" \ - ! -name "*.html" \ - ! -name "*.xul" \ - ! -name "*.css" \ - ! -name "*.xml" \ - ! -name "*.jar" \ - ! -name "*.dat" \ - ! -name "*.tbl" \ - ! -name "*.src" \ - ! -name "*.reg" \ + ! -name '*.js' \ + ! -name '*.xpt' \ + ! -name '*.gif' \ + ! -name '*.jpg' \ + ! -name '*.png' \ + ! -name '*.xpm' \ + ! -name '*.txt' \ + ! -name '*.rdf' \ + ! -name '*.sh' \ + ! -name '*.properties' \ + ! -name '*.dtd' \ + ! -name '*.html' \ + ! -name '*.xul' \ + ! -name '*.css' \ + ! -name '*.xml' \ + ! -name '*.jar' \ + ! -name '*.dat' \ + ! -name '*.tbl' \ + ! -name '*.src' \ + ! -name '*.reg' \ $(PLATFORM_EXCLUDE_LIST) \ -exec $(STRIP) $(STRIP_FLAGS) {} >/dev/null 2>&1 \; endif endif - @echo "Packaging $(XPI_PKGNAME).xpi..." + @echo 'Packaging $(XPI_PKGNAME).xpi...' cd $(FINAL_TARGET) && $(ZIP) -qr ../$(XPI_PKGNAME).xpi * endif @@ -1376,8 +1376,8 @@ $(error XPI_NAME must be set for INSTALL_EXTENSION_ID) endif tools:: - $(RM) -r "$(DIST)/bin$(DIST_SUBDIR:%=/%)/extensions/$(INSTALL_EXTENSION_ID)" - $(NSINSTALL) -D "$(DIST)/bin$(DIST_SUBDIR:%=/%)/extensions/$(INSTALL_EXTENSION_ID)" + $(RM) -r '$(DIST)/bin$(DIST_SUBDIR:%=/%)/extensions/$(INSTALL_EXTENSION_ID)' + $(NSINSTALL) -D '$(DIST)/bin$(DIST_SUBDIR:%=/%)/extensions/$(INSTALL_EXTENSION_ID)' $(call copy_dir,$(FINAL_TARGET),$(DIST)/bin$(DIST_SUBDIR:%=/%)/extensions/$(INSTALL_EXTENSION_ID)) endif @@ -1499,11 +1499,11 @@ install_targets_sanity = $(if $(filter-out $(notdir $@),$(notdir $(<))),$(error $(sort $(foreach tier,$(INSTALL_TARGETS_TIERS),$(INSTALL_TARGETS_FILES_$(tier)))): $(install_targets_sanity) - $(call install_cmd,$(IFLAGS1) "$<" "$(@D)") + $(call install_cmd,$(IFLAGS1) '$<' '$(@D)') $(sort $(foreach tier,$(INSTALL_TARGETS_TIERS),$(INSTALL_TARGETS_EXECUTABLES_$(tier)))): $(install_targets_sanity) - $(call install_cmd,$(IFLAGS2) "$<" "$(@D)") + $(call install_cmd,$(IFLAGS2) '$<' '$(@D)') ################################################################################ # Preprocessing rules @@ -1564,8 +1564,8 @@ $(foreach tier,$(PP_TARGETS_TIERS), \ PP_TARGETS_ALL_RESULTS := $(sort $(foreach tier,$(PP_TARGETS_TIERS),$(PP_TARGETS_RESULTS_$(tier)))) $(PP_TARGETS_ALL_RESULTS): $(if $(filter-out $(notdir $@),$(notdir $(<:.in=))),$(error Looks like $@ has an unexpected dependency on $< which breaks PP_TARGETS)) - $(RM) "$@" - $(call py_action,preprocessor,--depend $(MDDEPDIR)/$(@F).pp $(PP_TARGET_FLAGS) $(DEFINES) $(ACDEFINES) $(XULPPFLAGS) "$<" -o "$@") + $(RM) '$@' + $(call py_action,preprocessor,--depend $(MDDEPDIR)/$(@F).pp $(PP_TARGET_FLAGS) $(DEFINES) $(ACDEFINES) $(XULPPFLAGS) '$<' -o '$@') # The depfile is based on the filename, and we don't want conflicts. So check # there's only one occurrence of any given filename in PP_TARGETS_ALL_RESULTS. diff --git a/js/src/configure.in b/js/src/configure.in index a5a601873cfd..631eef9807e7 100644 --- a/js/src/configure.in +++ b/js/src/configure.in @@ -1320,7 +1320,7 @@ case "$host" in *mingw*) if test -n "$_WIN32_MSVC"; then HOST_AR=lib - HOST_AR_FLAGS='-NOLOGO -OUT:"$@"' + HOST_AR_FLAGS='-NOLOGO -OUT:$@' HOST_CFLAGS="$HOST_CFLAGS -TC -nologo -Fd\$(HOST_PDBFILE)" HOST_RANLIB='echo ranlib' else @@ -1619,7 +1619,7 @@ ia64*-hpux*) AS="$(basename "$AS_BIN")" fi AR='lib' - AR_FLAGS='-NOLOGO -OUT:"$@"' + AR_FLAGS='-NOLOGO -OUT:$@' AR_EXTRACT= RANLIB='echo not_ranlib' STRIP='echo not_strip' diff --git a/js/src/ctypes/libffi/Makefile.in b/js/src/ctypes/libffi/Makefile.in index bc5902700a04..614246f42f00 100644 --- a/js/src/ctypes/libffi/Makefile.in +++ b/js/src/ctypes/libffi/Makefile.in @@ -433,39 +433,39 @@ info_TEXINFOS = doc/libffi.texi # values defined in terms of make variables, as is the case for CC and # friends when we are called from the top level Makefile. AM_MAKEFLAGS = \ - "AR_FLAGS=$(AR_FLAGS)" \ - "CC_FOR_BUILD=$(CC_FOR_BUILD)" \ - "CFLAGS=$(CFLAGS)" \ - "CXXFLAGS=$(CXXFLAGS)" \ - "CFLAGS_FOR_BUILD=$(CFLAGS_FOR_BUILD)" \ - "CFLAGS_FOR_TARGET=$(CFLAGS_FOR_TARGET)" \ - "INSTALL=$(INSTALL)" \ - "INSTALL_DATA=$(INSTALL_DATA)" \ - "INSTALL_PROGRAM=$(INSTALL_PROGRAM)" \ - "INSTALL_SCRIPT=$(INSTALL_SCRIPT)" \ - "JC1FLAGS=$(JC1FLAGS)" \ - "LDFLAGS=$(LDFLAGS)" \ - "LIBCFLAGS=$(LIBCFLAGS)" \ - "LIBCFLAGS_FOR_TARGET=$(LIBCFLAGS_FOR_TARGET)" \ - "MAKE=$(MAKE)" \ - "MAKEINFO=$(MAKEINFO) $(MAKEINFOFLAGS)" \ - "PICFLAG=$(PICFLAG)" \ - "PICFLAG_FOR_TARGET=$(PICFLAG_FOR_TARGET)" \ - "RUNTESTFLAGS=$(RUNTESTFLAGS)" \ - "SHELL=$(SHELL)" \ - "exec_prefix=$(exec_prefix)" \ - "infodir=$(infodir)" \ - "libdir=$(libdir)" \ - "mandir=$(mandir)" \ - "prefix=$(prefix)" \ - "AR=$(AR)" \ - "AS=$(AS)" \ - "CC=$(CC)" \ - "CXX=$(CXX)" \ - "LD=$(LD)" \ - "NM=$(NM)" \ - "RANLIB=$(RANLIB)" \ - "DESTDIR=$(DESTDIR)" + 'AR_FLAGS=$(AR_FLAGS)' \ + 'CC_FOR_BUILD=$(CC_FOR_BUILD)' \ + 'CFLAGS=$(CFLAGS)' \ + 'CXXFLAGS=$(CXXFLAGS)' \ + 'CFLAGS_FOR_BUILD=$(CFLAGS_FOR_BUILD)' \ + 'CFLAGS_FOR_TARGET=$(CFLAGS_FOR_TARGET)' \ + 'INSTALL=$(INSTALL)' \ + 'INSTALL_DATA=$(INSTALL_DATA)' \ + 'INSTALL_PROGRAM=$(INSTALL_PROGRAM)' \ + 'INSTALL_SCRIPT=$(INSTALL_SCRIPT)' \ + 'JC1FLAGS=$(JC1FLAGS)' \ + 'LDFLAGS=$(LDFLAGS)' \ + 'LIBCFLAGS=$(LIBCFLAGS)' \ + 'LIBCFLAGS_FOR_TARGET=$(LIBCFLAGS_FOR_TARGET)' \ + 'MAKE=$(MAKE)' \ + 'MAKEINFO=$(MAKEINFO) $(MAKEINFOFLAGS)' \ + 'PICFLAG=$(PICFLAG)' \ + 'PICFLAG_FOR_TARGET=$(PICFLAG_FOR_TARGET)' \ + 'RUNTESTFLAGS=$(RUNTESTFLAGS)' \ + 'SHELL=$(SHELL)' \ + 'exec_prefix=$(exec_prefix)' \ + 'infodir=$(infodir)' \ + 'libdir=$(libdir)' \ + 'mandir=$(mandir)' \ + 'prefix=$(prefix)' \ + 'AR=$(AR)' \ + 'AS=$(AS)' \ + 'CC=$(CC)' \ + 'CXX=$(CXX)' \ + 'LD=$(LD)' \ + 'NM=$(NM)' \ + 'RANLIB=$(RANLIB)' \ + 'DESTDIR=$(DESTDIR)' MAKEOVERRIDES = ACLOCAL_AMFLAGS = $(ACLOCAL_AMFLAGS) -I m4 diff --git a/js/src/devtools/rootAnalysis/Makefile.in b/js/src/devtools/rootAnalysis/Makefile.in index 3df258543ab6..3249e4095876 100644 --- a/js/src/devtools/rootAnalysis/Makefile.in +++ b/js/src/devtools/rootAnalysis/Makefile.in @@ -76,6 +76,6 @@ allFunctions.txt: src_body.xdb rootingHazards.txt: gcFunctions.lst suppressedFunctions.lst gcTypes.txt analyzeRoots.js annotations.js gen-hazards.sh @echo Started computation of $@ at $$(date) - time env JS=$(JS) ANALYZE="$(ANALYSIS_SCRIPT_DIR)/analyzeRoots.js" SIXGILL="$(SIXGILL)" "$(ANALYSIS_SCRIPT_DIR)/gen-hazards.sh" $(JOBS) > $@.tmp + time env JS=$(JS) ANALYZE='$(ANALYSIS_SCRIPT_DIR)/analyzeRoots.js' SIXGILL='$(SIXGILL)' '$(ANALYSIS_SCRIPT_DIR)/gen-hazards.sh' $(JOBS) > $@.tmp mv $@.tmp $@ @echo Finished computation of $@ at $$(date) diff --git a/media/webrtc/trunk/tools/gyp/pylib/gyp/generator/mozmake.py b/media/webrtc/trunk/tools/gyp/pylib/gyp/generator/mozmake.py index f14fe58590f2..482d38e9cc6e 100644 --- a/media/webrtc/trunk/tools/gyp/pylib/gyp/generator/mozmake.py +++ b/media/webrtc/trunk/tools/gyp/pylib/gyp/generator/mozmake.py @@ -75,7 +75,7 @@ ifeq (WINNT,$(OS_TARGET)) # These get set via VC project file settings for normal GYP builds. DEFINES += -DUNICODE -D_UNICODE -LOCAL_INCLUDES += -I"$(MOZ_DIRECTX_SDK_PATH)/include" +LOCAL_INCLUDES += -I'$(MOZ_DIRECTX_SDK_PATH)/include' endif # Don't use STL wrappers when compiling Google code. @@ -97,7 +97,7 @@ define COPY_SRC $(notdir $(1)): $(1) - $$(INSTALL) $$(IFLAGS1) "$$<" . + $$(INSTALL) $$(IFLAGS1) '$$<' . endef # COPY_SRC ifdef COPY_SRCS diff --git a/mobile/android/base/Makefile.in b/mobile/android/base/Makefile.in index 4067cf6a1098..cbc56cd48060 100644 --- a/mobile/android/base/Makefile.in +++ b/mobile/android/base/Makefile.in @@ -87,7 +87,7 @@ include $(topsrcdir)/config/config.mk # because Android resource classes must be compiled together in order to avoid overlapping resource # indices. classes.dex: $(ALL_JARS) - @echo "DX classes.dex" + @echo 'DX classes.dex' $(DX) --dex --output=classes.dex $(ALL_JARS) $(ANDROID_COMPAT_LIB) CLASSES_WITH_JNI= \ @@ -179,7 +179,7 @@ $(call mkdir_deps,$(ANDROID_RESDIRS)): $(ANDROID_RESFILES) Makefile $(TOUCH) $@ $(subst resources/,res/,$(ANDROID_RESFILES)): $(call mkdir_deps,$(ANDROID_RESDIRS)) $(ANDROID_RESFILES) - @echo "creating $@" + @echo 'creating $@' $(NSINSTALL) $(subst res/,$(srcdir)/resources/,$@) $(dir $@) res/values/strings.xml: $(call mkdir_deps,res/values) @@ -222,4 +222,4 @@ include $(topsrcdir)/config/android-common.mk libs:: classes.dex jni-stubs.inc GeneratedJNIWrappers.cpp fennec_ids.txt $(INSTALL) classes.dex $(FINAL_TARGET) @(diff jni-stubs.inc $(topsrcdir)/mozglue/android/jni-stubs.inc >/dev/null && diff GeneratedJNIWrappers.cpp $(topsrcdir)/widget/android/GeneratedJNIWrappers.cpp >/dev/null) || \ - (echo "*** Error: The generated JNI code has changed. Please run cp $(CURDIR)/jni-stubs.inc $(topsrcdir)/mozglue/android && cp $(CURDIR)/GeneratedJNIWrappers.* $(topsrcdir)/widget/android and repeat the build." && exit 1) + (echo '*** Error: The generated JNI code has changed. Please run cp $(CURDIR)/jni-stubs.inc $(topsrcdir)/mozglue/android && cp $(CURDIR)/GeneratedJNIWrappers.* $(topsrcdir)/widget/android and repeat the build.' && exit 1) diff --git a/mobile/android/base/locales/Makefile.in b/mobile/android/base/locales/Makefile.in index acbb04cb5268..a568593eedc6 100644 --- a/mobile/android/base/locales/Makefile.in +++ b/mobile/android/base/locales/Makefile.in @@ -65,11 +65,11 @@ $(dir-strings-xml)/strings.xml: $(strings-xml-preqs) $(call py_action,preprocessor, \ $(DEFINES) \ -DANDROID_PACKAGE_NAME=$(ANDROID_PACKAGE_NAME) \ - -DBOOKMARKSPATH="$(BOOKMARKSPATH)" \ - -DBRANDPATH="$(BRANDPATH)" \ + -DBOOKMARKSPATH='$(BOOKMARKSPATH)' \ + -DBRANDPATH='$(BRANDPATH)' \ -DMOZ_ANDROID_SHARED_ACCOUNT_TYPE=$(MOZ_ANDROID_SHARED_ACCOUNT_TYPE) \ - -DMOZ_APP_DISPLAYNAME="@MOZ_APP_DISPLAYNAME@" \ - -DSTRINGSPATH="$(STRINGSPATH)" \ - -DSYNCSTRINGSPATH="$(SYNCSTRINGSPATH)" \ + -DMOZ_APP_DISPLAYNAME='@MOZ_APP_DISPLAYNAME@' \ + -DSTRINGSPATH='$(STRINGSPATH)' \ + -DSYNCSTRINGSPATH='$(SYNCSTRINGSPATH)' \ $< \ -o $@) diff --git a/mobile/android/build.mk b/mobile/android/build.mk index e207365e7cd2..e4069388a349 100644 --- a/mobile/android/build.mk +++ b/mobile/android/build.mk @@ -24,12 +24,12 @@ else android_devices=$(filter device,$(shell $(ADB) devices)) ifeq ($(android_devices),) install:: - @echo "No devices are connected. Connect a device or start an emulator." + @echo 'No devices are connected. Connect a device or start an emulator.' @exit 1 else ifneq ($(android_devices),device) install:: - @echo "Multiple devices are connected. Define ANDROID_SERIAL to specify the install target." + @echo 'Multiple devices are connected. Define ANDROID_SERIAL to specify the install target.' $(ADB) devices @exit 1 endif @@ -39,7 +39,7 @@ endif install:: $(ADB) install -r $(DIST)/$(PKG_PATH)$(PKG_BASENAME).apk else - @echo "Mobile can't be installed directly." + @echo 'Mobile can't be installed directly.' @exit 1 endif diff --git a/mobile/android/defs.mk b/mobile/android/defs.mk index dc9767f6e9d7..78ab6d092381 100644 --- a/mobile/android/defs.mk +++ b/mobile/android/defs.mk @@ -1,18 +1,18 @@ -MOZ_ANDROID_SHARED_ID = "$(ANDROID_PACKAGE_NAME).sharedID" -MOZ_ANDROID_SHARED_ACCOUNT_TYPE = "$(ANDROID_PACKAGE_NAME)_sync" +MOZ_ANDROID_SHARED_ID = $(ANDROID_PACKAGE_NAME).sharedID +MOZ_ANDROID_SHARED_ACCOUNT_TYPE = $(ANDROID_PACKAGE_NAME)_sync # We released these builds to the public with shared IDs and need to # keep them consistent. ifeq (org.mozilla.firefox,$(ANDROID_PACKAGE_NAME)) -MOZ_ANDROID_SHARED_ID = "org.mozilla.firefox.sharedID" -MOZ_ANDROID_SHARED_ACCOUNT_TYPE = "org.mozilla.firefox_sync" +MOZ_ANDROID_SHARED_ID = org.mozilla.firefox.sharedID +MOZ_ANDROID_SHARED_ACCOUNT_TYPE = org.mozilla.firefox_sync else ifeq (org.mozilla.firefox_beta,$(ANDROID_PACKAGE_NAME)) -MOZ_ANDROID_SHARED_ID = "org.mozilla.firefox.sharedID" -MOZ_ANDROID_SHARED_ACCOUNT_TYPE = "org.mozilla.firefox_sync" +MOZ_ANDROID_SHARED_ID = org.mozilla.firefox.sharedID +MOZ_ANDROID_SHARED_ACCOUNT_TYPE = org.mozilla.firefox_sync else ifeq (org.mozilla.fennec_aurora,$(ANDROID_PACKAGE_NAME)) -MOZ_ANDROID_SHARED_ID = "org.mozilla.fennec.sharedID" -MOZ_ANDROID_SHARED_ACCOUNT_TYPE = "org.mozilla.fennec_sync" +MOZ_ANDROID_SHARED_ID = org.mozilla.fennec.sharedID +MOZ_ANDROID_SHARED_ACCOUNT_TYPE = org.mozilla.fennec_sync else ifeq (org.mozilla.fennec,$(ANDROID_PACKAGE_NAME)) -MOZ_ANDROID_SHARED_ID = "org.mozilla.fennec.sharedID" -MOZ_ANDROID_SHARED_ACCOUNT_TYPE = "org.mozilla.fennec_sync" +MOZ_ANDROID_SHARED_ID = org.mozilla.fennec.sharedID +MOZ_ANDROID_SHARED_ACCOUNT_TYPE = org.mozilla.fennec_sync endif diff --git a/mobile/android/installer/Makefile.in b/mobile/android/installer/Makefile.in index 1c982726412e..399488e058f3 100644 --- a/mobile/android/installer/Makefile.in +++ b/mobile/android/installer/Makefile.in @@ -49,11 +49,11 @@ ifdef MOZ_PKG_MANIFEST_P $(MOZ_PKG_MANIFEST): $(MOZ_PKG_MANIFEST_P) $(GLOBAL_DEPS) $(call py_action,preprocessor,$(DEFINES) $(ACDEFINES) $< -o $@) ifdef MOZ_CHROME_MULTILOCALE - printf "\n[multilocale]\n" >> $@ + printf '\n[multilocale]\n' >> $@ for LOCALE in en-US $(MOZ_CHROME_MULTILOCALE) ;\ do \ - printf "$(BINPATH)/chrome/$$LOCALE$(JAREXT)\n" >> $@; \ - printf "$(BINPATH)/chrome/$$LOCALE.manifest\n" >> $@; \ + printf '$(BINPATH)/chrome/$$LOCALE$(JAREXT)\n' >> $@; \ + printf '$(BINPATH)/chrome/$$LOCALE.manifest\n' >> $@; \ done endif diff --git a/mobile/android/locales/Makefile.in b/mobile/android/locales/Makefile.in index d38cfe357c52..56bbc6e3cb92 100644 --- a/mobile/android/locales/Makefile.in +++ b/mobile/android/locales/Makefile.in @@ -54,32 +54,32 @@ endif # builds. It is called from the tinderbox scripts. Alter it with caution. installers-%: clobber-stage repackage-zip-% - @echo "repackaging done" + @echo 'repackaging done' # When we unpack fennec on MacOS X the platform.ini and application.ini are in slightly # different locations that on all other platforms ifeq (Darwin, $(OS_ARCH)) ifdef LIBXUL_SDK -GECKO_PLATFORM_INI_PATH="$(STAGEDIST)/../Frameworks/XUL.framework/Versions/$(MOZILLA_VERSION)/platform.ini" +GECKO_PLATFORM_INI_PATH='$(STAGEDIST)/../Frameworks/XUL.framework/Versions/$(MOZILLA_VERSION)/platform.ini' else -GECKO_PLATFORM_INI_PATH="$(STAGEDIST)/platform.ini" +GECKO_PLATFORM_INI_PATH='$(STAGEDIST)/platform.ini' endif -FENNEC_APPLICATION_INI_PATH="$(STAGEDIST)/application.ini" +FENNEC_APPLICATION_INI_PATH='$(STAGEDIST)/application.ini' else ifdef LIBXUL_SDK -GECKO_PLATFORM_INI_PATH="$(STAGEDIST)/xulrunner/platform.ini" +GECKO_PLATFORM_INI_PATH='$(STAGEDIST)/xulrunner/platform.ini' else -GECKO_PLATFORM_INI_PATH="$(STAGEDIST)/platform.ini" +GECKO_PLATFORM_INI_PATH='$(STAGEDIST)/platform.ini' endif -FENNEC_APPLICATION_INI_PATH="$(STAGEDIST)/application.ini" +FENNEC_APPLICATION_INI_PATH='$(STAGEDIST)/application.ini' endif ident: - @printf "gecko_revision " + @printf 'gecko_revision ' @$(PYTHON) $(topsrcdir)/config/printconfigsetting.py $(GECKO_PLATFORM_INI_PATH) Build SourceStamp - @printf "fennec_revision " + @printf 'fennec_revision ' @$(PYTHON) $(topsrcdir)/config/printconfigsetting.py $(FENNEC_APPLICATION_INI_PATH) App SourceStamp - @printf "buildid " + @printf 'buildid ' @$(PYTHON) $(topsrcdir)/config/printconfigsetting.py $(FENNEC_APPLICATION_INI_PATH) App BuildID merge-%: diff --git a/mobile/android/tests/background/junit3/Makefile.in b/mobile/android/tests/background/junit3/Makefile.in index dde3b330ef60..27ff019728b1 100644 --- a/mobile/android/tests/background/junit3/Makefile.in +++ b/mobile/android/tests/background/junit3/Makefile.in @@ -8,11 +8,11 @@ PP_TARGETS += manifest manifest := $(srcdir)/AndroidManifest.xml.in manifest_TARGET := AndroidManifest.xml manifest_FLAGS += \ - -DANDROID_BACKGROUND_TARGET_PACKAGE_NAME="$(ANDROID_PACKAGE_NAME)" \ - -DANDROID_BACKGROUND_TEST_PACKAGE_NAME="org.mozilla.background.test" \ - -DANDROID_BACKGROUND_APP_DISPLAYNAME="$(MOZ_APP_DISPLAYNAME) Background Tests" \ - -DMOZ_ANDROID_SHARED_ID="$(ANDROID_PACKAGE_NAME).sharedID" \ - -DMOZ_ANDROID_SHARED_ACCOUNT_TYPE="$(ANDROID_PACKAGE_NAME)_sync" \ + -DANDROID_BACKGROUND_TARGET_PACKAGE_NAME='$(ANDROID_PACKAGE_NAME)' \ + -DANDROID_BACKGROUND_TEST_PACKAGE_NAME='org.mozilla.background.test' \ + -DANDROID_BACKGROUND_APP_DISPLAYNAME='$(MOZ_APP_DISPLAYNAME) Background Tests' \ + -DMOZ_ANDROID_SHARED_ID='$(ANDROID_PACKAGE_NAME).sharedID' \ + -DMOZ_ANDROID_SHARED_ACCOUNT_TYPE='$(ANDROID_PACKAGE_NAME)_sync' \ $(NULL) GARBAGE += AndroidManifest.xml diff --git a/mobile/locales/Makefile.in b/mobile/locales/Makefile.in index 44f17538389e..7f0d9b86301c 100644 --- a/mobile/locales/Makefile.in +++ b/mobile/locales/Makefile.in @@ -107,10 +107,10 @@ search-jar-preqs = \ .PHONY: search-jar search-jar: $(search-jar) $(search-jar): $(search-jar-preqs) - @echo "\nGenerating: search-jar" - printf "$(AB_CD).jar:" > $@ + @echo '\nGenerating: search-jar' + printf '$(AB_CD).jar:' > $@ ln -fn $@ . - printf "$(foreach plugin,$(SEARCH_PLUGINS),$(subst __PLUGIN_SUBST__,$(plugin), \n locale/$(AB_CD)/browser/searchplugins/__PLUGIN_SUBST__.xml (__PLUGIN_SUBST__.xml)))" >> $@ + printf '$(foreach plugin,$(SEARCH_PLUGINS),$(subst __PLUGIN_SUBST__,$(plugin), \n locale/$(AB_CD)/browser/searchplugins/__PLUGIN_SUBST__.xml (__PLUGIN_SUBST__.xml)))' >> $@ @echo >> $@ ################### @@ -194,7 +194,7 @@ $(bookmarks-ts): $(bookmarks-preqs) .PHONY: bookmarks $(bookmarks) bookmarks: $(bookmarks) $(bookmarks): $(bookmarks-ts) - @echo "\nGenerating: $@" + @echo '\nGenerating: $@' ln -fn $< . diff --git a/security/build/Makefile.in b/security/build/Makefile.in index 933207b780db..2c551bfac210 100644 --- a/security/build/Makefile.in +++ b/security/build/Makefile.in @@ -116,7 +116,7 @@ endif export MOZ_DEBUG_SYMBOLS DEFAULT_GMAKE_FLAGS = -DEFAULT_GMAKE_FLAGS += CC="$(CC)" +DEFAULT_GMAKE_FLAGS += CC='$(CC)' DEFAULT_GMAKE_FLAGS += SOURCE_MD_DIR=$(ABS_DIST) DEFAULT_GMAKE_FLAGS += SOURCE_MDHEADERS_DIR=$(NSPR_INCLUDE_DIR) DEFAULT_GMAKE_FLAGS += DIST=$(ABS_DIST) @@ -126,7 +126,7 @@ DEFAULT_GMAKE_FLAGS += MOZILLA_CLIENT=1 DEFAULT_GMAKE_FLAGS += NO_MDUPDATE=1 DEFAULT_GMAKE_FLAGS += NSS_ENABLE_ECC=1 ifeq ($(OS_ARCH)_$(GNU_CC),WINNT_1) -DEFAULT_GMAKE_FLAGS += OS_DLLFLAGS="-static-libgcc" +DEFAULT_GMAKE_FLAGS += OS_DLLFLAGS='-static-libgcc' endif ifndef MOZ_NATIVE_SQLITE ifdef MOZ_FOLD_LIBS @@ -205,35 +205,35 @@ DEFAULT_GMAKE_FLAGS += CHECKLOC= ifdef CROSS_COMPILE DEFAULT_GMAKE_FLAGS += \ - NATIVE_CC="$(HOST_CC)" \ - CC="$(CC)" \ - CCC="$(CXX)" \ - LINK="$(LD)" \ - AS="$(AS)" \ + NATIVE_CC='$(HOST_CC)' \ + CC='$(CC)' \ + CCC='$(CXX)' \ + LINK='$(LD)' \ + AS='$(AS)' \ AR='$(AR) $(AR_FLAGS:$@=$$@)' \ - RANLIB="$(RANLIB)" \ - RC="$(RC) $(RCFLAGS)" \ - OS_ARCH="$(OS_ARCH)" \ - OS_TEST="$(OS_TEST)" \ - CPU_ARCH="$(TARGET_CPU)" \ + RANLIB='$(RANLIB)' \ + RC='$(RC) $(RCFLAGS)' \ + OS_ARCH='$(OS_ARCH)' \ + OS_TEST='$(OS_TEST)' \ + CPU_ARCH='$(TARGET_CPU)' \ $(NULL) # Android has pthreads integrated into -lc, so OS_PTHREAD is set to nothing ifeq ($(OS_TARGET), Android) DEFAULT_GMAKE_FLAGS += \ - OS_RELEASE="2.6" \ + OS_RELEASE='2.6' \ OS_PTHREAD= \ - STANDARDS_CFLAGS="-std=gnu89" \ + STANDARDS_CFLAGS='-std=gnu89' \ $(NULL) -DEFAULT_GMAKE_FLAGS += ARCHFLAG="$(CFLAGS) -DCHECK_FORK_GETPID -DRTLD_NOLOAD=0 -include $(ABS_topsrcdir)/security/manager/android_stub.h" +DEFAULT_GMAKE_FLAGS += ARCHFLAG='$(CFLAGS) -DCHECK_FORK_GETPID -DRTLD_NOLOAD=0 -include $(ABS_topsrcdir)/security/manager/android_stub.h' endif endif ifdef WRAP_LDFLAGS DEFAULT_GMAKE_FLAGS += \ - LDFLAGS="$(LDFLAGS) $(WRAP_LDFLAGS)" \ - DSO_LDOPTS="$(DSO_LDOPTS) $(LDFLAGS) $(WRAP_LDFLAGS)" \ + LDFLAGS='$(LDFLAGS) $(WRAP_LDFLAGS)' \ + DSO_LDOPTS='$(DSO_LDOPTS) $(LDFLAGS) $(WRAP_LDFLAGS)' \ $(NULL) endif @@ -246,8 +246,8 @@ ifdef MOZ_NO_WLZDEFS DEFAULT_GMAKE_FLAGS += ZDEFS_FLAG= endif ifdef MOZ_CFLAGS_NSS -DEFAULT_GMAKE_FLAGS += XCFLAGS="$(CFLAGS)" -DEFAULT_GMAKE_FLAGS += DARWIN_DYLIB_VERSIONS="-compatibility_version 1 -current_version 1 $(LDFLAGS)" +DEFAULT_GMAKE_FLAGS += XCFLAGS='$(CFLAGS)' +DEFAULT_GMAKE_FLAGS += DARWIN_DYLIB_VERSIONS='-compatibility_version 1 -current_version 1 $(LDFLAGS)' endif DEFAULT_GMAKE_FLAGS += NSS_NO_PKCS11_BYPASS=1 @@ -318,7 +318,7 @@ ifdef MOZ_FOLD_LIBS # TODO: The following can be replaced by something simpler when bug 844880 # is fixed. # All static libraries required for nss, smime, ssl and nssutil. -NSS_STATIC_LIBS := $(shell $(MAKE) --no-print-directory -f $(srcdir)/nss.mk DEPTH="$(DEPTH)" topsrcdir="$(topsrcdir)" srcdir="$(srcdir)" echo-variable-libs) +NSS_STATIC_LIBS := $(shell $(MAKE) --no-print-directory -f $(srcdir)/nss.mk DEPTH='$(DEPTH)' topsrcdir='$(topsrcdir)' srcdir='$(srcdir)' echo-variable-libs) # Corresponding build directories NSS_STATIC_DIRS := $(foreach lib,$(NSS_STATIC_LIBS),$(patsubst %/,%,$(dir $(lib)))) NSS_DIRS += $(NSS_STATIC_DIRS) diff --git a/services/sync/Makefile.in b/services/sync/Makefile.in index 5cad09b580ea..26d957ee4221 100644 --- a/services/sync/Makefile.in +++ b/services/sync/Makefile.in @@ -10,7 +10,7 @@ weave_id := {340c2bbc-ce74-4362-90b5-7c26312808ef} SYNC_PP := modules/constants.js SYNC_PP_FLAGS := \ -Dweave_version=$(weave_version) \ - -Dweave_id="$(weave_id)" + -Dweave_id='$(weave_id)' SYNC_PP_PATH = $(FINAL_TARGET)/modules/services-sync PP_TARGETS += SYNC_PP diff --git a/testing/testsuite-targets.mk b/testing/testsuite-targets.mk index 3bf08029134d..b0c57e0bd78d 100644 --- a/testing/testsuite-targets.mk +++ b/testing/testsuite-targets.mk @@ -6,9 +6,9 @@ # Shortcut for mochitest* and xpcshell-tests targets, # replaces 'EXTRA_TEST_ARGS=--test-path=...'. ifdef TEST_PATH -TEST_PATH_ARG := --test-path="$(TEST_PATH)" -PEPTEST_PATH_ARG := --test-path="$(TEST_PATH)" -IPCPLUGINS_PATH_ARG := --test-path="$(TEST_PATH)" +TEST_PATH_ARG := --test-path='$(TEST_PATH)' +PEPTEST_PATH_ARG := --test-path='$(TEST_PATH)' +IPCPLUGINS_PATH_ARG := --test-path='$(TEST_PATH)' else TEST_PATH_ARG := PEPTEST_PATH_ARG := --test-path=_tests/peptest/tests/firefox/firefox_all.ini @@ -76,53 +76,53 @@ RUN_MOCHITEST_ROBOCOP = \ ifndef NO_FAIL_ON_TEST_ERRORS define check_test_error_internal - @errors=`grep "TEST-UNEXPECTED-" $@.log` ;\ - if test "$$errors" ; then \ - echo "$@ failed:"; \ - echo "$$errors"; \ + @errors=`grep 'TEST-UNEXPECTED-' $@.log` ;\ + if test '$$errors' ; then \ + echo '$@ failed:'; \ + echo '$$errors'; \ $(if $(1),echo $(1)) \ exit 1; \ fi endef CHECK_TEST_ERROR = $(call check_test_error_internal) -CHECK_TEST_ERROR_RERUN = $(call check_test_error_internal,"To rerun your failures please run 'make $@-rerun-failures'") +CHECK_TEST_ERROR_RERUN = $(call check_test_error_internal,'To rerun your failures please run 'make $@-rerun-failures'') endif mochitest-remote: DM_TRANS?=adb mochitest-remote: - @if [ "${MOZ_HOST_BIN}" = "" ]; then \ - echo "environment variable MOZ_HOST_BIN must be set to a directory containing host xpcshell"; \ + @if [ '${MOZ_HOST_BIN}' = '' ]; then \ + echo 'environment variable MOZ_HOST_BIN must be set to a directory containing host xpcshell'; \ elif [ ! -d ${MOZ_HOST_BIN} ]; then \ - echo "MOZ_HOST_BIN does not specify a directory"; \ + echo 'MOZ_HOST_BIN does not specify a directory'; \ elif [ ! -f ${MOZ_HOST_BIN}/xpcshell ]; then \ - echo "xpcshell not found in MOZ_HOST_BIN"; \ - elif [ "${TEST_DEVICE}" = "" -a "$(DM_TRANS)" != "adb" ]; then \ - echo "please prepare your host with the environment variable TEST_DEVICE"; \ + echo 'xpcshell not found in MOZ_HOST_BIN'; \ + elif [ '${TEST_DEVICE}' = '' -a '$(DM_TRANS)' != 'adb' ]; then \ + echo 'please prepare your host with the environment variable TEST_DEVICE'; \ else \ $(RUN_MOCHITEST_REMOTE); \ fi mochitest-robotium: mochitest-robocop - @echo "mochitest-robotium is deprecated -- please use mochitest-robocop" + @echo 'mochitest-robotium is deprecated -- please use mochitest-robocop' mochitest-robocop: DM_TRANS?=adb mochitest-robocop: - @if [ "${MOZ_HOST_BIN}" = "" ]; then \ - echo "environment variable MOZ_HOST_BIN must be set to a directory containing host xpcshell"; \ + @if [ '${MOZ_HOST_BIN}' = '' ]; then \ + echo 'environment variable MOZ_HOST_BIN must be set to a directory containing host xpcshell'; \ elif [ ! -d ${MOZ_HOST_BIN} ]; then \ - echo "MOZ_HOST_BIN does not specify a directory"; \ + echo 'MOZ_HOST_BIN does not specify a directory'; \ elif [ ! -f ${MOZ_HOST_BIN}/xpcshell ]; then \ - echo "xpcshell not found in MOZ_HOST_BIN"; \ - elif [ "${TEST_DEVICE}" = "" -a "$(DM_TRANS)" != "adb" ]; then \ - echo "please prepare your host with the environment variable TEST_DEVICE"; \ + echo 'xpcshell not found in MOZ_HOST_BIN'; \ + elif [ '${TEST_DEVICE}' = '' -a '$(DM_TRANS)' != 'adb' ]; then \ + echo 'please prepare your host with the environment variable TEST_DEVICE'; \ else \ $(RUN_MOCHITEST_ROBOCOP); \ fi ifdef MOZ_B2G mochitest-plain: - @if [ "${GAIA_PROFILE_DIR}" = "" ]; then \ - echo "please specify the GAIA_PROFILE_DIR env variable"; \ + @if [ '${GAIA_PROFILE_DIR}' = '' ]; then \ + echo 'please specify the GAIA_PROFILE_DIR env variable'; \ else \ $(RUN_MOCHITEST_B2G_DESKTOP); \ $(CHECK_TEST_ERROR_RERUN); \ @@ -139,7 +139,7 @@ mochitest-plain-rerun-failures: # Allow mochitest-1 ... mochitest-5 for developer ease mochitest-1 mochitest-2 mochitest-3 mochitest-4 mochitest-5: mochitest-%: - echo "mochitest: $* / 5" + echo 'mochitest: $* / 5' $(RUN_MOCHITEST) --chunk-by-dir=4 --total-chunks=5 --this-chunk=$* $(CHECK_TEST_ERROR) @@ -195,13 +195,13 @@ REMOTE_REFTEST = rm -f ./$@.log && $(PYTHON) _tests/reftest/remotereftest.py \ --dm_trans=$(DM_TRANS) --ignore-window-size \ --app=$(TEST_PACKAGE_NAME) --deviceIP=${TEST_DEVICE} --xre-path=${MOZ_HOST_BIN} \ --httpd-path=_tests/reftest/reftest/components \ - $(SYMBOLS_PATH) $(EXTRA_TEST_ARGS) "$(1)" | tee ./$@.log + $(SYMBOLS_PATH) $(EXTRA_TEST_ARGS) '$(1)' | tee ./$@.log RUN_REFTEST_B2G = rm -f ./$@.log && $(PYTHON) _tests/reftest/runreftestb2g.py \ --remote-webserver=10.0.2.2 --b2gpath=${B2G_PATH} --adbpath=${ADB_PATH} \ --xre-path=${MOZ_HOST_BIN} $(SYMBOLS_PATH) --ignore-window-size \ --httpd-path=_tests/reftest/reftest/components \ - $(EXTRA_TEST_ARGS) "$(1)" | tee ./$@.log + $(EXTRA_TEST_ARGS) '$(1)' | tee ./$@.log ifeq ($(OS_ARCH),WINNT) #{ # GPU-rendered shadow layers are unsupported here @@ -214,20 +214,20 @@ endif #} reftest: TEST_PATH?=layout/reftests/reftest.list reftest: - $(call RUN_REFTEST,"$(topsrcdir)/$(TEST_PATH)") + $(call RUN_REFTEST,'$(topsrcdir)/$(TEST_PATH)') $(CHECK_TEST_ERROR) reftest-remote: TEST_PATH?=layout/reftests/reftest.list reftest-remote: DM_TRANS?=adb reftest-remote: - @if [ "${MOZ_HOST_BIN}" = "" ]; then \ - echo "environment variable MOZ_HOST_BIN must be set to a directory containing host xpcshell"; \ + @if [ '${MOZ_HOST_BIN}' = '' ]; then \ + echo 'environment variable MOZ_HOST_BIN must be set to a directory containing host xpcshell'; \ elif [ ! -d ${MOZ_HOST_BIN} ]; then \ - echo "MOZ_HOST_BIN does not specify a directory"; \ + echo 'MOZ_HOST_BIN does not specify a directory'; \ elif [ ! -f ${MOZ_HOST_BIN}/xpcshell ]; then \ - echo "xpcshell not found in MOZ_HOST_BIN"; \ - elif [ "${TEST_DEVICE}" = "" -a "$(DM_TRANS)" != "adb" ]; then \ - echo "please prepare your host with the environment variable TEST_DEVICE"; \ + echo 'xpcshell not found in MOZ_HOST_BIN'; \ + elif [ '${TEST_DEVICE}' = '' -a '$(DM_TRANS)' != 'adb' ]; then \ + echo 'please prepare your host with the environment variable TEST_DEVICE'; \ else \ ln -s $(abspath $(topsrcdir)) _tests/reftest/tests; \ $(call REMOTE_REFTEST,tests/$(TEST_PATH)); \ @@ -236,17 +236,17 @@ reftest-remote: reftest-b2g: TEST_PATH?=layout/reftests/reftest.list reftest-b2g: - @if [ "${MOZ_HOST_BIN}" = "" ]; then \ - echo "environment variable MOZ_HOST_BIN must be set to a directory containing host xpcshell"; \ + @if [ '${MOZ_HOST_BIN}' = '' ]; then \ + echo 'environment variable MOZ_HOST_BIN must be set to a directory containing host xpcshell'; \ elif [ ! -d ${MOZ_HOST_BIN} ]; then \ - echo "MOZ_HOST_BIN does not specify a directory"; \ + echo 'MOZ_HOST_BIN does not specify a directory'; \ elif [ ! -f ${MOZ_HOST_BIN}/xpcshell ]; then \ - echo "xpcshell not found in MOZ_HOST_BIN"; \ - elif [ "${B2G_PATH}" = "" -o "${ADB_PATH}" = "" ]; then \ - echo "please set the B2G_PATH and ADB_PATH environment variables"; \ + echo 'xpcshell not found in MOZ_HOST_BIN'; \ + elif [ '${B2G_PATH}' = '' -o '${ADB_PATH}' = '' ]; then \ + echo 'please set the B2G_PATH and ADB_PATH environment variables'; \ else \ ln -s $(abspath $(topsrcdir)) _tests/reftest/tests; \ - if [ "${REFTEST_PATH}" != "" ]; then \ + if [ '${REFTEST_PATH}' != '' ]; then \ $(call RUN_REFTEST_B2G,tests/${REFTEST_PATH}); \ else \ $(call RUN_REFTEST_B2G,tests/$(TEST_PATH)); \ @@ -256,27 +256,27 @@ reftest-b2g: reftest-ipc: TEST_PATH?=layout/reftests/reftest.list reftest-ipc: - $(call RUN_REFTEST,"$(topsrcdir)/$(TEST_PATH)" $(OOP_CONTENT)) + $(call RUN_REFTEST,'$(topsrcdir)/$(TEST_PATH)' $(OOP_CONTENT)) $(CHECK_TEST_ERROR) reftest-ipc-gpu: TEST_PATH?=layout/reftests/reftest.list reftest-ipc-gpu: - $(call RUN_REFTEST,"$(topsrcdir)/$(TEST_PATH)" $(OOP_CONTENT) $(GPU_RENDERING)) + $(call RUN_REFTEST,'$(topsrcdir)/$(TEST_PATH)' $(OOP_CONTENT) $(GPU_RENDERING)) $(CHECK_TEST_ERROR) crashtest: TEST_PATH?=testing/crashtest/crashtests.list crashtest: - $(call RUN_REFTEST,"$(topsrcdir)/$(TEST_PATH)") + $(call RUN_REFTEST,'$(topsrcdir)/$(TEST_PATH)') $(CHECK_TEST_ERROR) crashtest-ipc: TEST_PATH?=testing/crashtest/crashtests.list crashtest-ipc: - $(call RUN_REFTEST,"$(topsrcdir)/$(TEST_PATH)" $(OOP_CONTENT)) + $(call RUN_REFTEST,'$(topsrcdir)/$(TEST_PATH)' $(OOP_CONTENT)) $(CHECK_TEST_ERROR) crashtest-ipc-gpu: TEST_PATH?=testing/crashtest/crashtests.list crashtest-ipc-gpu: - $(call RUN_REFTEST,"$(topsrcdir)/$(TEST_PATH)" $(OOP_CONTENT) $(GPU_RENDERING)) + $(call RUN_REFTEST,'$(topsrcdir)/$(TEST_PATH)' $(OOP_CONTENT) $(GPU_RENDERING)) $(CHECK_TEST_ERROR) jstestbrowser: TESTS_PATH?=test-package-stage/jsreftest/tests/ @@ -284,7 +284,7 @@ jstestbrowser: $(MAKE) -C $(DEPTH)/config $(MAKE) -C $(DEPTH)/js/src/config $(MAKE) stage-jstests - $(call RUN_REFTEST,"$(DIST)/$(TESTS_PATH)/jstests.list" --extra-profile-file=$(DIST)/test-package-stage/jsreftest/tests/user.js) + $(call RUN_REFTEST,'$(DIST)/$(TESTS_PATH)/jstests.list' --extra-profile-file=$(DIST)/test-package-stage/jsreftest/tests/user.js) $(CHECK_TEST_ERROR) GARBAGE += $(addsuffix .log,$(MOCHITESTS) reftest crashtest jstestbrowser) @@ -302,7 +302,7 @@ xpcshell-tests: --manifest=$(DEPTH)/_tests/xpcshell/xpcshell.ini \ --build-info-json=$(DEPTH)/mozinfo.json \ --no-logfiles \ - --test-plugin-path="$(DIST)/plugins" \ + --test-plugin-path='$(DIST)/plugins' \ --tests-root-dir=$(abspath _tests/xpcshell) \ --testing-modules-dir=$(abspath _tests/modules) \ --xunit-file=$(abspath _tests/xpcshell/results.xml) \ @@ -329,11 +329,11 @@ B2G_XPCSHELL = \ xpcshell-tests-b2g: ADB_PATH?=$(shell which adb) xpcshell-tests-b2g: - @if [ "${B2G_HOME}" = "" ]; then \ - echo "Please set the B2G_HOME variable"; exit 1; \ - elif [ ! -f "${ADB_PATH}" ]; then \ - echo "Please set the ADB_PATH variable"; exit 1; \ - elif [ "${EMULATOR}" != "" ]; then \ + @if [ '${B2G_HOME}' = '' ]; then \ + echo 'Please set the B2G_HOME variable'; exit 1; \ + elif [ ! -f '${ADB_PATH}' ]; then \ + echo 'Please set the ADB_PATH variable'; exit 1; \ + elif [ '${EMULATOR}' != '' ]; then \ EXTRA_XPCSHELL_ARGS=--emulator=${EMULATOR}; \ $(call B2G_XPCSHELL); \ exit 0; \ @@ -345,7 +345,7 @@ xpcshell-tests-b2g: xpcshell-tests-remote: DM_TRANS?=adb xpcshell-tests-remote: - @if [ "${TEST_DEVICE}" != "" -o "$(DM_TRANS)" = "adb" ]; \ + @if [ '${TEST_DEVICE}' != '' -o '$(DM_TRANS)' = 'adb' ]; \ then $(PYTHON) -u $(topsrcdir)/testing/xpcshell/remotexpcshelltests.py \ --manifest=$(DEPTH)/_tests/xpcshell/xpcshell_android.ini \ --build-info-json=$(DEPTH)/mozinfo.json \ @@ -358,7 +358,7 @@ xpcshell-tests-remote: $(TEST_PATH_ARG) $(EXTRA_TEST_ARGS); \ $(CHECK_TEST_ERROR); \ else \ - echo "please prepare your host with environment variables for TEST_DEVICE"; \ + echo 'please prepare your host with environment variables for TEST_DEVICE'; \ fi # Runs peptest, for usage see: https://developer.mozilla.org/en/Peptest#Running_Tests @@ -386,10 +386,10 @@ REMOTE_CPPUNITTESTS = \ # Usage: |make [TEST_PATH=...] [EXTRA_TEST_ARGS=...] cppunittests-remote|. cppunittests-remote: DM_TRANS?=adb cppunittests-remote: - @if [ "${TEST_DEVICE}" != "" -o "$(DM_TRANS)" = "adb" ]; \ + @if [ '${TEST_DEVICE}' != '' -o '$(DM_TRANS)' = 'adb' ]; \ then $(call REMOTE_CPPUNITTESTS); \ else \ - echo "please prepare your host with environment variables for TEST_DEVICE"; \ + echo 'please prepare your host with environment variables for TEST_DEVICE'; \ fi jetpack-tests: @@ -430,13 +430,13 @@ PKG_STAGE = $(DIST)/universal/test-package-stage endif package-tests: - @rm -f "$(DIST)/$(PKG_PATH)$(TEST_PACKAGE)" + @rm -f '$(DIST)/$(PKG_PATH)$(TEST_PACKAGE)' ifndef UNIVERSAL_BINARY $(NSINSTALL) -D $(DIST)/$(PKG_PATH) endif - find $(PKG_STAGE) -name "*.pyc" -exec rm {} \; + find $(PKG_STAGE) -name '*.pyc' -exec rm {} \; cd $(PKG_STAGE) && \ - zip -rq9D "$(abspath $(DIST))/$(PKG_PATH)$(TEST_PACKAGE)" \ + zip -rq9D '$(abspath $(DIST))/$(PKG_PATH)$(TEST_PACKAGE)' \ * -x \*/.mkdir.done ifeq ($(MOZ_WIDGET_TOOLKIT),android) diff --git a/toolkit/components/telemetry/Makefile.in b/toolkit/components/telemetry/Makefile.in index ed2322d95ff5..1c5c03b5d8db 100644 --- a/toolkit/components/telemetry/Makefile.in +++ b/toolkit/components/telemetry/Makefile.in @@ -9,9 +9,9 @@ include $(topsrcdir)/config/makefiles/rcs.mk LOCAL_INCLUDES += -I$(topsrcdir)/xpcom/build LOCAL_INCLUDES += -I$(topsrcdir)/xpcom/threads -MOZ_HISTOGRAMS_VERSION ?= $(call getSourceRepo)/rev/$(firstword $(shell hg -R $(topsrcdir) parent --template="{node|short}\n" 2>/dev/null)) +MOZ_HISTOGRAMS_VERSION ?= $(call getSourceRepo)/rev/$(firstword $(shell hg -R $(topsrcdir) parent --template='{node|short}\n' 2>/dev/null)) ifdef MOZ_HISTOGRAMS_VERSION -DEFINES += -DHISTOGRAMS_FILE_VERSION="$(MOZ_HISTOGRAMS_VERSION)" +DEFINES += -DHISTOGRAMS_FILE_VERSION='$(MOZ_HISTOGRAMS_VERSION)' endif INSTALL_TARGETS += histoenums diff --git a/toolkit/components/urlformatter/Makefile.in b/toolkit/components/urlformatter/Makefile.in index 4bbb6e4368cc..54e5220f3e49 100644 --- a/toolkit/components/urlformatter/Makefile.in +++ b/toolkit/components/urlformatter/Makefile.in @@ -10,6 +10,6 @@ EXTRA_PP_COMPONENTS_FLAGS = -I google_api_key include $(topsrcdir)/config/rules.mk google_api_key: - @echo "#define MOZ_GOOGLE_API_KEY $(MOZ_GOOGLE_API_KEY)" > $@ + @echo '#define MOZ_GOOGLE_API_KEY $(MOZ_GOOGLE_API_KEY)' > $@ GARBAGE += google_api_key diff --git a/toolkit/content/Makefile.in b/toolkit/content/Makefile.in index 485b574eb680..fe10eaf39114 100644 --- a/toolkit/content/Makefile.in +++ b/toolkit/content/Makefile.in @@ -7,21 +7,21 @@ USE_RCS_MK := 1 include $(topsrcdir)/config/makefiles/makeutils.mk DEFINES += \ - -DCXXFLAGS="$(CXXFLAGS)" \ - -DCPPFLAGS="$(CPPFLAGS)" \ + -DCXXFLAGS='$(CXXFLAGS)' \ + -DCPPFLAGS='$(CPPFLAGS)' \ $(NULL) -MOZ_SOURCE_STAMP ?= $(shell hg -R $(topsrcdir) parent --template="{node|short}\n" 2>/dev/null) +MOZ_SOURCE_STAMP ?= $(shell hg -R $(topsrcdir) parent --template='{node|short}\n' 2>/dev/null) ifdef MOZ_SOURCE_STAMP -DEFINES += -DSOURCE_CHANGESET="$(MOZ_SOURCE_STAMP)" +DEFINES += -DSOURCE_CHANGESET='$(MOZ_SOURCE_STAMP)' endif source_repo ?= $(call getSourceRepo) ifneq (,$(filter http%,$(source_repo))) - DEFINES += -DSOURCE_REPO="$(source_repo)" + DEFINES += -DSOURCE_REPO='$(source_repo)' else ifneq (,$(strip $(source_repo))) - DEFINES += -DSOURCE_GIT_COMMIT="$(source_repo)" + DEFINES += -DSOURCE_GIT_COMMIT='$(source_repo)' endif BUILD_HOSTNAME = $(shell hostname -s || hostname) -DEFINES += -DBUILD_HOSTNAME="$(BUILD_HOSTNAME)" +DEFINES += -DBUILD_HOSTNAME='$(BUILD_HOSTNAME)' diff --git a/toolkit/crashreporter/client/Makefile.in b/toolkit/crashreporter/client/Makefile.in index 40feebcff254..1d2e4c91707f 100644 --- a/toolkit/crashreporter/client/Makefile.in +++ b/toolkit/crashreporter/client/Makefile.in @@ -63,8 +63,8 @@ include $(topsrcdir)/config/rules.mk ifeq ($(OS_ARCH),Darwin) libs:: $(NSINSTALL) -D $(DIST)/bin/crashreporter.app - rsync -a -C --exclude "*.in" $(srcdir)/macbuild/Contents $(DIST)/bin/crashreporter.app - sed -e "s/%APP_NAME%/$(MOZ_APP_DISPLAYNAME)/" $(srcdir)/macbuild/Contents/Resources/English.lproj/InfoPlist.strings.in | \ + rsync -a -C --exclude '*.in' $(srcdir)/macbuild/Contents $(DIST)/bin/crashreporter.app + sed -e 's/%APP_NAME%/$(MOZ_APP_DISPLAYNAME)/' $(srcdir)/macbuild/Contents/Resources/English.lproj/InfoPlist.strings.in | \ iconv -f UTF-8 -t UTF-16 > $(DIST)/bin/crashreporter.app/Contents/Resources/English.lproj/InfoPlist.strings $(NSINSTALL) -D $(DIST)/bin/crashreporter.app/Contents/MacOS $(NSINSTALL) $(DIST)/bin/crashreporter $(DIST)/bin/crashreporter.app/Contents/MacOS diff --git a/toolkit/library/Makefile.in b/toolkit/library/Makefile.in index b4b037dea054..0e63c383c04a 100644 --- a/toolkit/library/Makefile.in +++ b/toolkit/library/Makefile.in @@ -62,7 +62,7 @@ EXTRA_DSO_LDOPTS += -Wl,-version-script,symverscript symverscript: symverscript.in $(call py_action,preprocessor, \ - -DVERSION="$(LIBRARY_NAME)$(MOZILLA_SYMBOLVERSION)" $< -o $@) + -DVERSION='$(LIBRARY_NAME)$(MOZILLA_SYMBOLVERSION)' $< -o $@) EXTRA_DEPS += symverscript endif @@ -173,7 +173,7 @@ endif ifeq (WINNT,$(OS_TARGET)) EXTRA_DSO_LDOPTS += \ - -LIBPATH:"$(MOZ_DIRECTX_SDK_PATH)/lib/$(MOZ_DIRECTX_SDK_CPU_SUFFIX)" \ + -LIBPATH:'$(MOZ_DIRECTX_SDK_PATH)/lib/$(MOZ_DIRECTX_SDK_CPU_SUFFIX)' \ $(NULL) OS_LIBS += $(call EXPAND_LIBNAME,secur32 crypt32 iphlpapi strmiids dmoguids wmcodecdspuuid amstrmid msdmo wininet) endif @@ -337,8 +337,8 @@ ifdef MOZ_GAMEPAD ifndef GNU_CC DXSDK := $(subst \,/,$(MOZ_DIRECTX_SDK_PATH))/Lib/$(MOZ_DIRECTX_SDK_CPU_SUFFIX) OS_LIBS += \ - "$(DXSDK)/dxguid.lib" \ - "$(DXSDK)/dinput8.lib" \ + '$(DXSDK)/dxguid.lib' \ + '$(DXSDK)/dinput8.lib' \ $(NULL) else OS_LIBS += $(call EXPAND_LIBNAME,dxguid dinput8) @@ -416,7 +416,7 @@ endif .PHONY: gtestxul $(FINAL_TARGET)/dependentlibs.list.gtest: $(FINAL_TARGET)/dependentlibs.list - sed -e "s|$(SHARED_LIBRARY)|gtest/$(SHARED_LIBRARY)|" $< > $@ + sed -e 's|$(SHARED_LIBRARY)|gtest/$(SHARED_LIBRARY)|' $< > $@ # Remove this target when actually linking gtest to prevent redefining # the implicit rules.mk target diff --git a/toolkit/locales/Makefile.in b/toolkit/locales/Makefile.in index e3e28e44bf32..52d60efd3bcc 100644 --- a/toolkit/locales/Makefile.in +++ b/toolkit/locales/Makefile.in @@ -32,7 +32,7 @@ chrome-%: ifdef MOZ_UPDATER libs:: update.locale - cat $< | sed -e "s/%AB_CD%/$(AB_CD)/" > $(FINAL_TARGET)/update.locale + sed -e 's/%AB_CD%/$(AB_CD)/' $< > $(FINAL_TARGET)/update.locale endif ifdef MOZ_CRASHREPORTER diff --git a/toolkit/locales/l10n.mk b/toolkit/locales/l10n.mk index b5bb4c78fc82..1369ba5ee3a7 100644 --- a/toolkit/locales/l10n.mk +++ b/toolkit/locales/l10n.mk @@ -50,8 +50,8 @@ DEFINES += \ -DMOZ_APP_VERSION=$(MOZ_APP_VERSION) \ -DMOZ_APP_MAXVERSION=$(MOZ_APP_MAXVERSION) \ -DLOCALE_SRCDIR=$(abspath $(LOCALE_SRCDIR)) \ - -DPKG_BASENAME="$(PKG_BASENAME)" \ - -DPKG_INST_BASENAME="$(PKG_INST_BASENAME)" \ + -DPKG_BASENAME='$(PKG_BASENAME)' \ + -DPKG_INST_BASENAME='$(PKG_INST_BASENAME)' \ $(NULL) @@ -102,7 +102,7 @@ MAKE_COMPLETE_MAR = endif endif endif -repackage-zip: UNPACKAGE="$(ZIP_IN)" +repackage-zip: UNPACKAGE='$(ZIP_IN)' repackage-zip: ALREADY_SZIPPED=1 repackage-zip: libs-$(AB_CD) # call a hook for apps to put their uninstall helper.exe into the package @@ -124,8 +124,8 @@ endif ifdef MAKE_COMPLETE_MAR $(MAKE) -C $(MOZDEPTH)/tools/update-packaging full-update AB_CD=$(AB_CD) \ MOZ_PKG_PRETTYNAMES=$(MOZ_PKG_PRETTYNAMES) \ - PACKAGE_BASE_DIR="$(_ABS_DIST)/l10n-stage" \ - DIST="$(_ABS_DIST)" + PACKAGE_BASE_DIR='$(_ABS_DIST)/l10n-stage' \ + DIST='$(_ABS_DIST)' endif # packaging done, undo l10n stuff ifneq (en,$(AB)) @@ -134,11 +134,11 @@ ifeq (cocoa,$(MOZ_WIDGET_TOOLKIT)) endif endif $(NSINSTALL) -D $(DIST)/$(PKG_PATH) - mv -f "$(DIST)/l10n-stage/$(PACKAGE)" "$(ZIP_OUT)" - if test -f "$(DIST)/l10n-stage/$(PACKAGE).asc"; then mv -f "$(DIST)/l10n-stage/$(PACKAGE).asc" "$(ZIP_OUT).asc"; fi + mv -f '$(DIST)/l10n-stage/$(PACKAGE)' '$(ZIP_OUT)' + if test -f '$(DIST)/l10n-stage/$(PACKAGE).asc'; then mv -f '$(DIST)/l10n-stage/$(PACKAGE).asc' '$(ZIP_OUT).asc'; fi repackage-zip-%: $(STAGEDIST) - @$(MAKE) repackage-zip AB_CD=$* ZIP_IN="$(ZIP_IN)" + @$(MAKE) repackage-zip AB_CD=$* ZIP_IN='$(ZIP_IN)' APP_DEFINES = $(firstword $(wildcard $(LOCALE_SRCDIR)/defines.inc) \ $(srcdir)/en-US/defines.inc) @@ -156,7 +156,7 @@ langpack-%: LANGPACK_FILE=$(_ABS_DIST)/$(PKG_LANGPACK_PATH)$(PKG_LANGPACK_BASENA langpack-%: AB_CD=$* langpack-%: XPI_NAME=locale-$* langpack-%: libs-% - @echo "Making langpack $(LANGPACK_FILE)" + @echo 'Making langpack $(LANGPACK_FILE)' $(NSINSTALL) -D $(DIST)/$(PKG_LANGPACK_PATH) $(call py_action,preprocessor,$(DEFINES) $(ACDEFINES) \ -I$(TK_DEFINES) -I$(APP_DEFINES) $(srcdir)/generic/install.rdf -o $(DIST)/xpi-stage/$(XPI_NAME)/install.rdf) @@ -176,13 +176,13 @@ ifndef WGET $(error Wget not installed) endif $(NSINSTALL) -D $(_ABS_DIST)/$(PKG_PATH) - (cd $(_ABS_DIST)/$(PKG_PATH) && $(WGET) --no-cache -nv -N "$(EN_US_BINARY_URL)/$(PACKAGE)") - @echo "Downloaded $(EN_US_BINARY_URL)/$(PACKAGE) to $(_ABS_DIST)/$(PKG_PATH)/$(PACKAGE)" + (cd $(_ABS_DIST)/$(PKG_PATH) && $(WGET) --no-cache -nv -N '$(EN_US_BINARY_URL)/$(PACKAGE)') + @echo 'Downloaded $(EN_US_BINARY_URL)/$(PACKAGE) to $(_ABS_DIST)/$(PKG_PATH)/$(PACKAGE)' ifdef RETRIEVE_WINDOWS_INSTALLER ifeq ($(OS_ARCH), WINNT) $(NSINSTALL) -D $(_ABS_DIST)/$(PKG_INST_PATH) - (cd $(_ABS_DIST)/$(PKG_INST_PATH) && $(WGET) --no-cache -nv -N "$(EN_US_BINARY_URL)/$(PKG_PATH)$(PKG_INST_BASENAME).exe") - @echo "Downloaded $(EN_US_BINARY_URL)/$(PKG_PATH)$(PKG_INST_BASENAME).exe to $(_ABS_DIST)/$(PKG_INST_PATH)$(PKG_INST_BASENAME).exe" + (cd $(_ABS_DIST)/$(PKG_INST_PATH) && $(WGET) --no-cache -nv -N '$(EN_US_BINARY_URL)/$(PKG_PATH)$(PKG_INST_BASENAME).exe') + @echo 'Downloaded $(EN_US_BINARY_URL)/$(PKG_PATH)$(PKG_INST_BASENAME).exe to $(_ABS_DIST)/$(PKG_INST_PATH)$(PKG_INST_BASENAME).exe' endif endif diff --git a/toolkit/mozapps/installer/packager.mk b/toolkit/mozapps/installer/packager.mk index a3769a630c67..e41384ea526a 100644 --- a/toolkit/mozapps/installer/packager.mk +++ b/toolkit/mozapps/installer/packager.mk @@ -111,7 +111,7 @@ JARLOG_FILE_AB_CD = $(JARLOG_DIR)/$(AB_CD).log TAR_CREATE_FLAGS := --exclude=.mkdir.done $(TAR_CREATE_FLAGS) CREATE_FINAL_TAR = $(TAR) -c --owner=0 --group=0 --numeric-owner \ - --mode="go-w" --exclude=.mkdir.done -f + --mode=go-w --exclude=.mkdir.done -f UNPACK_TAR = tar -xf- ifeq ($(MOZ_PKG_FORMAT),TAR) @@ -163,8 +163,8 @@ endif #Create an RPM file ifeq ($(MOZ_PKG_FORMAT),RPM) PKG_SUFFIX = .rpm -MOZ_NUMERIC_APP_VERSION = $(shell echo $(MOZ_PKG_VERSION) | sed "s/[^0-9.].*//" ) -MOZ_RPM_RELEASE = $(shell echo $(MOZ_PKG_VERSION) | sed "s/[0-9.]*//" ) +MOZ_NUMERIC_APP_VERSION = $(shell echo $(MOZ_PKG_VERSION) | sed 's/[^0-9.].*//' ) +MOZ_RPM_RELEASE = $(shell echo $(MOZ_PKG_VERSION) | sed 's/[0-9.]*//' ) RPMBUILD_TOPDIR=$(_ABS_DIST)/rpmbuild RPMBUILD_RPMDIR=$(_ABS_DIST) @@ -180,7 +180,7 @@ RPM_CMD = \ echo Creating RPM && \ $(PYTHON) -m mozbuild.action.preprocessor \ -DMOZ_APP_NAME=$(MOZ_APP_NAME) \ - -DMOZ_APP_DISPLAYNAME="$(MOZ_APP_DISPLAYNAME)" \ + -DMOZ_APP_DISPLAYNAME='$(MOZ_APP_DISPLAYNAME)' \ $(RPM_INCIDENTALS)/mozilla.desktop \ -o $(RPMBUILD_SOURCEDIR)/$(MOZ_APP_NAME).desktop && \ rm -rf $(_ABS_DIST)/$(TARGET_CPU) && \ @@ -188,39 +188,39 @@ RPM_CMD = \ $(SPEC_FILE) \ --target $(TARGET_CPU) \ --buildroot $(RPMBUILD_TOPDIR)/BUILDROOT \ - --define "moz_app_name $(MOZ_APP_NAME)" \ - --define "moz_app_displayname $(MOZ_APP_DISPLAYNAME)" \ - --define "moz_app_version $(MOZ_APP_VERSION)" \ - --define "moz_numeric_app_version $(MOZ_NUMERIC_APP_VERSION)" \ - --define "moz_rpm_release $(MOZ_RPM_RELEASE)" \ - --define "buildid $(BUILDID)" \ - --define "moz_source_repo $(MOZ_SOURCE_REPO)" \ - --define "moz_source_stamp $(MOZ_SOURCE_STAMP)" \ - --define "moz_branding_directory $(topsrcdir)/$(MOZ_BRANDING_DIRECTORY)" \ - --define "_topdir $(RPMBUILD_TOPDIR)" \ - --define "_rpmdir $(RPMBUILD_RPMDIR)" \ - --define "_sourcedir $(RPMBUILD_SOURCEDIR)" \ - --define "_specdir $(RPMBUILD_SPECDIR)" \ - --define "_srcrpmdir $(RPMBUILD_SRPMDIR)" \ - --define "_builddir $(RPMBUILD_BUILDDIR)" \ - --define "_prefix $(prefix)" \ - --define "_libdir $(libdir)" \ - --define "_bindir $(bindir)" \ - --define "_datadir $(datadir)" \ - --define "_installdir $(installdir)" + --define 'moz_app_name $(MOZ_APP_NAME)' \ + --define 'moz_app_displayname $(MOZ_APP_DISPLAYNAME)' \ + --define 'moz_app_version $(MOZ_APP_VERSION)' \ + --define 'moz_numeric_app_version $(MOZ_NUMERIC_APP_VERSION)' \ + --define 'moz_rpm_release $(MOZ_RPM_RELEASE)' \ + --define 'buildid $(BUILDID)' \ + --define 'moz_source_repo $(MOZ_SOURCE_REPO)' \ + --define 'moz_source_stamp $(MOZ_SOURCE_STAMP)' \ + --define 'moz_branding_directory $(topsrcdir)/$(MOZ_BRANDING_DIRECTORY)' \ + --define '_topdir $(RPMBUILD_TOPDIR)' \ + --define '_rpmdir $(RPMBUILD_RPMDIR)' \ + --define '_sourcedir $(RPMBUILD_SOURCEDIR)' \ + --define '_specdir $(RPMBUILD_SPECDIR)' \ + --define '_srcrpmdir $(RPMBUILD_SRPMDIR)' \ + --define '_builddir $(RPMBUILD_BUILDDIR)' \ + --define '_prefix $(prefix)' \ + --define '_libdir $(libdir)' \ + --define '_bindir $(bindir)' \ + --define '_datadir $(datadir)' \ + --define '_installdir $(installdir)' ifdef ENABLE_TESTS RPM_CMD += \ - --define "createtests yes" \ - --define "_testsinstalldir $(shell basename $(installdir))" + --define 'createtests yes' \ + --define '_testsinstalldir $(shell basename $(installdir))' endif ifdef INSTALL_SDK RPM_CMD += \ - --define "createdevel yes" \ - --define "_idldir $(idldir)" \ - --define "_sdkdir $(sdkdir)" \ - --define "_includedir $(includedir)" + --define 'createdevel yes' \ + --define '_idldir $(idldir)' \ + --define '_sdkdir $(sdkdir)' \ + --define '_includedir $(includedir)' endif #For each of the main, tests, sdk rpms we want to make sure that @@ -447,16 +447,16 @@ ifeq ($(MOZ_PKG_FORMAT),DMG) PKG_SUFFIX = .dmg PKG_DMG_FLAGS = ifneq (,$(MOZ_PKG_MAC_DSSTORE)) -PKG_DMG_FLAGS += --copy "$(MOZ_PKG_MAC_DSSTORE):/.DS_Store" +PKG_DMG_FLAGS += --copy '$(MOZ_PKG_MAC_DSSTORE):/.DS_Store' endif ifneq (,$(MOZ_PKG_MAC_BACKGROUND)) -PKG_DMG_FLAGS += --mkdir /.background --copy "$(MOZ_PKG_MAC_BACKGROUND):/.background" +PKG_DMG_FLAGS += --mkdir /.background --copy '$(MOZ_PKG_MAC_BACKGROUND):/.background' endif ifneq (,$(MOZ_PKG_MAC_ICON)) -PKG_DMG_FLAGS += --icon "$(MOZ_PKG_MAC_ICON)" +PKG_DMG_FLAGS += --icon '$(MOZ_PKG_MAC_ICON)' endif ifneq (,$(MOZ_PKG_MAC_RSRC)) -PKG_DMG_FLAGS += --resource "$(MOZ_PKG_MAC_RSRC)" +PKG_DMG_FLAGS += --resource '$(MOZ_PKG_MAC_RSRC)' endif ifneq (,$(MOZ_PKG_MAC_EXTRA)) PKG_DMG_FLAGS += $(MOZ_PKG_MAC_EXTRA) @@ -466,25 +466,25 @@ ifndef PKG_DMG_SOURCE PKG_DMG_SOURCE = $(STAGEPATH)$(MOZ_PKG_DIR) endif INNER_MAKE_PACKAGE = $(_ABS_MOZSRCDIR)/build/package/mac_osx/pkg-dmg \ - --source "$(PKG_DMG_SOURCE)" --target "$(PACKAGE)" \ - --volname "$(MOZ_APP_DISPLAYNAME)" $(PKG_DMG_FLAGS) + --source '$(PKG_DMG_SOURCE)' --target '$(PACKAGE)' \ + --volname '$(MOZ_APP_DISPLAYNAME)' $(PKG_DMG_FLAGS) INNER_UNMAKE_PACKAGE = \ set -ex; \ rm -rf $(_ABS_DIST)/unpack.tmp; \ mkdir -p $(_ABS_DIST)/unpack.tmp; \ $(_ABS_MOZSRCDIR)/build/package/mac_osx/unpack-diskimage $(UNPACKAGE) /tmp/$(MOZ_PKG_APPNAME)-unpack $(_ABS_DIST)/unpack.tmp; \ - rsync -a "$(_ABS_DIST)/unpack.tmp/$(_APPNAME)" $(MOZ_PKG_DIR); \ - test -n "$(MOZ_PKG_MAC_DSSTORE)" && \ - rsync -a "$(_ABS_DIST)/unpack.tmp/.DS_Store" "$(MOZ_PKG_MAC_DSSTORE)"; \ - test -n "$(MOZ_PKG_MAC_BACKGROUND)" && \ - rsync -a "$(_ABS_DIST)/unpack.tmp/.background/`basename "$(MOZ_PKG_MAC_BACKGROUND)"`" "$(MOZ_PKG_MAC_BACKGROUND)"; \ - test -n "$(MOZ_PKG_MAC_ICON)" && \ - rsync -a "$(_ABS_DIST)/unpack.tmp/.VolumeIcon.icns" "$(MOZ_PKG_MAC_ICON)"; \ + rsync -a '$(_ABS_DIST)/unpack.tmp/$(_APPNAME)' $(MOZ_PKG_DIR); \ + test -n '$(MOZ_PKG_MAC_DSSTORE)' && \ + rsync -a '$(_ABS_DIST)/unpack.tmp/.DS_Store' '$(MOZ_PKG_MAC_DSSTORE)'; \ + test -n '$(MOZ_PKG_MAC_BACKGROUND)' && \ + rsync -a '$(_ABS_DIST)/unpack.tmp/.background/`basename '$(MOZ_PKG_MAC_BACKGROUND)'`' '$(MOZ_PKG_MAC_BACKGROUND)'; \ + test -n '$(MOZ_PKG_MAC_ICON)' && \ + rsync -a '$(_ABS_DIST)/unpack.tmp/.VolumeIcon.icns' '$(MOZ_PKG_MAC_ICON)'; \ rm -rf $(_ABS_DIST)/unpack.tmp; \ - if test -n "$(MOZ_PKG_MAC_RSRC)" ; then \ + if test -n '$(MOZ_PKG_MAC_RSRC)' ; then \ cp $(UNPACKAGE) $(MOZ_PKG_APPNAME).tmp.dmg && \ hdiutil unflatten $(MOZ_PKG_APPNAME).tmp.dmg && \ - { /Developer/Tools/DeRez -skip plst -skip blkx $(MOZ_PKG_APPNAME).tmp.dmg > "$(MOZ_PKG_MAC_RSRC)" || { rm -f $(MOZ_PKG_APPNAME).tmp.dmg && false; }; } && \ + { /Developer/Tools/DeRez -skip plst -skip blkx $(MOZ_PKG_APPNAME).tmp.dmg > '$(MOZ_PKG_MAC_RSRC)' || { rm -f $(MOZ_PKG_APPNAME).tmp.dmg && false; }; } && \ rm -f $(MOZ_PKG_APPNAME).tmp.dmg; \ fi # The plst and blkx resources are skipped because they belong to each @@ -500,7 +500,7 @@ endif ifdef MOZ_INTERNAL_SIGNING_FORMAT MOZ_SIGN_PREPARED_PACKAGE_CMD=$(MOZ_SIGN_CMD) $(foreach f,$(MOZ_INTERNAL_SIGNING_FORMAT),-f $(f)) $(foreach i,$(SIGN_INCLUDES),-i $(i)) $(foreach x,$(SIGN_EXCLUDES),-x $(x)) ifeq (WINNT,$(OS_ARCH)) -MOZ_SIGN_PREPARED_PACKAGE_CMD += --nsscmd "$(_ABS_DIST)/bin/shlibsign$(BIN_SUFFIX) -v -i" +MOZ_SIGN_PREPARED_PACKAGE_CMD += --nsscmd '$(_ABS_DIST)/bin/shlibsign$(BIN_SUFFIX) -v -i' endif endif @@ -526,7 +526,7 @@ MAKE_PACKAGE = $(INNER_MAKE_PACKAGE) endif ifdef MOZ_SIGN_PACKAGE_CMD -MAKE_PACKAGE += && $(MOZ_SIGN_PACKAGE_CMD) "$(PACKAGE)" +MAKE_PACKAGE += && $(MOZ_SIGN_PACKAGE_CMD) '$(PACKAGE)' endif ifdef MOZ_SIGN_CMD @@ -588,14 +588,14 @@ GARBAGE += $(DIST)/$(PACKAGE) $(PACKAGE) # core files, and one for optional extensions based on the information in # the MOZ_PKG_MANIFEST file. -PKG_ARG = , "$(pkg)" +PKG_ARG = , '$(pkg)' installer-stage: prepare-package ifndef MOZ_PKG_MANIFEST $(error MOZ_PKG_MANIFEST unspecified!) endif @rm -rf $(DEPTH)/installer-stage $(DIST)/xpt - @echo "Staging installer files..." + @echo 'Staging installer files...' @$(NSINSTALL) -D $(DEPTH)/installer-stage/core @cp -av $(DIST)/$(STAGEPATH)$(MOZ_PKG_DIR)$(_BINPATH)/. $(DEPTH)/installer-stage/core @(cd $(DEPTH)/installer-stage/core && $(CREATE_PRECOMPLETE_CMD)) @@ -658,7 +658,7 @@ stage-package: $(MOZ_PKG_MANIFEST) ifndef LIBXUL_SDK ifdef MOZ_PACKAGE_JSSHELL # Package JavaScript Shell - @echo "Packaging JavaScript Shell..." + @echo 'Packaging JavaScript Shell...' $(RM) $(PKG_JSSHELL) $(MAKE_JSSHELL) endif # MOZ_PACKAGE_JSSHELL @@ -667,7 +667,7 @@ endif # LIBXUL_SDK prepare-package: stage-package make-package-internal: prepare-package make-sourcestamp-file make-buildinfo-file - @echo "Compressing..." + @echo 'Compressing...' cd $(DIST) && $(MAKE_PACKAGE) make-package: FORCE @@ -678,8 +678,8 @@ GARBAGE += make-package make-sourcestamp-file:: $(NSINSTALL) -D $(DIST)/$(PKG_PATH) - @echo "$(BUILDID)" > $(MOZ_SOURCESTAMP_FILE) - @echo "$(MOZ_SOURCE_REPO)/rev/$(MOZ_SOURCE_STAMP)" >> $(MOZ_SOURCESTAMP_FILE) + @echo '$(BUILDID)' > $(MOZ_SOURCESTAMP_FILE) + @echo '$(MOZ_SOURCE_REPO)/rev/$(MOZ_SOURCE_STAMP)' >> $(MOZ_SOURCESTAMP_FILE) .PHONY: make-buildinfo-file make-buildinfo-file: @@ -723,7 +723,7 @@ ifdef INSTALL_SDK # Here comes the hard part if test -f $(DIST)/include/xpcom-config.h; then \ $(SYSINSTALL) $(IFLAGS1) $(DIST)/include/xpcom-config.h $(DESTDIR)$(sdkdir); \ fi - find $(DIST)/sdk -name "*.pyc" | xargs rm -f + find $(DIST)/sdk -name '*.pyc' | xargs rm -f (cd $(DIST)/sdk/lib && $(TAR) $(TAR_CREATE_FLAGS) - .) | (cd $(DESTDIR)$(sdkdir)/sdk/lib && tar -xf -) (cd $(DIST)/sdk/bin && $(TAR) $(TAR_CREATE_FLAGS) - .) | (cd $(DESTDIR)$(sdkdir)/sdk/bin && tar -xf -) $(RM) -f $(DESTDIR)$(sdkdir)/lib $(DESTDIR)$(sdkdir)/bin $(DESTDIR)$(sdkdir)/include $(DESTDIR)$(sdkdir)/include $(DESTDIR)$(sdkdir)/sdk/idl $(DESTDIR)$(sdkdir)/idl @@ -735,7 +735,7 @@ endif # INSTALL_SDK make-sdk: $(MAKE) stage-package UNIVERSAL_BINARY= STAGE_SDK=1 MOZ_PKG_DIR=sdk-stage - @echo "Packaging SDK..." + @echo 'Packaging SDK...' $(RM) -rf $(DIST)/$(MOZ_APP_NAME)-sdk $(NSINSTALL) -D $(DIST)/$(MOZ_APP_NAME)-sdk/bin (cd $(DIST)/sdk-stage && $(TAR) $(TAR_CREATE_FLAGS) - .) | \ @@ -744,7 +744,7 @@ make-sdk: (cd $(DIST)/host/bin && $(TAR) $(TAR_CREATE_FLAGS) - .) | \ (cd $(DIST)/$(MOZ_APP_NAME)-sdk/host/bin && tar -xf -) $(NSINSTALL) -D $(DIST)/$(MOZ_APP_NAME)-sdk/sdk - find $(DIST)/sdk -name "*.pyc" | xargs rm -f + find $(DIST)/sdk -name '*.pyc' | xargs rm -f (cd $(DIST)/sdk && $(TAR) $(TAR_CREATE_FLAGS) - .) | \ (cd $(DIST)/$(MOZ_APP_NAME)-sdk/sdk && tar -xf -) $(NSINSTALL) -D $(DIST)/$(MOZ_APP_NAME)-sdk/include @@ -772,7 +772,7 @@ endif # deal with them. empty := space = $(empty) $(empty) -QUOTED_WILDCARD = $(if $(wildcard $(subst $(space),?,$(1))),"$(1)") +QUOTED_WILDCARD = $(if $(wildcard $(subst $(space),?,$(1))),'$(1)') ESCAPE_SPACE = $(subst $(space),\$(space),$(1)) ESCAPE_WILDCARD = $(subst $(space),?,$(1)) @@ -781,7 +781,7 @@ ESCAPE_WILDCARD = $(subst $(space),?,$(1)) CHECKSUM_ALGORITHM_PARAM = -d sha512 -d md5 -d sha1 # This variable defines where the checksum file will be located -CHECKSUM_FILE = "$(DIST)/$(PKG_PATH)/$(CHECKSUMS_FILE_BASENAME).checksums" +CHECKSUM_FILE = '$(DIST)/$(PKG_PATH)/$(CHECKSUMS_FILE_BASENAME).checksums' CHECKSUM_FILES = $(CHECKSUM_FILE) ifeq (WINNT,$(OS_TARGET)) @@ -835,9 +835,9 @@ checksum: $(CHECKSUM_ALGORITHM_PARAM) \ -s $(call QUOTED_WILDCARD,$(DIST)) \ $(UPLOAD_FILES) - @echo "CHECKSUM FILE START" + @echo 'CHECKSUM FILE START' @cat $(CHECKSUM_FILE) - @echo "CHECKSUM FILE END" + @echo 'CHECKSUM FILE END' $(SIGN_CHECKSUM_CMD) @@ -852,18 +852,18 @@ endif DIR_TO_BE_PACKAGED ?= ../$(notdir $(topsrcdir)) SRC_TAR_EXCLUDE_PATHS += \ - --exclude=".hg*" \ - --exclude="CVS" \ - --exclude=".cvs*" \ - --exclude=".mozconfig*" \ - --exclude="*.pyc" \ - --exclude="$(MOZILLA_DIR)/Makefile" \ - --exclude="$(MOZILLA_DIR)/dist" + --exclude='.hg*' \ + --exclude='CVS' \ + --exclude='.cvs*' \ + --exclude='.mozconfig*' \ + --exclude='*.pyc' \ + --exclude='$(MOZILLA_DIR)/Makefile' \ + --exclude='$(MOZILLA_DIR)/dist' ifdef MOZ_OBJDIR -SRC_TAR_EXCLUDE_PATHS += --exclude="$(MOZ_OBJDIR)" +SRC_TAR_EXCLUDE_PATHS += --exclude='$(MOZ_OBJDIR)' endif CREATE_SOURCE_TAR = $(TAR) -c --owner=0 --group=0 --numeric-owner \ - --mode="go-w" $(SRC_TAR_EXCLUDE_PATHS) -f + --mode=go-w $(SRC_TAR_EXCLUDE_PATHS) -f SOURCE_TAR = $(DIST)/$(PKG_SRCPACK_PATH)$(PKG_SRCPACK_BASENAME).tar.bz2 HG_BUNDLE_FILE = $(DIST)/$(PKG_SRCPACK_PATH)$(PKG_BUNDLE_BASENAME).bundle @@ -892,7 +892,7 @@ endif # source-package creates a source tarball from the files in MOZ_PKG_SRCDIR, # which is either set to a clean checkout or defaults to $topsrcdir source-package: - @echo "Packaging source tarball..." + @echo 'Packaging source tarball...' $(MKDIR) -p $(DIST)/$(PKG_SRCPACK_PATH) (cd $(MOZ_PKG_SRCDIR) && $(CREATE_SOURCE_TAR) - $(DIR_TO_BE_PACKAGED)) | bzip2 -vf > $(SOURCE_TAR) $(SIGN_SOURCE_TAR_CMD) @@ -903,4 +903,4 @@ hg-bundle: $(SIGN_HG_BUNDLE_CMD) source-upload: - $(MAKE) upload UPLOAD_FILES="$(SOURCE_UPLOAD_FILES)" CHECKSUM_FILE="$(SOURCE_CHECKSUM_FILE)" + $(MAKE) upload UPLOAD_FILES='$(SOURCE_UPLOAD_FILES)' CHECKSUM_FILE='$(SOURCE_CHECKSUM_FILE)' diff --git a/toolkit/mozapps/update/updater/Makefile.in b/toolkit/mozapps/update/updater/Makefile.in index 05e0fe26fa2f..b39c89d2979f 100644 --- a/toolkit/mozapps/update/updater/Makefile.in +++ b/toolkit/mozapps/update/updater/Makefile.in @@ -76,8 +76,8 @@ endif ifeq (cocoa,$(MOZ_WIDGET_TOOLKIT)) libs:: $(NSINSTALL) -D $(DIST)/bin/updater.app - rsync -a -C --exclude "*.in" $(srcdir)/macbuild/Contents $(DIST)/bin/updater.app - sed -e "s/%APP_NAME%/$(MOZ_APP_DISPLAYNAME)/" $(srcdir)/macbuild/Contents/Resources/English.lproj/InfoPlist.strings.in | \ + rsync -a -C --exclude '*.in' $(srcdir)/macbuild/Contents $(DIST)/bin/updater.app + sed -e 's/%APP_NAME%/$(MOZ_APP_DISPLAYNAME)/' $(srcdir)/macbuild/Contents/Resources/English.lproj/InfoPlist.strings.in | \ iconv -f UTF-8 -t UTF-16 > $(DIST)/bin/updater.app/Contents/Resources/English.lproj/InfoPlist.strings $(NSINSTALL) -D $(DIST)/bin/updater.app/Contents/MacOS $(NSINSTALL) $(DIST)/bin/updater $(DIST)/bin/updater.app/Contents/MacOS diff --git a/toolkit/xre/Makefile.in b/toolkit/xre/Makefile.in index f31f016e8798..2efb123efaa4 100644 --- a/toolkit/xre/Makefile.in +++ b/toolkit/xre/Makefile.in @@ -37,9 +37,9 @@ TOOLKIT_EM_VERSION=$(shell $(PERL) $(topsrcdir)/config/milestone.pl --topsrcdir= $(call warnIfEmpty,TOOLKIT_EM_VERSION) # Valid if null: {warn,error}IfEmpty -DEFINES += -DTOOLKIT_EM_VERSION=\"$(TOOLKIT_EM_VERSION)\" +DEFINES += -DTOOLKIT_EM_VERSION='"$(TOOLKIT_EM_VERSION)"' -MOZ_SOURCE_STAMP ?= $(firstword $(shell hg -R $(topsrcdir) parent --template="{node|short}\n" 2>/dev/null)) +MOZ_SOURCE_STAMP ?= $(firstword $(shell hg -R $(topsrcdir) parent --template='{node|short}\n' 2>/dev/null)) ifdef MOZ_SOURCE_STAMP INIARGS = --sourcestamp=$(MOZ_SOURCE_STAMP) diff --git a/toolkit/xre/test/win/Makefile.in b/toolkit/xre/test/win/Makefile.in index 565675c4a30e..dc1d63b2a640 100644 --- a/toolkit/xre/test/win/Makefile.in +++ b/toolkit/xre/test/win/Makefile.in @@ -19,7 +19,7 @@ libs:: TestXREMakeCommandLineWin.ini $(INSTALL) $^ $(FINAL_TARGET)/ check:: - @echo "Running TestXREMakeCommandLineWin tests" + @echo 'Running TestXREMakeCommandLineWin tests' @$(RUN_TEST_PROGRAM) $(FINAL_TARGET)/TestXREMakeCommandLineWin.exe - @echo "Running TestDllInterceptor tests" + @echo 'Running TestDllInterceptor tests' @$(RUN_TEST_PROGRAM) $(FINAL_TARGET)/TestDllInterceptor.exe diff --git a/tools/trace-malloc/Makefile.in b/tools/trace-malloc/Makefile.in index 3eae441960e6..8c9828bcec54 100644 --- a/tools/trace-malloc/Makefile.in +++ b/tools/trace-malloc/Makefile.in @@ -40,11 +40,11 @@ endif ifdef HAVE_BOUTELL_GD ifeq ($(OS_ARCH),WINNT) LOCAL_INCLUDES += \ - -I"$(HAVE_BOUTELL_GD)" \ + -I'$(HAVE_BOUTELL_GD)' \ $(NULL) LIBS += \ -lmozz_s \ - "$(HAVE_BOUTELL_GD)/gd.lib" \ + '$(HAVE_BOUTELL_GD)/gd.lib' \ $(NULL) else LIBS += \ diff --git a/tools/update-packaging/Makefile.in b/tools/update-packaging/Makefile.in index f58a60ca0cf7..a3d8b60e7547 100644 --- a/tools/update-packaging/Makefile.in +++ b/tools/update-packaging/Makefile.in @@ -35,9 +35,9 @@ full-update:: complete-patch ifeq ($(OS_TARGET), WINNT) MOZ_PKG_FORMAT := SFX7Z -UNPACKAGE = "$(subst $(DIST),$(_ABS_DIST),$(INSTALLER_PACKAGE))" +UNPACKAGE = '$(subst $(DIST),$(_ABS_DIST),$(INSTALLER_PACKAGE))' ifdef AB_CD -UNPACKAGE = "$(PACKAGE_BASE_DIR)/$(PACKAGE)" +UNPACKAGE = '$(PACKAGE_BASE_DIR)/$(PACKAGE)' endif endif @@ -56,24 +56,24 @@ dir-stage := $(call mkdir_deps,$(STAGE_DIR)) complete-patch:: $(dir-stage) ifeq ($(OS_TARGET), WINNT) test -f $(UNPACKAGE) - $(RM) -rf "$(PACKAGE_DIR)" + $(RM) -rf '$(PACKAGE_DIR)' cd $(PACKAGE_BASE_DIR) && $(INNER_UNMAKE_PACKAGE) endif MAR=$(MAR_BIN) \ $(srcdir)/make_full_update.sh \ - "$(STAGE_DIR)/$(PKG_UPDATE_BASENAME).complete.mar" \ - "$(PACKAGE_DIR)" + '$(STAGE_DIR)/$(PKG_UPDATE_BASENAME).complete.mar' \ + '$(PACKAGE_DIR)' ifdef MOZ_SIGN_PACKAGE_CMD - $(MOZ_SIGN_PACKAGE_CMD) "$(STAGE_DIR)/$(PKG_UPDATE_BASENAME).complete.mar" + $(MOZ_SIGN_PACKAGE_CMD) '$(STAGE_DIR)/$(PKG_UPDATE_BASENAME).complete.mar' endif partial-patch:: $(dir-stage) MAR=$(MAR_BIN) \ MBSDIFF=$(MBSDIFF_BIN) \ $(srcdir)/make_incremental_update.sh \ - "$(STAGE_DIR)/$(PKG_UPDATE_BASENAME).partial.$(SRC_BUILD_ID)-$(DST_BUILD_ID).mar" \ - "$(SRC_BUILD)" \ - "$(DST_BUILD)" + '$(STAGE_DIR)/$(PKG_UPDATE_BASENAME).partial.$(SRC_BUILD_ID)-$(DST_BUILD_ID).mar' \ + '$(SRC_BUILD)' \ + '$(DST_BUILD)' ifdef MOZ_SIGN_PACKAGE_CMD - $(MOZ_SIGN_PACKAGE_CMD) "$(STAGE_DIR)/$(PKG_UPDATE_BASENAME).partial.$(SRC_BUILD_ID)-$(DST_BUILD_ID).mar" + $(MOZ_SIGN_PACKAGE_CMD) '$(STAGE_DIR)/$(PKG_UPDATE_BASENAME).partial.$(SRC_BUILD_ID)-$(DST_BUILD_ID).mar' endif diff --git a/webapprt/Makefile.in b/webapprt/Makefile.in index 64f53b1a4101..c9e145357442 100644 --- a/webapprt/Makefile.in +++ b/webapprt/Makefile.in @@ -11,7 +11,7 @@ PREF_JS_EXPORTS = $(srcdir)/prefs.js \ include $(topsrcdir)/config/rules.mk libs:: $(call mkdir_deps,$(FINAL_TARGET)) - $(call py_action,buildlist,$(FINAL_TARGET)/chrome.manifest "resource webapprt ./") + $(call py_action,buildlist,$(FINAL_TARGET)/chrome.manifest 'resource webapprt ./') GRE_BUILDID := $(shell cat $(DEPTH)/config/buildid) DEFINES += -DGRE_BUILDID=$(GRE_BUILDID) diff --git a/xpcom/analysis/Makefile.in b/xpcom/analysis/Makefile.in index 9ab1af624cb8..99926fc59583 100644 --- a/xpcom/analysis/Makefile.in +++ b/xpcom/analysis/Makefile.in @@ -39,7 +39,7 @@ upload_classapi: done $(EXIT_ON_ERROR) \ for class in `cat graphtypes.list`; do \ - $(PYTHON) $(srcdir)/MDC-attach.py $${class}-graph.png en/$${class} "image/png" "Class inheritance graph"; \ + $(PYTHON) $(srcdir)/MDC-attach.py $${class}-graph.png en/$${class} image/png 'Class inheritance graph'; \ done GARBAGE += $(wildcard *.html) $(wildcard *.png) $(wildcard *.map) \ diff --git a/xpcom/tests/Makefile.in b/xpcom/tests/Makefile.in index 152cf5bcf9fa..70ee805cd3b8 100644 --- a/xpcom/tests/Makefile.in +++ b/xpcom/tests/Makefile.in @@ -29,8 +29,8 @@ endif abs_srcdir = $(abspath $(srcdir)) -regOrderDir="$(call getnativepath,$(abs_srcdir)/regorder)"; +regOrderDir = $(call getnativepath,$(abs_srcdir)/regorder) check:: XPCOM_DEBUG_BREAK=stack-and-abort $(RUN_TEST_PROGRAM) \ - $(DIST)/bin/TestRegistrationOrder$(BIN_SUFFIX) $(regOrderDir) + $(DIST)/bin/TestRegistrationOrder$(BIN_SUFFIX) '$(regOrderDir)' diff --git a/xpcom/tests/static-checker/Makefile.in b/xpcom/tests/static-checker/Makefile.in index 35d2422bb2a9..c394424642c2 100644 --- a/xpcom/tests/static-checker/Makefile.in +++ b/xpcom/tests/static-checker/Makefile.in @@ -115,32 +115,32 @@ check:: \ $(STATIC_PASS_TESTCASES:.cpp=.s-pass) %.s-fail: %.cpp $(GLOBAL_DEPS) $(DEHYDRA_SCRIPTS) $(call mkdir_deps,$(MDDEPDIR)) - @printf "Compiling $($(*F).errlog 2>&1; then \ - printf "fail:\nerror: compilation of $($(*F).errlog 2>&1; then \ - printf "fail:\nerror: compilation of $($(*F).werrlog 2>&1; then \ - printf "ok.\n"; \ + printf 'ok.\n'; \ else \ - printf "fail:\nerror: compilation of $($(*F).errlog 2>&1; then \ - printf "ok.\n"; \ + printf 'ok.\n'; \ else \ - printf "fail:\nerror: compilation of $( $(FRAMEWORK_DIR)/Info.plist + sed -e 's/APP_VERSION/$(APP_VERSION)/' $(srcdir)/macbuild/Info.plist.in > $(FRAMEWORK_DIR)/Info.plist rsync -av $(DIST)/bin/ $(FRAMEWORK_DIR) --exclude mangle --exclude shlibsign rm -f $(DIST)/$(FRAMEWORK_NAME).framework/Versions/Current \ $(DIST)/$(FRAMEWORK_NAME).framework/libxpcom.dylib \ diff --git a/xulrunner/build.mk b/xulrunner/build.mk index c1f0e4784517..5be83f352440 100644 --- a/xulrunner/build.mk +++ b/xulrunner/build.mk @@ -3,7 +3,7 @@ # file, You can obtain one at http://mozilla.org/MPL/2.0/. installer: - @echo "XULRunner doesn't have an installer yet." + @echo 'XULRunner doesn't have an installer yet.' package: @$(MAKE) -C xulrunner/installer