Skip to content
This repository has been archived by the owner on Aug 4, 2022. It is now read-only.

Commit

Permalink
Bug 1585751 - [lint.wpt] Work around mozprocess Windows + Python 3 bu…
Browse files Browse the repository at this point in the history
…g, r=jgraham

Depends on D47975

Differential Revision: https://phabricator.services.mozilla.com/D47976
  • Loading branch information
ahal committed Oct 3, 2019
1 parent 1cf9e15 commit 5df631c
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions tools/lint/wpt/wpt.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,15 @@ def process_line(line):

proc = ProcessHandler(cmd, env=os.environ, processOutputLine=process_line,
universal_newlines=True)

if sys.platform == 'win32':
# Workaround for bug 1585702. According to the win32 docs,
# CreateProcess will use the calling process's env by default. Since we
# are passing in `os.environ` wholesale anyway, setting the env to
# `None` shouldn't make a difference. An alternative workaround would
# be to stop using mozprocess here and use subprocess directly.
proc.env = None

proc.run()
try:
proc.wait()
Expand Down

0 comments on commit 5df631c

Please sign in to comment.