Bug 928625 - IonMonkey: Don't emit Unbox operators for values which a…

…ren't used. r=bhackett
mozilla-spidermonkey · Oct 22, 2013 · 5cb19e0 · 5cb19e0
1 parent 62baaa0
commit 5cb19e0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/js/src/jit-test/tests/ion/bug928625.js b/js/src/jit-test/tests/ion/bug928625.js
@@ -0,0 +1,3 @@
+var summary = true;
+evaluate("var summary = 'Array slice when arrays length is assigned';");
+evaluate('var summary;');
diff --git a/js/src/jit/IonBuilder.cpp b/js/src/jit/IonBuilder.cpp
@@ -6106,7 +6106,7 @@ IonBuilder::pushTypeBarrier(MInstruction *ins, types::TemporaryTypeSet *observed
 {
     // Barriers are never needed for instructions whose result will not be used.
     if (BytecodeIsPopped(pc))
-        needsBarrier = false;
+        return true;
 
     // If the instruction has no side effects, we'll resume the entire operation.
     // The actual type barrier will occur in the interpreter. If the