Skip to content

Set allowed Glean label maxLength to 111 #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025
Merged

Set allowed Glean label maxLength to 111 #843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions schemas/glean/glean/glean-min.1.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@
},
"propertyNames": {
"comment": "This must be at least the length of 'category.name' metric names to support error reporting",
"maxLength": 71,
"maxLength": 111,
"type": "string"
},
"type": "object"
Expand All @@ -154,7 +154,7 @@
},
"propertyNames": {
"comment": "This must be at least the length of 'category.name' metric names to support error reporting",
"maxLength": 71,
"maxLength": 111,
"type": "string"
},
"type": "object"
Expand Down Expand Up @@ -195,7 +195,7 @@
},
"propertyNames": {
"comment": "This must be at least the length of 'category.name' metric names to support error reporting",
"maxLength": 71,
"maxLength": 111,
"type": "string"
},
"type": "object"
Expand Down Expand Up @@ -235,7 +235,7 @@
},
"propertyNames": {
"comment": "This must be at least the length of 'category.name' metric names to support error reporting",
"maxLength": 71,
"maxLength": 111,
"type": "string"
},
"type": "object"
Expand All @@ -254,7 +254,7 @@
},
"propertyNames": {
"comment": "This must be at least the length of 'category.name' metric names to support error reporting",
"maxLength": 71,
"maxLength": 111,
"type": "string"
},
"type": "object"
Expand Down Expand Up @@ -288,7 +288,7 @@
},
"propertyNames": {
"comment": "This must be at least the length of 'category.name' metric names to support error reporting",
"maxLength": 71,
"maxLength": 111,
"type": "string"
},
"type": "object"
Expand All @@ -307,7 +307,7 @@
},
"propertyNames": {
"comment": "This must be at least the length of 'category.name' metric names to support error reporting",
"maxLength": 71,
"maxLength": 111,
"type": "string"
},
"type": "object"
Expand Down Expand Up @@ -383,7 +383,7 @@
},
"propertyNames": {
"comment": "This must be at least the length of 'category.name' metric names to support error reporting",
"maxLength": 71,
"maxLength": 111,
"type": "string"
},
"type": "object"
Expand Down
16 changes: 8 additions & 8 deletions schemas/glean/glean/glean.1.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@
},
"propertyNames": {
"comment": "This must be at least the length of 'category.name' metric names to support error reporting",
"maxLength": 71,
"maxLength": 111,
"type": "string"
},
"type": "object"
Expand All @@ -276,7 +276,7 @@
},
"propertyNames": {
"comment": "This must be at least the length of 'category.name' metric names to support error reporting",
"maxLength": 71,
"maxLength": 111,
"type": "string"
},
"type": "object"
Expand Down Expand Up @@ -317,7 +317,7 @@
},
"propertyNames": {
"comment": "This must be at least the length of 'category.name' metric names to support error reporting",
"maxLength": 71,
"maxLength": 111,
"type": "string"
},
"type": "object"
Expand Down Expand Up @@ -357,7 +357,7 @@
},
"propertyNames": {
"comment": "This must be at least the length of 'category.name' metric names to support error reporting",
"maxLength": 71,
"maxLength": 111,
"type": "string"
},
"type": "object"
Expand All @@ -376,7 +376,7 @@
},
"propertyNames": {
"comment": "This must be at least the length of 'category.name' metric names to support error reporting",
"maxLength": 71,
"maxLength": 111,
"type": "string"
},
"type": "object"
Expand Down Expand Up @@ -410,7 +410,7 @@
},
"propertyNames": {
"comment": "This must be at least the length of 'category.name' metric names to support error reporting",
"maxLength": 71,
"maxLength": 111,
"type": "string"
},
"type": "object"
Expand All @@ -429,7 +429,7 @@
},
"propertyNames": {
"comment": "This must be at least the length of 'category.name' metric names to support error reporting",
"maxLength": 71,
"maxLength": 111,
"type": "string"
},
"type": "object"
Expand Down Expand Up @@ -505,7 +505,7 @@
},
"propertyNames": {
"comment": "This must be at least the length of 'category.name' metric names to support error reporting",
"maxLength": 71,
"maxLength": 111,
"type": "string"
},
"type": "object"
Expand Down
2 changes: 2 additions & 0 deletions templates/include/glean/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# Version 1

- Glean label `maxLength` increased from 71 to 111

- New client_info sections `attribution` and `distribution`, and their fields [Bug 1955428](https://bugzilla.mozilla.org/show_bug.cgi?id=1955428)

- New metric type `labeled_quantity` [Bug 1932210](https://bugzilla.mozilla.org/show_bug.cgi?id=1932210)
Expand Down
2 changes: 1 addition & 1 deletion templates/include/glean/labeled_group.1.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"propertyNames": {
"type": "string",
"comment": "This must be at least the length of 'category.name' metric names to support error reporting",
"maxLength": 71
"maxLength": 111
}