Skip to content

Conversation

@acmiyaguchi
Copy link
Contributor

bug link

This adds the metadata field used by the ingestion system. The decoder will decide on how to fill in this field (which will likely be metrics.string.rally_id), which will be made available to shredder and consumers of the tables.

Checklist for reviewer:

For glean changes:

  • Update templates/include/glean/CHANGELOG.md

@auto-assign auto-assign bot requested a review from fbertsch March 16, 2021 20:31
@acmiyaguchi acmiyaguchi requested review from Dexterp37 and whd and removed request for fbertsch March 16, 2021 20:31
@dataops-ci-bot
Copy link

Integration report for "Remove pioneerId as a required field (can be rallyId)"

bq_schema_731721ab-f44e9480.diff

Click to expand!
diff --new-file --exclude '*.txt' /app/integration/731721ab/metadata.pioneer-decoded.1.bq /app/integration/f44e9480/metadata.pioneer-decoded.1.bq
227a228,233
>     "description": "Bug 1677567 - Custom rally id reported by the core addon",
>     "mode": "NULLABLE",
>     "name": "rally_id",
>     "type": "STRING"
>   },
>   {
diff --new-file --exclude '*.txt' /app/integration/731721ab/metadata.pioneer-error.1.bq /app/integration/f44e9480/metadata.pioneer-error.1.bq
136a137,142
>     "description": "Bug 1677567 - Custom rally id reported by the core addon",
>     "mode": "NULLABLE",
>     "name": "rally_id",
>     "type": "STRING"
>   },
>   {
diff --new-file --exclude '*.txt' /app/integration/731721ab/metadata.pioneer-ingestion.1.bq /app/integration/f44e9480/metadata.pioneer-ingestion.1.bq
180a181,186
>     "description": "Bug 1677567 - Custom rally id reported by the core addon",
>     "mode": "NULLABLE",
>     "name": "rally_id",
>     "type": "STRING"
>   },
>   {

compact_schema_731721ab-f44e9480.diff

Click to expand!
diff --new-file --exclude '*.bq' /app/integration/731721ab/metadata.pioneer-decoded.1.txt /app/integration/f44e9480/metadata.pioneer-decoded.1.txt
32a33
> root.rally_id STRING
diff --new-file --exclude '*.bq' /app/integration/731721ab/metadata.pioneer-error.1.txt /app/integration/f44e9480/metadata.pioneer-error.1.txt
25a26
> root.rally_id STRING
diff --new-file --exclude '*.bq' /app/integration/731721ab/metadata.pioneer-ingestion.1.txt /app/integration/f44e9480/metadata.pioneer-ingestion.1.txt
24a25
> root.rally_id STRING

Copy link
Member

@whd whd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be safe to merge since it is additive to existing operational schemas. I plan to merge this tomorrow pending :Dexter feedback.

@dataops-ci-bot
Copy link

Integration report for "Force the appearance of an id and add tests"

bq_schema_731721ab-3434aecc.diff

Click to expand!
diff --new-file --exclude '*.txt' /app/integration/731721ab/metadata.pioneer-decoded.1.bq /app/integration/3434aecc/metadata.pioneer-decoded.1.bq
227a228,233
>     "description": "Bug 1677567 - Custom rally id reported by the core addon",
>     "mode": "NULLABLE",
>     "name": "rally_id",
>     "type": "STRING"
>   },
>   {
diff --new-file --exclude '*.txt' /app/integration/731721ab/metadata.pioneer-error.1.bq /app/integration/3434aecc/metadata.pioneer-error.1.bq
136a137,142
>     "description": "Bug 1677567 - Custom rally id reported by the core addon",
>     "mode": "NULLABLE",
>     "name": "rally_id",
>     "type": "STRING"
>   },
>   {
diff --new-file --exclude '*.txt' /app/integration/731721ab/metadata.pioneer-ingestion.1.bq /app/integration/3434aecc/metadata.pioneer-ingestion.1.bq
180a181,186
>     "description": "Bug 1677567 - Custom rally id reported by the core addon",
>     "mode": "NULLABLE",
>     "name": "rally_id",
>     "type": "STRING"
>   },
>   {

compact_schema_731721ab-3434aecc.diff

Click to expand!
diff --new-file --exclude '*.bq' /app/integration/731721ab/metadata.pioneer-decoded.1.txt /app/integration/3434aecc/metadata.pioneer-decoded.1.txt
32a33
> root.rally_id STRING
diff --new-file --exclude '*.bq' /app/integration/731721ab/metadata.pioneer-error.1.txt /app/integration/3434aecc/metadata.pioneer-error.1.txt
25a26
> root.rally_id STRING
diff --new-file --exclude '*.bq' /app/integration/731721ab/metadata.pioneer-ingestion.1.txt /app/integration/3434aecc/metadata.pioneer-ingestion.1.txt
24a25
> root.rally_id STRING

@Dexterp37
Copy link
Collaborator

bug link

This adds the metadata field used by the ingestion system. The decoder will decide on how to fill in this field (which will likely be metrics.string.rally_id), which will be made available to shredder and consumers of the tables.

The field will likely bemetrics.uuid.rally_id (it's in the uuid section of the ping, not the string section).

@dataops-ci-bot
Copy link

Integration report for "Fix nits: extra newline and custom"

bq_schema_731721ab-dbb2fac8.diff

Click to expand!
diff --new-file --exclude '*.txt' /app/integration/731721ab/metadata.pioneer-decoded.1.bq /app/integration/dbb2fac8/metadata.pioneer-decoded.1.bq
227a228,233
>     "description": "Bug 1677567 - Rally id reported by the core addon",
>     "mode": "NULLABLE",
>     "name": "rally_id",
>     "type": "STRING"
>   },
>   {
diff --new-file --exclude '*.txt' /app/integration/731721ab/metadata.pioneer-error.1.bq /app/integration/dbb2fac8/metadata.pioneer-error.1.bq
136a137,142
>     "description": "Bug 1677567 - Rally id reported by the core addon",
>     "mode": "NULLABLE",
>     "name": "rally_id",
>     "type": "STRING"
>   },
>   {
diff --new-file --exclude '*.txt' /app/integration/731721ab/metadata.pioneer-ingestion.1.bq /app/integration/dbb2fac8/metadata.pioneer-ingestion.1.bq
180a181,186
>     "description": "Bug 1677567 - Rally id reported by the core addon",
>     "mode": "NULLABLE",
>     "name": "rally_id",
>     "type": "STRING"
>   },
>   {

compact_schema_731721ab-dbb2fac8.diff

Click to expand!
diff --new-file --exclude '*.bq' /app/integration/731721ab/metadata.pioneer-decoded.1.txt /app/integration/dbb2fac8/metadata.pioneer-decoded.1.txt
32a33
> root.rally_id STRING
diff --new-file --exclude '*.bq' /app/integration/731721ab/metadata.pioneer-error.1.txt /app/integration/dbb2fac8/metadata.pioneer-error.1.txt
25a26
> root.rally_id STRING
diff --new-file --exclude '*.bq' /app/integration/731721ab/metadata.pioneer-ingestion.1.txt /app/integration/dbb2fac8/metadata.pioneer-ingestion.1.txt
24a25
> root.rally_id STRING

@whd whd merged commit 5f21300 into master Mar 17, 2021
@whd whd deleted the rally-prefix branch March 17, 2021 19:04
dataops-pipeline-schemas added a commit that referenced this pull request Mar 17, 2021
5f21300	2021-03-17 19:04:16 +0000	Bug 1677567 - Add rallyId to pioneer metadata schemas (#665)
acmiyaguchi pushed a commit that referenced this pull request Mar 23, 2021
c2e18f4	2021-03-23 18:04:10 +0000	Bug 1697602 Remove AET schemas (#664)
5f21300	2021-03-17 19:04:16 +0000	Bug 1677567 - Add rallyId to pioneer metadata schemas (#665)
731721a	2021-03-09 10:03:38 -0800	Bug 1696074 - Add schema for uninstall-deletion ping in pioneer-core (#663)
793fc04	2021-03-08 09:55:50 -0500	Bug 1695795: Remove unused metric types from the Glean schema (#662)
04043f1	2021-03-02 08:30:04 -0500	Fix #660: Add the rate metric type (#661)
0a24af0	2021-02-24 10:43:58 -0500	[Bug 1694254] Add environment.settings.attribution.dltoken field
c2dae92	2021-02-22 18:30:19 +0000	Bug 1693305 - Clone citp-news-disinfo study (#658)
f3a1464	2021-02-17 16:05:26 -0600	Bug 1688698 - Add 'source' to TopSites schemas in Contextual Services (#657)
5904f8c	2021-02-12 16:29:41 -0600	Bug 1688698 - Add initial schemas for Contextual Services (#656)
bytesized pushed a commit to bytesized/mozilla-pipeline-schemas that referenced this pull request Aug 23, 2022
…es#665)

* Bug 1677567 - Add rallyId to pioneer metadata schemas

* Remove pioneerId as a required field (can be rallyId)

* Force the appearance of an id and add tests

* Fix nits: extra newline and custom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants