Skip to content

Bug 1688698 - Add 'source' to TopSites schemas in Contextual Services #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2021
Merged

Bug 1688698 - Add 'source' to TopSites schemas in Contextual Services #657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions schemas/contextual-services/topsites-click/topsites-click.1.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,14 @@
"description": "The reporting URL of the ad, normally pointing to the ad partner's reporting endpoint. It's URL encoded",
"type": "string"
},
"source": {
"description": "The browser location where the click was triggered",
"enum": [
"newtab",
"urlbar"
],
"type": "string"
},
"tile_id": {
"description": "A unique identifier for the sponsored tile",
"type": "integer"
Expand Down
8 changes: 8 additions & 0 deletions schemas/contextual-services/topsites-impression/topsites-impression.1.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,14 @@
"description": "The reporting URL of the ad, normally pointing to the ad partner's reporting endpoint. It's URL encoded",
"type": "string"
},
"source": {
"description": "The browser location where the impression was displayed",
"enum": [
"newtab",
"urlbar"
],
"type": "string"
},
"tile_id": {
"description": "A unique identifier for the sponsored tile",
"type": "integer"
Expand Down
5 changes: 5 additions & 0 deletions templates/contextual-services/topsites-click/topsites-click.1.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@
"description": "A unique identifier for the sponsored tile",
"type": "integer"
},
"source": {
"type": "string",
"enum": [ "newtab", "urlbar" ],
"description": "The browser location where the click was triggered"
},
"position": {
"description": "The placement of the tile (1-based)",
"type": "integer"
Expand Down
5 changes: 5 additions & 0 deletions templates/contextual-services/topsites-impression/topsites-impression.1.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@
"description": "A unique identifier for the sponsored tile",
"type": "integer"
},
"source": {
"type": "string",
"enum": [ "newtab", "urlbar" ],
"description": "The browser location where the impression was displayed"
},
"position": {
"description": "The placement of the tile (1-based)",
"type": "integer"
Expand Down
2 changes: 2 additions & 0 deletions validation/contextual-services/topsites-click.1.event.pass.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
{
"context_id": "{94642acb-4996-034b-916c-147da723cc41}",
"tile_id": 42,
"source": "urlbar",
"position": 1,
"advertiser": "test-advertiser",
"reporting_url": "https://test.reporting.net/ctp?version=16.0.0&key=1598991514900100001.1&ci=15 98991514792.12747&ctag=1598291839300100006&aespFlag=altinst",
"locale": "en-US",
Expand Down
1 change: 1 addition & 0 deletions validation/contextual-services/topsites-impression.1.event.pass.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"context_id": "{94642acb-4996-034b-916c-147da723cc41}",
"advertiser": "test-advertiser",
"tile_id": 42,
"source": "newtab",
"position": 1,
"reporting_url": "https://test.reporting.net/static?id=7RHzfOIWHG7kJnEYgGeuJm7vJ%3DEkiFXwxYIZjF8XgClWfC 8%2B7R4dHQ8zjmENj%3DNwxwz%2FJmdw7R4dHQfz4Z2ZfplnHG3Z5FwqgCfX4ZLafC2mfBINI9HuiF2 z4Z2ZfplnHmcux%3DcvImauiF2zfQlWfpDX7R3%2Bx%3DDuiF2zfLyy",
"locale": "en-US",
Expand Down