Fix #534 - Always run test step in circleci #539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbertsch
approved these changes
Apr 30, 2020
dataops-pipeline-schemas
added a commit
that referenced
this pull request
May 1, 2020
acmiyaguchi
pushed a commit
that referenced
this pull request
May 8, 2020
ba4db77 2020-05-07 14:53:32 -0400 Bug 1635212 - Handle frames property of threads in crash pings (#541) a4d3546 2020-05-07 10:54:30 -0700 Bug 1635959 - Add a pioneer-debug namespace for validation (#542) ed0397f 2020-05-07 11:29:47 -0400 Add description for profile_date 871f749 2020-05-07 11:29:47 -0400 Add reason field to installation ping 3553fc2 2020-05-07 11:29:47 -0400 Bug 1635152 - Fennec Installation ping 88149d0 2020-05-04 10:16:14 -0700 Bug 1404204 - require clientId in main pings (#536) 8951c19 2020-05-01 16:42:57 -0700 Bug 1634520, missing isFromTerminatorWatchdog in lateWrites telemetry schema (#538) 3160074 2020-04-30 13:48:10 -0700 Fix #534 - Always run test step in CircleCI (#539) 26a8c51 2020-04-30 16:21:05 -0400 Bug 1627843 - Missing iOS Core ping fields a048403 2020-04-27 11:26:40 -0700 Bug 1631849 - Remove pioneer-study pings and update pioneer-study envelope (#532)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #534 by removing the branch filter in the circleci configuration.
Checklist for reviewer:
.circleci/config.yml) will cause environment variables (particularly credentials) to be exposed in test logsintegrationCI test by pushing this revision as discussed in the README and review the report posted in the comments.For glean changes:
include/glean/CHANGELOG.md