-
Notifications
You must be signed in to change notification settings - Fork 97
Bug 1633525 - Remove frecency-update pings #533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like the new integration tests are failing. cc @acmiyaguchi |
|
This looks like its caused by the push to integration script. The build step contains the tests for detecting diffs in the BigQuery schemas, but the CircleCI configuration filters out this step. This should resolve itself in master and doesn't block this PR. |
|
In Bug 1633928, there's some discussion of flagging data we wish to delete using |
Yes, we discussed this in the May 4th technical check-in and agreed that since we will likely always want to create I'd therefore expect that before this PR is merged we'd deploy a change like mozilla/gcp-ingestion#1278. |
6958836 to
071d54b
Compare
mreid-moz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't merge this until we've solidified the process around deleting data in Bug 1633928.
|
closing this won't-fix with intent to revisit after @mreid-moz's bug is worked out. |
Checklist for reviewer:
.circleci/config.yml) will cause environment variables (particularly credentials) to be exposed in test logsintegrationCI test by pushing this revision as discussed in the README and review the report posted in the comments.For glean changes:
include/glean/CHANGELOG.md