Skip to content

Conversation

@fbertsch
Copy link
Contributor

@fbertsch fbertsch commented Apr 28, 2020

Checklist for reviewer:

  • Commits should reference a bug or github issue, if relevant (if a bug is referenced, the pull request should include the bug number in the title)
  • Scan the PR and verify that no changes (particularly to .circleci/config.yml) will cause environment variables (particularly credentials) to be exposed in test logs
  • If the PR comes from a fork, trigger the integration CI test by pushing this revision as discussed in the README and review the report posted in the comments.

For glean changes:

  • Update include/glean/CHANGELOG.md

@fbertsch fbertsch requested a review from akkomar April 28, 2020 15:04
@auto-assign auto-assign bot requested a review from sunahsuh April 28, 2020 15:06
@fbertsch fbertsch removed the request for review from sunahsuh April 28, 2020 15:07
@fbertsch
Copy link
Contributor Author

Looks like the new integration tests are failing. cc @acmiyaguchi

@whd whd requested a review from mreid-moz April 28, 2020 18:29
@acmiyaguchi
Copy link
Contributor

This looks like its caused by the push to integration script. The build step contains the tests for detecting diffs in the BigQuery schemas, but the CircleCI configuration filters out this step. This should resolve itself in master and doesn't block this PR.

@mreid-moz
Copy link
Contributor

In Bug 1633928, there's some discussion of flagging data we wish to delete using UnwantedDataExceptions - is that going to be done here before merging this PR?

@whd
Copy link
Member

whd commented May 19, 2020

In Bug 1633928, there's some discussion of flagging data we wish to delete using UnwantedDataExceptions - is that going to be done here before merging this PR?

Yes, we discussed this in the May 4th technical check-in and agreed that since we will likely always want to create UnwantedDataExceptions anyway (e.g. https://bugzilla.mozilla.org/show_bug.cgi?id=1635592 came eventually after the deletion in https://bugzilla.mozilla.org/show_bug.cgi?id=1626490), we can significantly simplify deploy semantics by always requiring that datasets pending deletion have all their data marked as UnwantedDataException in gcp-ingestion before the MPS PR is merged.

I'd therefore expect that before this PR is merged we'd deploy a change like mozilla/gcp-ingestion#1278.

Copy link
Contributor

@mreid-moz mreid-moz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't merge this until we've solidified the process around deleting data in Bug 1633928.

@relud
Copy link
Member

relud commented Sep 8, 2021

closing this won't-fix with intent to revisit after @mreid-moz's bug is worked out.

@relud relud closed this Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants