Skip to content

Conversation

@acmiyaguchi
Copy link
Contributor

bug link

This removes all of the pioneer-study pings under the respective namespaces. This also updates the telemetry/pioneer-study envelope schema to include a schemaNamespace for pioneer v2. This field is required, so it will start rejecting existing pioneer v1 pings into the error stream as a validation error.

Checklist for reviewer:

  • Commits should reference a bug or github issue, if relevant (if a bug is referenced, the pull request should include the bug number in the title)
  • Scan the PR and verify that no changes (particularly to .circleci/config.yml) will cause environment variables (particularly credentials) to be exposed in test logs
  • If the PR comes from a fork, trigger the integration CI test by pushing this revision as discussed in the README and review the report posted in the comments.

For glean changes:

  • Update include/glean/CHANGELOG.md

@auto-assign auto-assign bot requested a review from akkomar April 24, 2020 21:02
@acmiyaguchi acmiyaguchi requested review from fbertsch and removed request for akkomar April 24, 2020 21:04
@dataops-ci-bot
Copy link

Integration report for "Add encryptionKeyId to validation ping"

Report for upstream
Report for latest commit

cfd06fe-8e1b6a2.diff

No content detected.

bq_schema_cfd06fe-8e1b6a2.diff

Click to expand!
diff integration/cfd06fe/telemetry.pioneer-study.4.bq integration/8e1b6a2/telemetry.pioneer-study.4.bq
91a92,97
>         "description": "The namespace of the schema used for validation and routing to a dataset.",
>         "mode": "REQUIRED",
>         "name": "schema_namespace",
>         "type": "STRING"
>       },
>       {

Copy link
Contributor

@fbertsch fbertsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acmiyaguchi, how do you feel about moving pioneer_study to pioneer_study_envelope or just pioneer_envelope to make it more obvious what this is? That would also allow us to ignore the long tail of pioneer_study pings we're getting.

@acmiyaguchi
Copy link
Contributor Author

Moving a schema sounds involved, with the condition that the table is deleted before the next deploy. I'm in favor of reusing this since it requires no incompatible state changes in BigQuery and little to no change in the client code for submitting to the correct route.

As for the long tail, adding the new field will already allow us to reject the ping via a validation exception. Nothing stops us from marking this data as unwanted in the decoder since the study pings should get rerouted before they reach the telemetry decoder in the near future.

@acmiyaguchi acmiyaguchi requested a review from fbertsch April 27, 2020 18:11
Copy link
Contributor

@fbertsch fbertsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, you convinced me :)

@acmiyaguchi acmiyaguchi merged commit a048403 into master Apr 27, 2020
dataops-pipeline-schemas added a commit that referenced this pull request Apr 27, 2020
a048403	2020-04-27 11:26:40 -0700	 Bug 1631849 - Remove pioneer-study pings and update pioneer-study envelope (#532)
acmiyaguchi pushed a commit that referenced this pull request May 8, 2020
ba4db77	2020-05-07 14:53:32 -0400	Bug 1635212 - Handle frames property of threads in crash pings (#541)
a4d3546	2020-05-07 10:54:30 -0700	Bug 1635959 - Add a pioneer-debug namespace for validation (#542)
ed0397f	2020-05-07 11:29:47 -0400	Add description for profile_date
871f749	2020-05-07 11:29:47 -0400	Add reason field to installation ping
3553fc2	2020-05-07 11:29:47 -0400	Bug 1635152 - Fennec Installation ping
88149d0	2020-05-04 10:16:14 -0700	Bug 1404204 - require clientId in main pings (#536)
8951c19	2020-05-01 16:42:57 -0700	Bug 1634520, missing isFromTerminatorWatchdog in lateWrites telemetry schema (#538)
3160074	2020-04-30 13:48:10 -0700	Fix #534 - Always run test step in CircleCI (#539)
26a8c51	2020-04-30 16:21:05 -0400	Bug 1627843 - Missing iOS Core ping fields
a048403	2020-04-27 11:26:40 -0700	 Bug 1631849 - Remove pioneer-study pings and update pioneer-study envelope (#532)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants