-
Notifications
You must be signed in to change notification settings - Fork 97
Bug 1631849 - Remove pioneer-study pings and update pioneer-study envelope #532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Integration report for "Add encryptionKeyId to validation ping"Report for upstream
|
fbertsch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@acmiyaguchi, how do you feel about moving pioneer_study to pioneer_study_envelope or just pioneer_envelope to make it more obvious what this is? That would also allow us to ignore the long tail of pioneer_study pings we're getting.
|
Moving a schema sounds involved, with the condition that the table is deleted before the next deploy. I'm in favor of reusing this since it requires no incompatible state changes in BigQuery and little to no change in the client code for submitting to the correct route. As for the long tail, adding the new field will already allow us to reject the ping via a validation exception. Nothing stops us from marking this data as unwanted in the decoder since the study pings should get rerouted before they reach the telemetry decoder in the near future. |
fbertsch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, you convinced me :)
ba4db77 2020-05-07 14:53:32 -0400 Bug 1635212 - Handle frames property of threads in crash pings (#541) a4d3546 2020-05-07 10:54:30 -0700 Bug 1635959 - Add a pioneer-debug namespace for validation (#542) ed0397f 2020-05-07 11:29:47 -0400 Add description for profile_date 871f749 2020-05-07 11:29:47 -0400 Add reason field to installation ping 3553fc2 2020-05-07 11:29:47 -0400 Bug 1635152 - Fennec Installation ping 88149d0 2020-05-04 10:16:14 -0700 Bug 1404204 - require clientId in main pings (#536) 8951c19 2020-05-01 16:42:57 -0700 Bug 1634520, missing isFromTerminatorWatchdog in lateWrites telemetry schema (#538) 3160074 2020-04-30 13:48:10 -0700 Fix #534 - Always run test step in CircleCI (#539) 26a8c51 2020-04-30 16:21:05 -0400 Bug 1627843 - Missing iOS Core ping fields a048403 2020-04-27 11:26:40 -0700 Bug 1631849 - Remove pioneer-study pings and update pioneer-study envelope (#532)
bug link
This removes all of the pioneer-study pings under the respective namespaces. This also updates the telemetry/pioneer-study envelope schema to include a
schemaNamespacefor pioneer v2. This field is required, so it will start rejecting existing pioneer v1 pings into the error stream as a validation error.Checklist for reviewer:
.circleci/config.yml) will cause environment variables (particularly credentials) to be exposed in test logsintegrationCI test by pushing this revision as discussed in the README and review the report posted in the comments.For glean changes:
include/glean/CHANGELOG.md