Skip to content

Commit d3af01c

Browse files
Thom Chiovolonischoltzan
authored andcommitted
Apply review feedback
1 parent 7eb93bf commit d3af01c

File tree

4 files changed

+26
-18
lines changed

4 files changed

+26
-18
lines changed

schemas/telemetry/sync/sync.4.schema.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -234,15 +234,19 @@
234234
{
235235
"properties": {
236236
"entries": {
237+
"minimum": 0,
237238
"type": "integer"
238239
},
239240
"entriesSuccessful": {
241+
"minimum": 0,
240242
"type": "integer"
241243
},
242244
"extensions": {
245+
"minimum": 0,
243246
"type": "integer"
244247
},
245248
"extensionsSuccessful": {
249+
"minimum": 0,
246250
"type": "integer"
247251
},
248252
"openFailure": {

schemas/telemetry/sync/sync.5.schema.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -248,15 +248,19 @@
248248
{
249249
"properties": {
250250
"entries": {
251+
"minimum": 0,
251252
"type": "integer"
252253
},
253254
"entriesSuccessful": {
255+
"minimum": 0,
254256
"type": "integer"
255257
},
256258
"extensions": {
259+
"minimum": 0,
257260
"type": "integer"
258261
},
259262
"extensionsSuccessful": {
263+
"minimum": 0,
260264
"type": "integer"
261265
},
262266
"openFailure": {
Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
11
{
2-
"type": "object",
3-
"required": ["type"],
4-
"properties": {
5-
"type": { "type": "string" }
6-
},
7-
"anyOf": [
8-
{
9-
"properties": {
10-
"type": { "const": "webext-storage" },
11-
"entries": { "type": "integer" },
12-
"entriesSuccessful": { "type": "integer" },
13-
"extensions": { "type": "integer" },
14-
"extensionsSuccessful": { "type": "integer" },
15-
"openFailure": { "type": "boolean" }
16-
}
17-
}
18-
]
2+
"type": "object",
3+
"required": ["type"],
4+
"properties": {
5+
"type": { "type": "string" }
6+
},
7+
"anyOf": [
8+
{
9+
"properties": {
10+
"type": { "const": "webext-storage" },
11+
"entries": { "type": "integer", "minimum": 0 },
12+
"entriesSuccessful": { "type": "integer", "minimum": 0 },
13+
"extensions": { "type": "integer", "minimum": 0 },
14+
"extensionsSuccessful": { "type": "integer", "minimum": 0 },
15+
"openFailure": { "type": "boolean" }
16+
}
17+
}
18+
]
1919
}

validation/telemetry/sync.4.migration.pass.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,4 +53,4 @@
5353
"sessionStartDate": "2019-02-15T13:00:00.0-04:00",
5454
"syncNodeType": "some-type"
5555
}
56-
}
56+
}

0 commit comments

Comments
 (0)