Skip to content

Commit bd473e7

Browse files
committed
Bug 1686229 - Add loadStatus to the third-party-modules ping
This patch adds a new optional integer field `loadStatus` in the existing third-party-modules ping.
1 parent 039bfa8 commit bd473e7

File tree

3 files changed

+10
-1
lines changed

3 files changed

+10
-1
lines changed

schemas/telemetry/third-party-modules/third-party-modules.4.schema.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1444,6 +1444,10 @@
14441444
"description": "Time spent loading this module, in milliseconds.",
14451445
"type": "number"
14461446
},
1447+
"loadStatus": {
1448+
"description": "The status of DLL load. This corresponds to enum ModuleLoadInfo::Status.",
1449+
"type": "integer"
1450+
},
14471451
"moduleIndex": {
14481452
"description": "Index of the element in the modules array that contains details about the module that was loaded during this event.",
14491453
"minimum": 0,

templates/telemetry/third-party-modules/third-party-modules.4.schema.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,10 @@
113113
"isDependent": {
114114
"description": "True if the module is included in the executable's Import Directory Table.",
115115
"type": "boolean"
116+
},
117+
"loadStatus": {
118+
"description": "The status of DLL load. This corresponds to enum ModuleLoadInfo::Status.",
119+
"type": "integer"
116120
}
117121
},
118122
"required": [

validation/telemetry/third-party-modules.4.sample.pass.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -412,7 +412,8 @@
412412
"processUptimeMS": 1844676547,
413413
"baseAddress": "0x7ffed1330000",
414414
"moduleIndex": 0,
415-
"isDependent": false
415+
"isDependent": false,
416+
"loadStatus": 0
416417
}
417418
]
418419
}

0 commit comments

Comments
 (0)