Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FXIOS-275 ⁃ New Tab "Custom URL" placeholder text is barely visible #6153

Closed
SimonBasca opened this issue Feb 24, 2020 · 3 comments
Closed

FXIOS-275 ⁃ New Tab "Custom URL" placeholder text is barely visible #6153

SimonBasca opened this issue Feb 24, 2020 · 3 comments
Labels
Bug 🐞 This is a bug with existing functionality not behaving as expected Contributor OK This is a good issue for contributors interested in helping the project

Comments

@SimonBasca
Copy link
Contributor

SimonBasca commented Feb 24, 2020 •
edited by data-sync-user
Loading

Build: 23.0(17297)
Device: iPhone X
iOS: 13.3

Preconditions:

  • Set theme to Manual Light.
  • Set iOS theme to Dark.

Steps to reproduce:

  1. Go to Settings -> New Tab
  2. Check the "Custom URL" placeholder text

Actual results:

  • The placeholder text is barley visible

Expected results:

  • The placeholder text should be visible

Screen Shot 2020-02-24 at 2 00 19 PM

┆Issue is synchronized with this Jira Task
@SimonBasca SimonBasca added the Bug 🐞 This is a bug with existing functionality not behaving as expected label Feb 24, 2020
@SimonBasca SimonBasca changed the title New Tab "Custom URL" placeholder text is barley visible New Tab "Custom URL" placeholder text is barely visible Feb 24, 2020
@dnarcese dnarcese added the Contributor OK This is a good issue for contributors interested in helping the project label Feb 28, 2020
@LamourBt
Copy link
Contributor

LamourBt commented Mar 2, 2020 •
edited
Loading

I think this issue and that #6152 are related. The problem would go away if we assigned a color to UIColor.theme.general.settingsTextPlaceholder which has for current value nil. What could should I use here? @athomasmoz (passcodeDot seems to work fine).

@tomislaveric
Copy link
Contributor

tomislaveric commented May 26, 2020 •
edited
Loading

Hi, i my last PR #6678 i fixed all of those issues. The PR was merged and should now be ok in master Could you please take a look? If all is ok, this issue can be deleted

Simulator Screen Shot - iPhone 11 Pro - 2020-05-26 at 12 06 07

@data-sync-user data-sync-user changed the title New Tab "Custom URL" placeholder text is barely visible FXIOS-275 ⁃ New Tab "Custom URL" placeholder text is barely visible Oct 17, 2020
@adudenamedruby
Copy link
Contributor

Closing as a dupe of #6512

@boek boek closed this as completed Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🐞 This is a bug with existing functionality not behaving as expected Contributor OK This is a good issue for contributors interested in helping the project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@boek @adudenamedruby @dnarcese @LamourBt @tomislaveric @SimonBasca