Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Proper Attribution of Dependencies (license notices) #1015

Open
linuxwolf opened this issue May 24, 2019 · 5 comments
Open

Proper Attribution of Dependencies (license notices) #1015

linuxwolf opened this issue May 24, 2019 · 5 comments

Comments

@linuxwolf
Copy link
Contributor

linuxwolf commented May 24, 2019

Information on the dependencies and their copyrights/licenses should be present in the software.

At the least, this repository should include the following information on the dependencies:

  • Name
  • Copyright Notice
  • License (reference)

There is discussion that it may need to be presentable to users of this software in some form.

Design

Description: The inclusion of a new menu item is also a new opportunity to reorganize this structure; I've made the following changes to the Settings list:

  • Change label of "Configuration" to "General"
  • Move the newly named "General" section to the top of the order stack
  • Create a new "About Section" at base of list, above "Lock Now"
  • Move the App Version to the "About Section"
  • Create a new "Licenses" subsection for containing the proper attribution of dependencies

Settings Section
InVision: https://mozilla.invisionapp.com/share/BQEUSO0S2#/267560609_Settings_-_Touch_ID_Enabled
Zeplin: https://zpl.io/VKNMd5W

Licenses Webview
Invision: https://mozilla.invisionapp.com/share/BQEUSO0S2#/384809123_Settings_-_Licenses
Zeplin: https://zpl.io/V0p3zrK

Note: There needs to be a responsive webview URL (location and build TBD) for housing all licenses, as Firefox has done for their licenses.

References

BMO 1548663
BMO 1561740

@linuxwolf linuxwolf changed the title Proper Attribute of Dependencies Proper Attribution of Dependencies May 24, 2019
@joeyg
Copy link
Contributor

joeyg commented Jun 12, 2019

@sandysage Firefox iOS just has all the licenses dumped into an HTML file that is linked from Settings (https://github.com/mozilla-mobile/firefox-ios/blob/master/Client/Assets/About/Licenses.html). Is that reasonable to do here?

@devinreams devinreams changed the title Proper Attribution of Dependencies Proper Attribution of Dependencies (license notices) Jul 2, 2019
@rfk
Copy link

rfk commented Jul 31, 2019

For A-S, we now include a list of dependencies in the repo here:

https://github.com/mozilla/application-services/blob/master/megazords/ios/DEPENDENCIES.md

It will be updated automatically if our set of dependencies changes (or rather, CI will prevent landing dependency updates without regenerating this file).

@changecourse
Copy link
Contributor

@sandysage @ddurst I've updated the description above and have provided everything (I think) for us to begin development. Please review and prioritize accordingly :)

@changecourse
Copy link
Contributor

It's also worth mentioning that the location, URL structure, and building of the responsive mobile page still need to be completed for this effort.

@ddurst
Copy link

ddurst commented Sep 21, 2019

LGTM

@st3fan st3fan closed this as completed Jan 27, 2021
@st3fan st3fan reopened this Feb 1, 2021
@st3fan st3fan removed the archived label Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants