Skip to content
This repository was archived by the owner on Sep 18, 2023. It is now read-only.

Commit ce8e389

Browse files
authored
Merge pull request #196 from gene1wood/change_id_token_for_roles
Change idtoken_for_roles_url format to https://example.com/roles
2 parents 2f39367 + d4dd3a9 commit ce8e389

File tree

3 files changed

+13
-3
lines changed

3 files changed

+13
-3
lines changed

CHANGELOG.md

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
66

77
## [Unreleased]
88

9+
## [1.1.0] - 2020-02-13
10+
### Changed
11+
* Revert the change in [#160](https://github.com/mozilla-iam/mozilla-aws-cli/issues/160)
12+
in which the URL format for idtoken_for_roles_url was changed from
13+
https://example.com/roles to https://example.com/. Now with this reversion,
14+
the idtoken_for_roles_url should again be the full URL ending in `/roles`.
15+
This change is not backwards compatible and will require that a config file
16+
or config module be changed to use the new full URL.
17+
918
## [1.0.0] - 2020-02-05
1019
### Added
1120
* Feature to pass the "cache" argument that the user asserts on the command line
@@ -90,7 +99,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
9099
### Added
91100
* Initial release of the mozilla-aws-cli tool
92101

93-
[Unreleased]: https://github.com/mozilla-iam/mozilla-aws-cli/compare/v1.0.0...HEAD
102+
[Unreleased]: https://github.com/mozilla-iam/mozilla-aws-cli/compare/v1.1.0...HEAD
103+
[1.1.0]: https://github.com/mozilla-iam/mozilla-aws-cli/compare/v1.0.0...v1.1.0
94104
[1.0.0]: https://github.com/mozilla-iam/mozilla-aws-cli/compare/v0.2.0...v1.0.0
95105
[0.2.0]: https://github.com/mozilla-iam/mozilla-aws-cli/compare/v0.1.1...v0.2.0
96106
[0.1.1]: https://github.com/mozilla-iam/mozilla-aws-cli/compare/v0.1.0...v0.1.1

mozilla_aws_cli/login.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,7 @@ def validate_id_token(self):
323323
def get_role_map(self):
324324
# get the role map, either from cache or from the endpoint
325325
self.state = "getting_role_map"
326-
url = "{}roles".format(self.idtoken_for_roles_url)
326+
url = self.idtoken_for_roles_url
327327
self.role_map = get_roles_and_aliases(
328328
endpoint=url,
329329
token=self.token["id_token"],

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,6 @@
5757
tests_require=test_requirements,
5858
extras_require=extras,
5959
url="https://github.com/mozilla-iam/mozilla-aws-cli",
60-
version="1.0.0",
60+
version="1.1.0",
6161
zip_safe=False,
6262
)

0 commit comments

Comments
 (0)