-
Notifications
You must be signed in to change notification settings - Fork 5
chore: set checkLocalVariables to true on jsx-handler-names rules #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 33 33
Lines 42 42
Branches 1 1
=========================================
Hits 42 42
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
While not intentional, this is a breaking change correct? |
We are missing a test in https://github.com/moxystudio/eslint-config/blob/master/packages/eslint-config-react/test/rules/react.js. |
Object { | ||
"column": 43, | ||
"line": 4, | ||
"rule": "react/jsx-handler-names", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This error shouldn't happen as the function is anonymous.. I guess that's a deal breaker for now, see: jsx-eslint/eslint-plugin-react#2586
@ruimonteiro93, what's the status of this? Please follow up. |
@acostalima we can’t merge this until #91 (comment) is solved. |
This is to ensure that all event handlers are properly named, according to the rules specified.