Skip to content

Port motion-planning-api to ROS2 #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

facontidavide
Copy link
Contributor

Description

Ported one of the tutorials to ROS2

Checklist

@vatanaksoytezer
Copy link
Contributor

@facontidavide do you mind running pre-commit for formatting?

PS: If you can pre-commit install. It would automatically do formatting for you in every git-commit from now on.

@vatanaksoytezer
Copy link
Contributor

@facontidavide can we get a rebase on this one?

Copy link
Member

@tylerjw tylerjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs rebased.

Comment on lines +14 to +17
This tutoral has made use of **xterm** and a simple prompter to help the user progress through each demo step.
To install xterm please run the following command: ::

sudo apt-get install -y xterm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer necessary, please convert this to use the rvizvisualtools prompt?

@mergify
Copy link

mergify bot commented Nov 3, 2021

This pull request is in conflict. Could you fix it @facontidavide?

@vatanaksoytezer
Copy link
Contributor

Closing since #247 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants