Skip to content

Commit c26bb67

Browse files
motiz88facebook-github-bot
authored andcommitted
Use Node v14 in Windows CircleCI jobs (facebook#31656)
Summary: Pull Request resolved: facebook#31656 CircleCI's Windows executor currently ships with a pre-LTS release of Node v12, breaking our Windows jobs ([example](https://app.circleci.com/pipelines/github/facebook/react-native/9280/workflows/21e6e59c-d853-47a1-af62-1368c8ce10ce/jobs/203983)) following facebook#30637, ultimately due to jestjs/jest#10685 dropping support for non-LTS versions in the Node v12 release line. Luckily, the Windows executor [does ship with nvm](circleci/circleci-docs#3733) so we can use that to install a desired Node version. Rather than just pinning a later v12 release that is LTS, we align the Windows config with the one for non-Windows jobs (in the `nodelts` executor) by running against the latest available Node v14 release. Changelog: [Internal] Differential Revision: D28896581 fbshipit-source-id: ed490bcdae80e736338c387e255191d8be1888cb
1 parent b637b21 commit c26bb67

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

.circleci/config.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ executors:
2727
nodelts:
2828
<<: *defaults
2929
docker:
30+
# Note: Version set separately for Windows builds, see below.
3031
- image: circleci/node:14
3132
nodeprevlts:
3233
<<: *defaults
@@ -624,6 +625,11 @@ jobs:
624625
steps:
625626
- checkout
626627

628+
- run:
629+
name: Install Node
630+
# Note: Version set separately for non-Windows builds, see above.
631+
command: nvm install 14 && nvm use 14
632+
627633
# Setup Dependencies
628634
- run:
629635
name: Install Yarn

0 commit comments

Comments
 (0)