MOTECH-3178: Fixed PMD issue.

Author: pkornowski

openmrs/src/main/java/org/motechproject/openmrs/exception/OpenMRSException.java

@@ -1,9 +1,14 @@
 package org.motechproject.openmrs.exception;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.springframework.web.client.HttpClientErrorException;
+
 /**
  * Thrown when there were problems while fetching data from OpenMRS server.
  */
 public class OpenMRSException extends RuntimeException {
+    private static final Logger LOGGER = LoggerFactory.getLogger(OpenMRSException.class);
 
     public OpenMRSException(Throwable e) {
         super(e);
@@ -15,5 +20,10 @@ public OpenMRSException(String message) {
 
     public OpenMRSException(String message, Throwable cause) {
         super(message, cause);
+
+        if (cause instanceof HttpClientErrorException) {
+            HttpClientErrorException httpCause = (HttpClientErrorException) cause;
+            LOGGER.debug("{} {} {}", message, httpCause.getMessage(), httpCause.getResponseBodyAsString());
+        }
     }
 }

openmrs/src/main/java/org/motechproject/openmrs/resource/impl/BaseResource.java

@@ -10,7 +10,6 @@
 import org.springframework.http.HttpMethod;
 import org.springframework.http.MediaType;
 import org.springframework.http.ResponseEntity;
-import org.springframework.web.client.HttpClientErrorException;
 import org.springframework.web.client.RestOperations;
 
 import java.net.URI;
@@ -62,14 +61,9 @@ protected String postForJson(Config config, String json, String path, Object...
         LOGGER.debug("{} request body: {}", buildUrl(config, path, params), json);
         String responseJson;
 
-        try {
-            ResponseEntity<String> responseEntity = exchange(config, buildUrl(config, path, params), HttpMethod.POST, json, headers);
-            responseJson = responseEntity.getBody();
-            LOGGER.debug("{} response body with HTTP CODE {}: {}", buildUrl(config, path, params), responseEntity.getStatusCode(), responseJson);
-        } catch(HttpClientErrorException e) {
-            LOGGER.debug("{} {} {}", buildUrl(config, path, params), e.getMessage(), e.getResponseBodyAsString());
-            throw new HttpClientErrorException(e.getStatusCode(), e.getStatusText(), e.getResponseBodyAsByteArray(), null);
-        }
+        ResponseEntity<String> responseEntity = exchange(config, buildUrl(config, path, params), HttpMethod.POST, json, headers);
+        responseJson = responseEntity.getBody();
+        LOGGER.debug("{} response body with HTTP CODE {}: {}", buildUrl(config, path, params), responseEntity.getStatusCode(), responseJson);
 
         return responseJson;
     }