Added class to set S3 events (#393)

* Update lint and test settings

* Add S3Events class

* Fix comment

* Fix info message

Author: abetomo

lib/s3_events.js

@@ -0,0 +1,82 @@
+'use strict'
+
+/**
+ * Do not create S3 bucket.
+ * Put the Notification Configuration in the existing Bucket.
+ */
+class S3Events {
+  constructor (aws) {
+    // Authenticated `aws` object in `lib/main.js`
+    this.lambda = new aws.Lambda({
+      apiVersion: '2015-03-31'
+    })
+    this.s3 = new aws.S3({
+      apiVersion: '2006-03-01'
+    })
+  }
+
+  _functionName (params) {
+    return params.FunctionArn.split(':').pop()
+  }
+
+  _addPermissionParams (params) {
+    return {
+      Action: 'lambda:InvokeFunction',
+      FunctionName: this._functionName(params),
+      Principal: 's3.amazonaws.com',
+      SourceArn: 'arn:aws:s3:::' + params.Bucket,
+      StatementId: params.Bucket
+    }
+  }
+
+  _addPermission (params) {
+    return new Promise((resolve, reject) => {
+      const _params = this._addPermissionParams(params)
+      this.lambda.addPermission(_params, (err, data) => {
+        if (err) {
+          if (err.code !== 'ResourceConflictException') reject(err)
+          // If it exists it will result in an error but there is no problem.
+          resolve('Permission already set')
+        }
+        resolve(data)
+      })
+    })
+  }
+
+  _putBucketNotificationConfigurationParams (params) {
+    const lambdaFunctionConfiguration = {
+      Events: params.Events,
+      LambdaFunctionArn: params.FunctionArn
+    }
+    if (params.Filter != null) {
+      lambdaFunctionConfiguration.Filter = params.Filter
+    }
+
+    return {
+      Bucket: params.Bucket,
+      NotificationConfiguration: {
+        LambdaFunctionConfigurations: [
+          lambdaFunctionConfiguration
+        ]
+      }
+    }
+  }
+
+  _putBucketNotificationConfiguration (params) {
+    return new Promise((resolve, reject) => {
+      const _params = this._putBucketNotificationConfigurationParams(params)
+      this.s3.putBucketNotificationConfiguration(_params, (err, data) => {
+        if (err) reject(err)
+        resolve(data)
+      })
+    })
+  }
+
+  add (params) {
+    return this._addPermission(params).then(() => {
+      return this._putBucketNotificationConfiguration(params)
+    })
+  }
+}
+
+module.exports = S3Events

lib/schedule_events.js

@@ -59,7 +59,7 @@ class ScheduleEvents {
         if (err) {
           if (err.code !== 'ResourceConflictException') throw err
           // If it exists it will result in an error but there is no problem.
-          resolve('Already exists permission')
+          resolve('Permission already set')
         }
         resolve(data)
       })

package.json

@@ -7,7 +7,9 @@
     "test": "test"
   },
   "scripts": {
-    "test": "standard && standard bin/node-lambda && mocha"
+    "lint": "standard && standard bin/node-lambda",
+    "test": "npm run lint && npm run unit",
+    "unit": "mocha"
   },
   "bin": {
     "node-lambda": "./bin/node-lambda"

test/s3_events.js

@@ -0,0 +1,147 @@
+'use strict'
+
+const assert = require('chai').assert
+const path = require('path')
+const aws = require('aws-sdk-mock')
+aws.setSDK(path.resolve('node_modules/aws-sdk'))
+const S3Events = require('../lib/s3_events')
+
+const params = {
+  FunctionArn: 'arn:aws:lambda:us-west-2:XXX:function:node-lambda-test-function',
+  Bucket: 'node-lambda-test-bucket',
+  Events: ['s3:ObjectCreated:*'],
+  Filter: null
+}
+
+const mockResponse = {
+  addPermission: {
+    Statement: JSON.stringify({
+      Sid: 'node-lambda-test-bucket',
+      Resource: 'arn:aws:lambda:node-lambda-test-function',
+      Effect: 'Allow',
+      Principal: { Service: 's3.amazonaws.com' },
+      Action: [ 'lambda:InvokeFunction' ],
+      Condition: { ArnLike: { 'AWS:SourceArn': 'arn:aws:s3:::node-lambda-test-bucket' } }
+    })
+  },
+
+  putBucketNotificationConfiguration: {}
+}
+
+var s3Events = null
+
+/* global before, after, describe, it */
+describe('lib/s3_events', () => {
+  before(() => {
+    aws.mock('Lambda', 'addPermission', (params, callback) => {
+      callback(null, mockResponse.addPermission)
+    })
+    aws.mock('S3', 'putBucketNotificationConfiguration', (params, callback) => {
+      callback(null, mockResponse.putBucketNotificationConfiguration)
+    })
+
+    s3Events = new S3Events(require('aws-sdk'))
+  })
+
+  after(() => {
+    aws.restore('Lambda')
+    aws.restore('S3')
+  })
+
+  describe('_functionName', () => {
+    it('Extract name from FunctionArn', () => {
+      assert.equal(
+        s3Events._functionName(params),
+        'node-lambda-test-function'
+      )
+    })
+  })
+
+  describe('_addPermissionParams', () => {
+    it('Return parameters for lambda.addPermission()', () => {
+      const expected = {
+        Action: 'lambda:InvokeFunction',
+        FunctionName: 'node-lambda-test-function',
+        Principal: 's3.amazonaws.com',
+        SourceArn: 'arn:aws:s3:::node-lambda-test-bucket',
+        StatementId: 'node-lambda-test-bucket'
+      }
+      assert.deepEqual(s3Events._addPermissionParams(params), expected)
+    })
+  })
+
+  describe('_putBucketNotificationConfigurationParams', () => {
+    it('Return parameters for s3.putBucketNotificationConfiguration(). No Filter', () => {
+      const expected = {
+        Bucket: 'node-lambda-test-bucket',
+        NotificationConfiguration: {
+          LambdaFunctionConfigurations: [{
+            Events: ['s3:ObjectCreated:*'],
+            LambdaFunctionArn: 'arn:aws:lambda:us-west-2:XXX:function:node-lambda-test-function'
+          }]
+        }
+      }
+      assert.deepEqual(
+        s3Events._putBucketNotificationConfigurationParams(params),
+        expected
+      )
+    })
+
+    it('Return parameters for s3.putBucketNotificationConfiguration(). Use Filter', () => {
+      const expected = {
+        Bucket: 'node-lambda-test-bucket',
+        NotificationConfiguration: {
+          LambdaFunctionConfigurations: [{
+            Events: ['s3:ObjectCreated:*'],
+            LambdaFunctionArn: 'arn:aws:lambda:us-west-2:XXX:function:node-lambda-test-function',
+            Filter: {
+              Key: {
+                FilterRules: [{
+                  Name: 'prefix',
+                  Value: 'test-prefix'
+                }]
+              }
+            }
+          }]
+        }
+      }
+      const _params = Object.assign({}, params)
+      _params.Filter = {
+        Key: {
+          FilterRules: [{
+            Name: 'prefix',
+            Value: 'test-prefix'
+          }]
+        }
+      }
+      assert.deepEqual(
+        s3Events._putBucketNotificationConfigurationParams(_params),
+        expected
+      )
+    })
+  })
+
+  describe('_addPermission', () => {
+    it('using mock', () => {
+      return s3Events._addPermission(params).then(data => {
+        assert.deepEqual(data, mockResponse.addPermission)
+      })
+    })
+  })
+
+  describe('_putBucketNotificationConfiguration', () => {
+    it('using mock', () => {
+      return s3Events._putBucketNotificationConfiguration(params).then(data => {
+        assert.deepEqual(data, mockResponse.putBucketNotificationConfiguration)
+      })
+    })
+  })
+
+  describe('add', () => {
+    it('using mock', () => {
+      return s3Events.add(params).then(data => {
+        assert.deepEqual(data, mockResponse.putBucketNotificationConfiguration)
+      })
+    })
+  })
+})