[force remove] slippage check for #789

Author: adhusson

src/adapters/MorphoMarketV1Adapter.sol

@@ -112,6 +112,7 @@ contract MorphoMarketV1Adapter is IMorphoMarketV1AdapterStaticTyping {
         uint256 mintedShares;
         if (assets > 0) {
             (, mintedShares) = IMorpho(morpho).supply(marketParams, assets, 0, address(this), hex"");
+            require(mintedShares >= assets, SharePriceTooHigh());
             position.supplyShares += uint128(mintedShares);
         }
 

src/adapters/interfaces/IMorphoMarketV1Adapter.sol

@@ -25,12 +25,13 @@ interface IMorphoMarketV1AdapterBase is IAdapter {
 
     /* ERRORS */
 
+    error AlreadyPending();
     error LoanAssetMismatch();
     error NotAuthorized();
+    error NotPending();
     error NotTimelocked();
+    error SharePriceTooHigh();
     error TimelockNotExpired();
-    error AlreadyPending();
-    error NotPending();
 
     /* FUNCTIONS */
 

test/integration/MorphoMarketV1IntegrationAllocationTest.sol

@@ -140,4 +140,20 @@ contract MorphoMarketV1IntegrationAllocationTest is MorphoMarketV1IntegrationTes
 
         assertEq(adapter.marketParamsListLength(), 1, "duplicate market in market list");
     }
+
+    function testAllocateWithSlippage() public {
+        // Increase rate by borrowing.
+        deal(address(collateralToken), borrower, type(uint256).max);
+        vm.startPrank(borrower);
+        collateralToken.approve(address(morpho), type(uint256).max);
+        morpho.supplyCollateral(marketParams1, 2 * initialInMarket1, borrower, hex"");
+        morpho.borrow(marketParams1, initialInMarket1, 0, borrower, borrower);
+        vm.stopPrank();
+
+        vm.warp(block.timestamp + 60 * 60 * 24 * 365 * 200); //200 years
+
+        vm.prank(allocator);
+        vm.expectRevert(IMorphoMarketV1AdapterBase.SharePriceTooHigh.selector);
+        vault.allocate(address(adapter), abi.encode(marketParams1), 100);
+    }
 }

test/integration/MorphoMarketV1IntegrationTest.sol

@@ -7,7 +7,10 @@ import "../BaseTest.sol";
 import {MorphoMarketV1Adapter} from "../../src/adapters/MorphoMarketV1Adapter.sol";
 import {MorphoMarketV1AdapterFactory} from "../../src/adapters/MorphoMarketV1AdapterFactory.sol";
 import {IMorphoMarketV1AdapterFactory} from "../../src/adapters/interfaces/IMorphoMarketV1AdapterFactory.sol";
-import {IMorphoMarketV1Adapter} from "../../src/adapters/interfaces/IMorphoMarketV1Adapter.sol";
+import {
+    IMorphoMarketV1Adapter,
+    IMorphoMarketV1AdapterBase
+} from "../../src/adapters/interfaces/IMorphoMarketV1Adapter.sol";
 
 import {ORACLE_PRICE_SCALE} from "../../lib/morpho-blue/src/libraries/ConstantsLib.sol";
 import {OracleMock} from "../../lib/morpho-blue/src/mocks/OracleMock.sol";